From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7C99C46CD2 for ; Tue, 9 Jan 2024 16:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tt+4MxpYO4TJWRUOHsyH2bIUhORa3EZXsbpuXLP3p1A=; b=ZJcbQK17Ez2XXo B99bklURNgkjUha/po0wdhR+kY1tpn+p04eju7GNzmQyeX9r0b0rbX5kuzVqpp2RLnZkorjbIWMEs 2Ul7ZGK+zpBuBQW3Pv5ioNICmzf2wb6CcgK+BOCyQxwKLQLFISqHSweUW+HyIVDh3oiHAxrXYxLVM 8RzKxWSVj/WBFVvPuyBgdCs+HVIm2bypvxilemQKGDIWS5Py8Gi8JmuWb9Gx7C6Y2Y+Qb0Zgz0hCB t4YbDgmrukapA/FX5OAaVOEGChJYnCWB+JvoqQfHZHLysz6qN6HD/3WiI8ixJj923Q90JNrmm31FX 1Tx2pTJ0zDVPbvj8fxeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNEij-008nAZ-2Z; Tue, 09 Jan 2024 16:12:53 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNEif-008n9k-2U for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 16:12:52 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40e5280a381so5451165e9.2 for ; Tue, 09 Jan 2024 08:12:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704816765; x=1705421565; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QLuwkV3YqBM7cDd6d4I1FcvjfJRMJpmS9TLQKnHh3LA=; b=Z/6Aoi2GI+tUF9Sl6EWafIWtdDpIIAfG2tfp3r7pEoKllvjiWDVNzZ5d/tKKjKS89s k0wOJWtxv6Y++nWhMyI3/+BeCK+WozJPQh38dFseh3f4qoayduODZtZLOBrm0BZ/2R7/ +7YNTZBmoCiH5PdH9Nh2+K/Ow+7hzAjBHSm1Jy+8fON5T+gi5iiRZnA0eFDrhB+A2J7Q mcs51NBTjf5O//A43+YN1szfZew77EyFn/PMFn4jB/NXJ5w/U/i91dNfrxoFmOFzeAYJ J2h2O64F5c8YBeCuMOTy+IXZOjL3rzKQMugS3son16DagAIykrTkRdATc+s7wVZ6of/I Ua0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704816765; x=1705421565; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QLuwkV3YqBM7cDd6d4I1FcvjfJRMJpmS9TLQKnHh3LA=; b=TiKXn10aO52C5MAAQqH1Fjw3JcaKHGPRudC6yi7vjrFCzlAUgUEsGgLsqwDHWpTPrQ etWWs2IY5IBQdwiFl3+RVvifSwTVwk+q4b2w+MnGvZ0Ge4d71f7NtjAlD0B+Ms51tiOu aR0qgKwhZ5byZqVd+OseuBo7OCN8MMvOH2MYkYpSmofKKe5+9Qw6prEvI8h7dhEZq40d rJfkIjmV5hnHe83YoDaz6DLoeMSKiRIZYwPdUcBhmtMiGpdLzT7fkrDkSnXyFSceVQmW IWAdJTsCfl+yExsDyhUTDeQ6hjXwsRPs2UZDLjGYGgQUb4RjBdBXxnUg46RB7cZCGgCz e7AA== X-Gm-Message-State: AOJu0YxZuHaNAFiqfPLYwnncnzSwCflswdfNkDM7sO6a8zCnot87Vpz2 WT3I7nGPnPkx99IItsA8B4BibLGfHStVAQ== X-Google-Smtp-Source: AGHT+IE+jtYqbzFOWQJKYy4Sd1zW2XS5XwcHZK4TTZRMLsCeki8cy1luWp6DEum2EBB3JZlw2mRT8A== X-Received: by 2002:a05:600c:ccd:b0:40e:52cf:3c2c with SMTP id fk13-20020a05600c0ccd00b0040e52cf3c2cmr313625wmb.73.1704816764893; Tue, 09 Jan 2024 08:12:44 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c1d8600b0040e4c1dade4sm4205471wms.36.2024.01.09.08.12.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 08:12:44 -0800 (PST) Message-ID: <38523622-4963-44a5-a5d6-64896ae47e09@linaro.org> Date: Tue, 9 Jan 2024 16:12:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring Cc: peter.griffin@linaro.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, kernel-team@android.com References: <20231228125805.661725-1-tudor.ambarus@linaro.org> <20231228125805.661725-2-tudor.ambarus@linaro.org> <20240109040315.GA2619804-robh@kernel.org> <8a55e1d9-c102-4cdf-8f23-edc40889cf6d@linaro.org> From: Tudor Ambarus In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_081250_332083_8F9232D3 X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/9/24 15:01, Krzysztof Kozlowski wrote: > On 09/01/2024 12:58, Tudor Ambarus wrote: >> >> >> On 1/9/24 11:09, Krzysztof Kozlowski wrote: >>> On 09/01/2024 05:03, Rob Herring wrote: >>>> On Thu, Dec 28, 2023 at 12:57:54PM +0000, Tudor Ambarus wrote: >>>>> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0) >>>>> clock management unit. >>>>> >>>>> Reviewed-by: Sam Protsenko >>>>> Signed-off-by: Tudor Ambarus >>>>> --- >>>>> v2: >>>>> - fix comments as per Sam's suggestion and collect his R-b tag >>>>> - Rob's suggestion of renaming the clock-names to just "bus" and "ip" >>>>> was not implemented as I felt it affects readability in the driver >>>>> and consistency with other exynos clock drivers. I will happily update >>>>> the names in the -rc phase if someone else has a stronger opinion than >>>>> mine. >>>> >>>> I'll defer to Krzysztof. >>> >>> I miss the point why clock-names cannot be fixed now. This is the name >>> of property, not the input clock name. >> >> They can be fixed now. I've just aired the fixes at: >> https://lore.kernel.org/linux-arm-kernel/20240109114908.3623645-1-tudor.ambarus@linaro.org/ >> >> Preparing v3 for this patch set to include the updated names here too. > > I think I was not that clear enough. I did not get your current patchset > - so PERIC0 clock controller - cannot use new naming. > Ok, I understand that the fixes from https://lore.kernel.org/linux-arm-kernel/20240109114908.3623645-1-tudor.ambarus@linaro.org/ are NACK-ed and I shall use the full clock-names in this patch set as well, thus "dout_cmu_peric0_bus", and "dout_cmu_peric0_ip". I don't mind changing them back, will send a v4 using the full clock names. Out of curiosity, why can't we change the names? All gs101 patches are for v6.8, thus they haven't made a release yet. We still have the -rc phase where we can fix things. Thanks for the guidance. ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel