[PATCH V2 2/2] ARM: dts: imx6q: add Novena board

Marek Vasut
2015-11-20T21:05:33Z

On Friday, November 20, 2015 at 09:58:39 PM, Fabio Estevam wrote:
> On Fri, Nov 20, 2015 at 6:46 PM, Marek Vasut <marex@denx.de> wrote:
> > From: Sean Cross <xobs@kosagi.com>
> >
> > Novena is an open-hardware laptop/desktop/bare board.
> >
> > See http://www.kosagi.com/w/index.php?title=Novena_Main_Page
> >
> > Signed-off-by: Sean Cross <xobs@kosagi.com>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Sean Cross <xobs@kosagi.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
>
> Looks good:
> Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Two minor comments:
> > +&fec {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_enet_novena>;
> > + phy-mode = "rgmii";
> > + phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> > + mac-address = [00 00 00 00 00 00];
>
> This mac-address entry could be removed, right?
>
> > +&ssi1 {
> > + fsl,mode = "i2s-slave";
>
> Please remove this one. It is no longer used.

Yeah, and I should've dropped the spidev node altogether.

Best regards,
Marek Vasut