From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89B0C433ED for ; Sat, 17 Apr 2021 21:24:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A147611AF for ; Sat, 17 Apr 2021 21:24:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A147611AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LGVJ+U24VhbUmkXGfDxtOlGasMCm4j650ndPNSwsv7k=; b=albjiKDXntg2caSPyHcd2gR6U UclbSdfVJel1+GGEPL4YjMf1XydVsnztaJ+okry2BhbTwxdN93+yFmz1swoPBIh5qHw/xgMcFPvGI 04TWD+LA8Kszm6CroGZ0JWxiQ34YrkUoFzyxw2u045FrWSY7wDA0lkKcaGidA1b/Spxd3FfKo2Dji Q8cEnQ9mRUfLjVWs60o5EbzDsak8mOtVkcVVQINMSXuwtXBdo8SoEnZoRTEqAifmtUmQtx6r3k1VK vUqNy4dguPQF8H/Leke435VmEtDEl2hbbzep35uTr+sll3LfN8/eytyNF2LmuOcaR8FZ8xZrWVyo/ Dq743vHWA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXsMs-006ITL-Kc; Sat, 17 Apr 2021 21:20:52 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXsM3-006IHk-A5 for linux-arm-kernel@desiato.infradead.org; Sat, 17 Apr 2021 21:19:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=Si0pnxL89C+e7eTmMrmBl5h7DZh/cENUMffwzmg7sAQ=; b=XU5uWzYDgPdWz3bD6ZL1kTjjVu UWKiaSnSdLR1UI1LWCaazg93MJGW6LJJnXMeYpgUlukw/c6GL4Clzyq/JuGAtV7IV9DSE3O3CnXxK 0/MNfMP4YoEGwjuHiRS1SzOQPWduNFgUlJtwg0TKja29jiEqBWnUIvm1yIzToiYHZEBj+i6qhVmPv PcnJWemN/qahf8lfp4mJrryx8FE12AMoOGKmZgpsLzj0K/eD5qtwwcW8Z6R3AsaJWLDs7+Nx525z0 zxZiAhJxPuE2R8Diq6yGZ86QyUX3GnsDal10rZeaHyF/tfzuz9BMTvW9d3AKnlE4XmivrVcrIC5t8 B/2OrnTQ==; Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXsLO-00BhsN-Ho for linux-arm-kernel@lists.infradead.org; Sat, 17 Apr 2021 21:19:19 +0000 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-261-JBH8CRNiMlWoKO_dEnAufg-1; Sat, 17 Apr 2021 22:18:58 +0100 X-MC-Unique: JBH8CRNiMlWoKO_dEnAufg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 17 Apr 2021 22:18:57 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.015; Sat, 17 Apr 2021 22:18:57 +0100 From: David Laight To: 'Matthew Wilcox' , "brouer@redhat.com" CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "ilias.apalodimas@linaro.org" , "mcroce@linux.microsoft.com" , "grygorii.strashko@ti.com" , "arnd@kernel.org" , "hch@lst.de" , "linux-snps-arc@lists.infradead.org" , "mhocko@kernel.org" , "mgorman@suse.de" Subject: RE: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems Thread-Topic: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems Thread-Index: AQHXMzO/f1yRrc3ugkWz9MvyD1ZvgKq5Nwpg Date: Sat, 17 Apr 2021 21:18:57 +0000 Message-ID: <386d009232dc42bdaf83d4cc36b13864@AcuMS.aculab.com> References: <20210416230724.2519198-1-willy@infradead.org> <20210416230724.2519198-2-willy@infradead.org> <20210417024522.GP2531743@casper.infradead.org> In-Reply-To: <20210417024522.GP2531743@casper.infradead.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210417_221916_801888_AF8BE561 X-CRM114-Status: UNSURE ( 6.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Matthew Wilcox > Sent: 17 April 2021 03:45 > > Replacement patch to fix compiler warning. ... > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + ret |= (dma_addr_t)page->dma_addr[1] << 16 << 16; Ugly as well. Why not just replace the (dma_addr_t) cast with a (u64) one? Looks better than the double shift. Same could be done for the '>> 32'. Is there an upper_32_bits() that could be used?? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel