From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CB7EC3DA42 for ; Wed, 17 Jul 2024 10:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cuvh8UGOYhVgD7LMSF7m6PX9NwUCq4RQT2avheEo2IY=; b=rT4LjLFSk7hz1rQtG7CCNuM9KN UIHesd+O2d468Hb+wKVnAuPZaqXWc0VfaHSCqUyIrA44L45C1uG+VgQjYAIxtj/dWFp55VKlUpl0y YSVyFrL1KbZ5rb6E2NHKVBis7wtPImfWhT6iNkz9ZDVtw8DR8sOLZ3Ct4P2rVM7mQ9no8XbCT9ttr /0zdWSvcCbhavZJVDn8LMGS92BLbKNiGQILS0JkIEkV8/L/jeagi/9PBnjnzS1R8ZxVSmjIq6IRO8 VDYNOuXIr9BA6Y1UPfsAF5c0EPq/0TRe6a/ZWpjrTSseCUKpQ/ZE+RmbM3JdbcBDcIA/vbxRp0tY4 A1TFqQTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU1kI-0000000DT0E-2AQg; Wed, 17 Jul 2024 10:18:50 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sU1jw-0000000DSuk-2w1S; Wed, 17 Jul 2024 10:18:30 +0000 Received: from i5e860d09.versanet.de ([94.134.13.9] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sU1je-0006py-5K; Wed, 17 Jul 2024 12:18:10 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-kernel@vger.kernel.org, Conor Dooley , Otavio Salvador Cc: conor@kernel.org, Conor Dooley , Dinh Nguyen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Huacai Chen , WANG Xuerui , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, imx@lists.linux.dev, loongarch@lists.linux.dev Subject: Re: [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1 Date: Wed, 17 Jul 2024 12:18:08 +0200 Message-ID: <3870188.FjKLVJYuhi@diego> In-Reply-To: <20240717-parrot-malt-83cc04bf6b36@spud> References: <20240717-anvil-ashy-544e80a1317c@spud> <20240717-parrot-malt-83cc04bf6b36@spud> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240717_031828_781139_5A65C3D1 X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org adding Otavio, Am Mittwoch, 17. Juli 2024, 11:37:54 CEST schrieb Conor Dooley: > From: Conor Dooley > > The Rohm dh2228fv (really the bh2228fv, the compatible in the kernel has > a typo) does not support frequencies above 10 MHz, nor per the > datasheet appear to use either CPOL or CPHA. I suspect that this > devicetree is abusing the compatible in order to bind the spidev driver > in Linux. Pretending to have devices on a board for this purpose is not > acceptable, so remove it. Reasoning is sound, so I'll pick this up after the merge window. > Signed-off-by: Conor Dooley > --- > I could not find any documentation for this board online, and it does > not blatantly say that the device is a "spidev" like other [ab]users, so > it is possible there's actually a DAC here - but I doubt it is a > bh2228fv given the other incompatibilities. Otavio, as the original submitter of the Elgin R1 [0], do you happen to know what type of device this is? Especially as there really do not seem to be any schematics around for that board. Heiko [0] https://patchwork.kernel.org/project/linux-rockchip/patch/20190104014023.17973-4-otavio@ossystems.com.br/ > --- > arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts > index 2d9994379eb2..9df1cef406c5 100644 > --- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts > +++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts > @@ -167,14 +167,6 @@ &spi { > pinctrl-names = "default"; > pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>; > status = "okay"; > - > - dh2228fv: dac@0 { > - compatible = "rohm,dh2228fv"; > - reg = <0>; > - spi-max-frequency = <24000000>; > - spi-cpha; > - spi-cpol; > - }; > }; > > &u2phy { >