From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Wed, 20 Aug 2014 14:29:17 -0500 Subject: [PATCH v3 2/4] pwm: rockchip: Allow polarity invert on rk3288 In-Reply-To: References: <1408464476-28316-1-git-send-email-dianders@chromium.org> <1408464476-28316-3-git-send-email-dianders@chromium.org> <20140820100447.GG15414@ulmo> Message-ID: <387c82a0-efeb-431d-b8a5-200f24bc47ff@email.android.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On August 20, 2014 1:54:11 PM CDT, Doug Anderson wrote: >On Wed, Aug 20, 2014 at 3:04 AM, Thierry Reding > wrote: >> On Tue, Aug 19, 2014 at 09:07:54AM -0700, Doug Anderson wrote: >>> The rk3288 has the ability to invert >>> + struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip); >>> + >>> + if (!pc->data->has_invert) >>> + return -ENOSYS; >>> + At the kernel summit hpa also mentioned that ENOSYS should only be used for missing syscalls. Not sure what error code would suit better here though... Thanks. -- Dmitry