From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C89ED1CDC5 for ; Tue, 22 Oct 2024 09:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K51whSOoccfWJ1oT5QsGS1IjvPrInQRVrtM/UwrHahw=; b=p32z5UyW4YKn7xig1bIrqBgoyL GJhvB7p21iNgn7f4xpAjFAdVvEZtmbKQ2NGWSleIoEcuWYto4+WukTO5lxdXRUxmZzYFXQCvB3bEf towxyZfmrJKPk+2aGGnUzXD3y1AzzfSnxTv1v2gFa6UM/ysnsIMWV6SoeZq2iq4YpWCgm8i8SbnhN 6R4ByWQRD0PFK18KiRkwYu3hLwRchQshkN4PsH5/OeI/Nwp+1KUJat1hXcxlMhoYnOuq2W4Zh8j5M xaQvs0GSCqDKPzJLTed/aS3TPeHbZX4flMtMErNJAfXXWGdiK5f+HPGBafFKiBlHJWMnmj3SU/LEo SFaafV1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3B21-0000000AJgi-0ahg; Tue, 22 Oct 2024 09:18:25 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3AyR-0000000AIfu-2XBr; Tue, 22 Oct 2024 09:14:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=K51whSOoccfWJ1oT5QsGS1IjvPrInQRVrtM/UwrHahw=; b=g+VCpVlYxX1Sj8Ti8vI92swsSp JF8RArNqBCqCW0WiaCYXKKzelMuSmtcY+D0htMS66EPPVz5ziPlCa5xkS0LKgk+R6bP5IJbZsy+yD F9QwVJhYOFtQoL1kR39gkc8HZzLEL/D6ZPjXOOb1h3HQQcnPXK/JTJJCoBScRyqD/idGJYk0MvAuu PDYVg28X2880xU7eQV9PSqCWBH6Jnris/lnddkhz5jA3PGoXpTvY9+U53luYY68QN67vPft7Fh6wx DycXstlfZndEU+lZShjvWPg2vcj4+36+KSojlZXsnmwI6Rmk3aWidR4jejLS5sqbhIbWMaHqqbwvt tWE392Ow==; Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3AyO-00000008AXF-1pxy; Tue, 22 Oct 2024 09:14:42 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-20cbcd71012so48372705ad.3; Tue, 22 Oct 2024 02:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729588477; x=1730193277; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K51whSOoccfWJ1oT5QsGS1IjvPrInQRVrtM/UwrHahw=; b=nHuvm3eETa2K+iLXI3huA+/5u6yixmuKlZiqv1kvrvyY08FzcJWQZ9yk1bxA6YmcwZ HLW5dW55ymr9t0q+BB2EhqOOAQt6OqfsnvPPVbsQNTr3qyKnPLoOA7aiLpigQ6xz/dDF FUXrqkLnr7l+VizXMqInrHg5u1OYCkqGpdC8/Kpg1Uf0T8sRS5/AsLzlJX42256meYxd i5+Cu+Q6tumO5qjmfUzQgPOJ9216H0f8dozOS6olOPfY0U3Qr26e7m3MESq1q+hz87tP WWp6nq3UOzoWXksLjtjQmklwEL0oNMIK+C7zn3cPEnPqjC0ILKwQa2aFWwN/TEL0Wl04 4I/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729588477; x=1730193277; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K51whSOoccfWJ1oT5QsGS1IjvPrInQRVrtM/UwrHahw=; b=AmK/2k2f6BxVEriD2I1hEJ0Nm83073GFHxvCWp9STDYpNHbMH+nn9oTCFtO12ba+C0 0dTtxsG4dSbjxLdhsBc82fYHYF5wkLlHb4XfHu9buTGsixdj7Om8sLPmiCoCsWs7f1ND y1PORvFOCxJp/SYb87EMttotu8dUvv25rqdU3fzFKzwwlYeI25jxCp8hInT7z8BLlCv7 LPMDXRUKNIZPG/rC9uozdise4E6SsCaLC1oEPGyWa2Sm+qcGiPsO3feiY1jv+EZ9EMvT /GKYifR4M/Z1+1r0rvPBEKLTOPbYL/GjzgVXA//48TnjxW8yn2dfnJ77pzrZ4A5b0irv DapA== X-Forwarded-Encrypted: i=1; AJvYcCVSp9/PEdQVKvFSiRVeoc1f4rDPPujtnwXJ46Dv2ot+F/+8pC9qp0VWw9xd7lT3zIkOdiZf/FvBCzdm2P5VhNS8@lists.infradead.org, AJvYcCXv9FYHBE1NIwL8VxIciwk1HkqghQhJf3A6bhWskMysYcBswVFhdXWd8h0I5J0QDGMCz6z4fiPYheLb@lists.infradead.org X-Gm-Message-State: AOJu0YxBTc6MWiHeae8sYnVhFop003W/L0NGDP3pRr4TjBqBhDzVeM6p vw/k+SgLdX0UFua3kiiJ6Fb86mCfTYdwX+fbKpDo6bcRcti8GbBE X-Google-Smtp-Source: AGHT+IHH9sYrSSvfbEf+31ytxi3WDRRewNjbMkhS8kbu4X5qoBQrSZpw/oFE2eqC02U58aD5xBFgQQ== X-Received: by 2002:a17:902:d2ce:b0:20b:6a57:bf25 with SMTP id d9443c01a7336-20e5a7749damr228551665ad.20.1729588476937; Tue, 22 Oct 2024 02:14:36 -0700 (PDT) Received: from [172.19.1.53] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0bd48fsm38623195ad.129.2024.10.22.02.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2024 02:14:36 -0700 (PDT) Message-ID: <38aba46a-c5e5-4832-8a73-4260d5a94b68@gmail.com> Date: Tue, 22 Oct 2024 17:14:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC To: Miquel Raynal Cc: richard@nod.at, vigneshr@ti.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nikita.shubin@maquefel.me, arnd@arndb.de, vkoul@kernel.org, esben@geanix.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241018022519.721914-1-hpchen0nvt@gmail.com> <20241018022519.721914-3-hpchen0nvt@gmail.com> <20241021103254.1f31205b@xps-13> <9cfd923a-4bc8-4a6c-986d-8d0c6fd6d9bb@gmail.com> <20241022105109.1906f524@xps-13> Content-Language: en-US From: Hui-Ping Chen In-Reply-To: <20241022105109.1906f524@xps-13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_101440_646740_7465026B X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Miquel, Thank you for your reply. On 2024/10/22 下午 04:51, Miquel Raynal wrote: > Hi Hui-Ping, > >>>> + >>>> +static int ma35_nand_write_page_hwecc(struct nand_chip *chip, const u8 *buf, >>>> + int oob_required, int page) >>>> +{ >>> The hardware ECC engine should always be disabled by default. >>> >>> Then, in these helpers you should: >>> * enable the ECC engine >>> * do your things >>> * disable the ECC engine >> The ECC engine of the MA35 NAND controller cannot be turned on or off separately. >> >> The ECC engine is activated with the DMA, >> >> and it calculates and writes to the OOB during the transfer. > What about: > > ECC Algorithm Enable Bit [23] ECCEN > > This field is used to select the ECC algorithm for data > protecting. The BCH algorithm can correct 8 or 12 or 24 bits. > 0 = BCH code encode/decode Disabled. > 1 = BCH code encode/decode Enabled. > > ? That's right, this bit represents this meaning, but ECC operations will only occur when DMA is activated. I will add enable/disable ECC engine before and after reading/writing the page. > Thanks, > Miquèl Best regards, Hui-Ping Chen