From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF14C2D0E4 for ; Tue, 24 Nov 2020 10:57:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02FEC2076B for ; Tue, 24 Nov 2020 10:57:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZnuA7S4R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ozlabs-ru.20150623.gappssmtp.com header.i=@ozlabs-ru.20150623.gappssmtp.com header.b="SSOV3AHK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02FEC2076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ozlabs.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PJnsySY4WSqrrYUqwx85UIrb47EDlXKfeNH7JXcPAh8=; b=ZnuA7S4R+8EfwFxZDcQTV5y38 v+xwNDT/+mO67M71WuBGwJMMX25Ell2JpFN7hAz/Sk5uDsOke7/KCn4aZWyc7ZTaWNjExggj07NEU y+l0/iKUii66c19i50AK9HfPnayvQ6K/r8AqoRs95BE9k88jvSOiW7U3zUWXINQXmhCZgKenCC6Bo r9UsqIfV/WSqVctNCmqkw5WD+HcDJbJjWXjBgyYJPIs4WJ2Ky24Z/ByO2e0c/dwy9y5AezbWQ0C6m ocy0/5BKmzXBjJcGTPuSF0ar50AqgRjjP3NAKHLkRwrXZk8gzRKQaejbhY26hJQHCopTUYh0acipa CFmbA3BUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khW08-0004m3-Sw; Tue, 24 Nov 2020 10:56:48 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khW05-0004ld-VB for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 10:56:47 +0000 Received: by mail-pf1-x443.google.com with SMTP id t8so18127476pfg.8 for ; Tue, 24 Nov 2020 02:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ho+OU1gWIbxlU6vkFFYhPItLBY/4CgC1Ux1l0SznRAg=; b=SSOV3AHKcYwB6+VVY1RKwf3eonAoK6VB7pgCtKHR8LD3fRuhXLehOkIUQSnbQIDI4/ p3q0lllVhyARw/nFniVJuSZDSA1nyuupwNNDJFfBpDHPMhOE1FaqJl/r4F+EjejdwGh6 JcTYJjpYmkK5vvITW2a+tZh4AjKcXiOtBFjVSdkurRhJSjv91DLg2qu+cCdrKbmCH2ek XlPQWnIeN1dG8UEFO7U6FU5ocZw0syYsyS7a7xM2lRPAMw13hOx8/vzLXyLbY8/o4EiN 9GUnx1vWcyBeLGNll61sm78qt98gQpFgpeGDJx/kqBx4w5ovOS0zJDPQfVVMkvsWOSLZ 1UcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ho+OU1gWIbxlU6vkFFYhPItLBY/4CgC1Ux1l0SznRAg=; b=LVHXFi8wKpmgP/ap8HvAHcQAi7aXcFzbFqf4/gGQCVtsJG7cyXp3I1ZYu1VYHjMjpT OwjJGAWWCxW9vHyKsplL/raBX4i3RZKtaGioWd5hAqbLUq3uv/JI3kWUz5gBhpZNgkGD oUJRk08Srvm7PXqhbcVvTuSVe//trlpRbR5u5ojie43ZeqPJmWhhCClwwvM0ldzZCx/6 fmK1mv1xvpwHLRhioRVTR9sRbIO4ANiMGs7FTCMW3c55nG1UOTrGZUrt84oXBhxU6xS8 1o6M0IQMULVkDi5DKIk+AX7YfL5B9Pce/rkmY1l3cAc1QWkYCNloyrEo+qI34jGEfzOo w8HQ== X-Gm-Message-State: AOAM530u1INePliSz9R2tW17NnK1zzA2/wqey6dBhwydxnVEdD0317Uu bMyB1b+G98hpGy0ge547rn++oQ== X-Google-Smtp-Source: ABdhPJx7aupXyGjbsXOlPp/GgIVXYWhXASJLws7GvUy6w0exJM/+0lrVY6h+M0ix3HjuU4jTiROcvg== X-Received: by 2002:a17:90b:4398:: with SMTP id in24mr4069757pjb.188.1606215404113; Tue, 24 Nov 2020 02:56:44 -0800 (PST) Received: from [0.0.0.0] (124-171-134-245.dyn.iinet.net.au. [124.171.134.245]) by smtp.gmail.com with UTF8SMTPSA id j10sm1087588pji.29.2020.11.24.02.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 02:56:43 -0800 (PST) Subject: Re: [PATCH kernel v4 2/8] genirq/irqdomain: Clean legacy IRQ allocation To: Andy Shevchenko References: <20201124061720.86766-1-aik@ozlabs.ru> <20201124061720.86766-3-aik@ozlabs.ru> From: Alexey Kardashevskiy Message-ID: <38b803db-2d67-dfa0-7e7b-e4ce816576ad@ozlabs.ru> Date: Tue, 24 Nov 2020 21:56:36 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_055646_153004_6B65A04E X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Oliver O'Halloran , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Frederic Barrat , Thomas Gleixner , =?UTF-8?Q?Michal_Such=c3=a1nek?= , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , linux-arm Mailing List Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/24/20 8:19 PM, Andy Shevchenko wrote: > On Tue, Nov 24, 2020 at 8:20 AM Alexey Kardashevskiy wrote: >> >> There are 10 users of __irq_domain_alloc_irqs() and only one - IOAPIC - >> passes realloc==true. There is no obvious reason for handling this >> specific case in the generic code. >> >> This splits out __irq_domain_alloc_irqs_data() to make it clear what >> IOAPIC does and makes __irq_domain_alloc_irqs() cleaner. >> >> This should cause no behavioral change. > >> + ret = __irq_domain_alloc_irqs_data(domain, virq, nr_irqs, node, arg, affinity); >> + if (ret <= 0) >> goto out_free_desc; > > Was or wasn't 0 considered as error code previously? Oh. I need to clean this up, the idea is since this does not allocate IRQs, this should return error code and not an irq, I'll make this explicit. > >> return virq; > >> out_free_desc: >> irq_free_descs(virq, nr_irqs); >> return ret; > -- Alexey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel