linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gary Yang <gary.yang@cixtech.com>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: 回复: [PATCH 2/3] Reset: cix: add support for cix sky1 resets
Date: Mon, 10 Nov 2025 12:22:10 +0100	[thread overview]
Message-ID: <38e8e068-d06b-41f0-9cae-5dfdf0fcce6f@kernel.org> (raw)
In-Reply-To: <PUZPR06MB58875805D441AF3213189979EFCEA@PUZPR06MB5887.apcprd06.prod.outlook.com>

On 10/11/2025 12:18, Gary Yang wrote:
>>
>>> +static struct platform_driver sky1_reset_driver = {
>>> +     .probe  = sky1_reset_probe,
>>> +     .driver = {
>>> +             .name           = KBUILD_MODNAME,
>>> +             .of_match_table = sky1_reset_dt_ids,
>>> +     },
>>> +};
>>> +static int __init reset_sky1_init(void) {
>>> +     return platform_driver_register(&sky1_reset_driver);
>>> +}
>>> +subsys_initcall(reset_sky1_init);
>>
>> This should be rather just module_platform_driver. Does not look like part of
>> subsystem, but looks like regular driver.
>>
> 
> Some modules depend reset module. When boot system, these modules can't probe before register reset.

Which modules? You statement is so imprecise that my only answer is:
sorry, deferred probe is old thing now and everyone should use it.

> To make these modules probe earlier, we use subsys_initcall() to instead of module_platform_driver(). Do you
> have better suggestions?

Look how deferred probe works.

Best regards,
Krzysztof


  reply	other threads:[~2025-11-10 11:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  3:38 [PATCH 0/3] Add support for Cix Sky1 resets Gary Yang
2025-11-07  3:38 ` [PATCH 1/3] dt-bindings: reset: add sky1 reset controller Gary Yang
2025-11-07  7:17   ` Krzysztof Kozlowski
2025-11-10  5:56     ` 回复: " Gary Yang
2025-11-07 13:25   ` Philipp Zabel
2025-11-10  6:43     ` 回复: " Gary Yang
2025-11-07  3:38 ` [PATCH 2/3] Reset: cix: add support for cix sky1 resets Gary Yang
2025-11-07  7:19   ` Krzysztof Kozlowski
2025-11-10 11:18     ` 回复: " Gary Yang
2025-11-10 11:22       ` Krzysztof Kozlowski [this message]
2025-11-10 11:32         ` 回复: " Gary Yang
2025-11-10 11:38           ` Krzysztof Kozlowski
2025-11-10 12:11             ` 回复: " Gary Yang
2025-11-07 13:25   ` Philipp Zabel
2025-11-07  3:38 ` [PATCH 3/3] dts: reset: " Gary Yang
2025-11-07  7:19   ` Krzysztof Kozlowski
2025-11-10 11:22     ` 回复: " Gary Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38e8e068-d06b-41f0-9cae-5dfdf0fcce6f@kernel.org \
    --to=krzk@kernel.org \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gary.yang@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).