From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9881C2B9F7 for ; Tue, 25 May 2021 03:41:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA61661402 for ; Tue, 25 May 2021 03:41:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA61661402 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vWojb1ss6efQz1LpCE7yOBdXd/u1quSmv0/rvLgeiRU=; b=N5kBxT7+2VS+2qzHNVBgRB5Gf8 DlUAvXZKjyXNeUqBLTkcPSF04dSu3D/Q0OKQv+kV7lV3SbvaXTnP4Hhg05ADXTIhXQ78aNY/Slyqr yaZJp5D25CoQ09JyOiVq15w7g9wz6HHSTgADTdx2A8QiKk4J4YHV6xcVQKpQl8esZFJg8SVAidyE5 lwyQEPpDPaZPPRfwrS47Q1pTgXy2OmuCdbFPkKgpRB/NABNaNVqC6CHZmzN7aKqZuKGnvy8o+W9Ns lA30awfsPEQ7xA5mla7X6mGU+SQCWn183Yxfv7w6coTFeS2jF1TPkSPdCRYp5kCL5xuxvglc4J5Ks 2gaeCg9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llNuU-003AjH-7z; Tue, 25 May 2021 03:39:17 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llMZg-002sE7-FV for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 02:13:42 +0000 Received: by mail-pg1-x536.google.com with SMTP id j12so21504743pgh.7 for ; Mon, 24 May 2021 19:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eTe+TnZWka47XzdYxR4Tb+kvwPnKlvl1m7carpA23+0=; b=vQ93Zkm21b8ODlREXEuF2D82fumsqTWTEkCq1ZrHm2kLdMrNJxLbCwGVg67Tmt1DKD hcWEb78lcoBscnRM+3+HbVa2pUOWjannqZWfboa7izS5ul12BxbD/LA4CF4iz46k+clT PDidvl236m4pNVxmGWpPFw9MoR/ViQVfSy7snua6iX/QPKhYGKWdTbzgYSlO/h94zqd7 /tY2ZaxLJQYyFWy6NHqIJemUA+cHUTk8f5MsoZEbXQuuMptiXg7ID13UtFiCpHIgBnIA Am2ffYqotcJNje3pKP860jOTbbzmaO91egzwlbydHapOoRAqG8IOaVe6DLLpwstAK1IF ER4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eTe+TnZWka47XzdYxR4Tb+kvwPnKlvl1m7carpA23+0=; b=Bq3wSjmi0Wn9qihbSd1GjiKPx8fTdVADa7dw5WYZTqw9njblVq4WZhAqD+gihyE1X9 EsbmBw6cja9ZuGRhgNv7FFIop7z9PtBaS3Xa9SLrtrKaHcyWoQt0B9NmzYonnYCEJUOF uOaLOiPcEeBW/Xb/2/R7pNpUdShfrmVSkIWfShsSaYU1cI1WIYji//1tZkRo7ydX5Iw6 0KdSoHOeV1R64/c2qtVGN7Fo5SfhoRYzUiQYoX0sWBzzHbhBNOfHfU5cBbSXYN4j0hDf b3ptHr5sbFl4N/pfGGFdHxD3U7iUqJ81KN882f5lUCLLrmxzB6kxLinsAF+ivPo7qlUf W0Ew== X-Gm-Message-State: AOAM530jq3r9XH9/bhB7QjX9ClMbkVSuy1Tbziy5UTggLisfOcTOH4Sa me/GsgilVSbhwWHXS+qbHGo= X-Google-Smtp-Source: ABdhPJybAMHkQ4/DFc8FbBn/wDHTRPUFlKBtA8RA12mPH+X4Vt0d1iJUVa1m/hjFV2nCADyJdQDTmA== X-Received: by 2002:a63:521a:: with SMTP id g26mr16763354pgb.279.1621908819022; Mon, 24 May 2021 19:13:39 -0700 (PDT) Received: from [192.168.1.67] (99-44-17-11.lightspeed.irvnca.sbcglobal.net. [99.44.17.11]) by smtp.gmail.com with ESMTPSA id r4sm4794825pff.197.2021.05.24.19.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 19:13:38 -0700 (PDT) Subject: Re: [PATCH 3/4] firmware: arm_scmi: Introduce monotonically increasing tokens To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com References: <20210524231503.34924-1-cristian.marussi@arm.com> <20210524231503.34924-4-cristian.marussi@arm.com> From: Florian Fainelli Message-ID: <38fb1a44-3ed4-3a8f-0716-e91159b72a9b@gmail.com> Date: Mon, 24 May 2021 19:13:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210524231503.34924-4-cristian.marussi@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_191340_569336_638EA11A X-CRM114-Status: GOOD ( 27.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/24/2021 4:15 PM, Cristian Marussi wrote: > Tokens are sequence numbers embedded in the each SCMI message header: they > are used to correlate commands with responses (and delayed responses), but > their usage and policy of selection is entirely up to the caller (usually > the OSPM agent), while they are completely opaque to the callee (SCMI > server platform) which merely copies them back from the command into the > response message header. > This also means that the platform does not, can not and should not enforce > any kind of policy on received messages depending on the contained sequence > number: platform can perfectly handle concurrent requests carrying the same > identifiying token if that should happen. > > Moreover the platform is not required to produce in-order responses to > agent requests, the only constraint in these regards is that in case of > an asynchronous message the delayed response must be sent after the > immediate response for the synchronous part of the command transaction. > > Currenly the SCMI stack of the OSPM agent selects as token for the s/as token/a token/? > egressing commands the lowest possible number which is not already in use > by an existing in-flight transaction, which means, in other words, that > we immediately reuse any token after its transaction has completed or it > has timed out: this indeed simplifies token and associated xfer management > and lookup. > > Under the above assumptions and constraints, since there is really no state > shared between the agent and the platform to let the platform know when a > token and its associated message has timed out, the current policy of early > reuse of tokens can easily lead to the situation in which a spurios or late s/spurios/spurious/ > received response (or delayed_response), related to an old stale and timed > out transaction, can be wrongly associated to a newer valid in-flight xfer > that just happens to have reused the same token. > > This misbehavior on such ghost responses is more easily exposed on those > transports that naturally have an higher level of parallelism in processing > multiple concurrent in-flight messages. > > This commit introduces a new policy of selection of tokens for the OSPM > agent: each new transfer now gets the next available and monotonically > increasing token, until tokens are exhausted and the counter rolls over. > > Such new policy mitigates the above issues with ghost responses since the > tokens are now reused as later as possible (when they roll back ideally) > and so it is much easier to identify ghost responses to stale timed out > transactions: this also helps in simplifying the specific transports > implementation since stale transport messages can be easily identified > and discarded early on in the rx path without the need to cross check > their actual sate with the core transport layer. > This mitigation is even more effective when, as is usual the case, the s/usual/usually/ > maximum number of pending messages is capped by the platform to a much > lower value than whole possible range of tokens.(2^10) > > This internal policy change in the core SCMI transport layer is fully > transparent to the specific transports so it has not and should not have > any impact on the transports implementation. > > The empirically observed cost of such new procedure of token selection > amounts in the best case to ~10us out of an observed full transaction cost > of 3ms for the completion of a synchronous sensor reading command on a > platform supporting commmands completion interrupts. s/commmands/commands/ > > Signed-off-by: Cristian Marussi Overall this looks good to me and is more straightforward than I thought. [snip] > +/** > + * scmi_xfer_token_set - Reserve and set new token for the xfer at hand > + * > + * @minfo: Pointer to Tx/Rx Message management info based on channel type > + * @xfer: The xfer to act upon > + * > + * Pick the next unused monotonically increasing token and set it into > + * xfer->hdr.seq: picking a monotonically increasing value avoids reusing > + * immediately tokens of just completed or timed-out xfers, mitigating the risk > + * of wrongly associating a late received answer for an expired xfer to a live > + * in-flight transaction which happened to have reused the same token. This was a bit harder to read than I thought, how about: picking a monotonically increasing value avoids immediate reuse of freshly completed or timed-out xfers, thus mitigating the risk of incorrect association of a late and expired xfer with a live in-flight transaction, both happening to re-use the same token identifier. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel