* [PATCH 0/4] arm64: dts: imx952-evk: Add audio sound cards
@ 2026-03-12 3:49 Shengjiu Wang
2026-03-12 3:49 ` [PATCH 1/4] arm64: dts: imx952: Add audio device nodes Shengjiu Wang
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 3:49 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Add audio device nodes and sound card (wm8962, PDM microphone, bt-sco).
Shengjiu Wang (4):
arm64: dts: imx952: Add audio device nodes
arm64: dts: imx952-evk: Add sound-wm8962 support
arm64: dts: imx952-evk: Add bt-sco sound card support
arm64: dts: imx952-evk: Add PDM microphone sound card support
arch/arm64/boot/dts/freescale/imx952-evk.dts | 232 +++++++++++++++++++
arch/arm64/boot/dts/freescale/imx952.dtsi | 199 ++++++++++++++++
2 files changed, 431 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] arm64: dts: imx952: Add audio device nodes
2026-03-12 3:49 [PATCH 0/4] arm64: dts: imx952-evk: Add audio sound cards Shengjiu Wang
@ 2026-03-12 3:49 ` Shengjiu Wang
2026-03-12 6:40 ` Daniel Baluta
2026-03-12 3:49 ` [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support Shengjiu Wang
` (2 subsequent siblings)
3 siblings, 1 reply; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 3:49 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Add audio device nodes, include SAI, MICFIL, ASRC, Audio Mixer.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx952.dtsi | 199 ++++++++++++++++++++++
1 file changed, 199 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx952.dtsi b/arch/arm64/boot/dts/freescale/imx952.dtsi
index 0f86b5626cdd..5787c12e788f 100644
--- a/arch/arm64/boot/dts/freescale/imx952.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx952.dtsi
@@ -823,6 +823,156 @@ usdhc3: mmc@42c40000 {
};
};
+ aips5: bus@43000000 {
+ compatible = "fsl,aips-bus", "simple-bus";
+ reg = <0 0x43000000 0 0x800000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x43000000 0x0 0x43000000 0x800000>;
+
+ asrc1: asrc@43000000 {
+ compatible = "fsl,imx952-asrc";
+ reg = <0x43000000 0x10000>;
+ interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>,
+ <&scmi_clk IMX952_CLK_BUSWAKEUP>,
+ <&scmi_clk IMX952_CLK_ASRC1>,
+ <&scmi_clk IMX952_CLK_ASRC2>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "mem", "ipg",
+ "asrck_0", "asrck_1", "asrck_2", "asrck_3",
+ "asrck_4", "asrck_5", "asrck_6", "asrck_7",
+ "asrck_8", "asrck_9", "asrck_a", "asrck_b",
+ "asrck_c", "asrck_d", "asrck_e", "asrck_f",
+ "spba";
+ dmas = <&edma2 97 0 0>, <&edma2 98 0 0>, <&edma2 99 0 0>,
+ <&edma2 100 0 1>, <&edma2 101 0 1>, <&edma2 102 0 1>;
+ dma-names = "rxa", "rxb", "rxc",
+ "txa", "txb", "txc";
+ #sound-dai-cells = <0>;
+ fsl,asrc-rate = <8000>;
+ fsl,asrc-width = <16>;
+ status = "disabled";
+ };
+
+ asrc2: asrc@430f0000 {
+ compatible = "fsl,imx952-asrc";
+ reg = <0x430f0000 0x10000>;
+ interrupts = <GIC_SPI 384 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>,
+ <&scmi_clk IMX952_CLK_BUSWAKEUP>,
+ <&scmi_clk IMX952_CLK_ASRC1>,
+ <&scmi_clk IMX952_CLK_ASRC2>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "mem", "ipg",
+ "asrck_0", "asrck_1", "asrck_2", "asrck_3",
+ "asrck_4", "asrck_5", "asrck_6", "asrck_7",
+ "asrck_8", "asrck_9", "asrck_a", "asrck_b",
+ "asrck_c", "asrck_d", "asrck_e", "asrck_f",
+ "spba";
+ dmas = <&edma2 103 0 0>, <&edma2 104 0 0>, <&edma2 105 0 0>,
+ <&edma2 106 0 1>, <&edma2 107 0 1>, <&edma2 108 0 1>;
+ dma-names = "rxa", "rxb", "rxc",
+ "txa", "txb", "txc";
+ #sound-dai-cells = <0>;
+ fsl,asrc-rate = <8000>;
+ fsl,asrc-width = <16>;
+ status = "disabled";
+ };
+
+ amix: amix@431f0000 {
+ compatible = "fsl,imx952-audmix";
+ reg = <0x431f0000 0x10000>;
+ clocks = <&scmi_clk IMX952_CLK_AUDMIX1>;
+ clock-names = "ipg";
+ status = "disabled";
+ };
+
+ sai3: sai@433e0000 {
+ compatible = "fsl,imx952-sai", "fsl,imx95-sai";
+ reg = <0x433e0000 0x10000>;
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>, <&clk_dummy>,
+ <&scmi_clk IMX952_CLK_SAI3>, <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma2 61 0 FSL_EDMA_RX>, <&edma2 60 0 0>;
+ dma-names = "rx", "tx";
+ #sound-dai-cells = <0>;
+ status = "disabled";
+ };
+
+ sai4: sai@433f0000 {
+ compatible = "fsl,imx952-sai", "fsl,imx95-sai";
+ reg = <0x433f0000 0x10000>;
+ interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>, <&clk_dummy>,
+ <&scmi_clk IMX952_CLK_SAI4>, <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma2 68 0 FSL_EDMA_RX>, <&edma2 67 0 0>;
+ dma-names = "rx", "tx";
+ #sound-dai-cells = <0>;
+ status = "disabled";
+ };
+
+ sai5: sai@43400000 {
+ compatible = "fsl,imx952-sai", "fsl,imx95-sai";
+ reg = <0x43400000 0x10000>;
+ interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>, <&clk_dummy>,
+ <&scmi_clk IMX952_CLK_SAI5>, <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma2 70 0 FSL_EDMA_RX>, <&edma2 69 0 0>;
+ dma-names = "rx", "tx";
+ #sound-dai-cells = <0>;
+ status = "disabled";
+ };
+
+ sai6: sai@43410000 {
+ compatible = "fsl,imx952-sai", "fsl,imx95-sai";
+ reg = <0x43410000 0x10000>;
+ interrupts = <GIC_SPI 399 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>, <&clk_dummy>,
+ <&scmi_clk IMX952_CLK_SAI3>, <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma2 96 0 FSL_EDMA_RX>, <&edma2 95 0 0>;
+ dma-names = "rx", "tx";
+ #sound-dai-cells = <0>;
+ status = "disabled";
+ };
+ };
+
gpio2: gpio@43810000 {
compatible = "fsl,imx95-gpio", "fsl,imx8ulp-gpio";
reg = <0x0 0x43810000 0x0 0x1000>;
@@ -1062,6 +1212,40 @@ flexcan1: can@443a0000 {
status = "disabled";
};
+ sai1: sai@443b0000 {
+ compatible = "fsl,imx952-sai", "fsl,imx95-sai";
+ reg = <0x443b0000 0x10000>;
+ interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSAON>, <&clk_dummy>,
+ <&scmi_clk IMX952_CLK_SAI1>, <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma1 25 0 FSL_EDMA_RX>, <&edma1 24 0 0>;
+ dma-names = "rx", "tx";
+ #sound-dai-cells = <0>;
+ status = "disabled";
+ };
+
+ micfil: micfil@44520000 {
+ compatible = "fsl,imx943-micfil";
+ reg = <0x44520000 0x10000>;
+ interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSAON>,
+ <&scmi_clk IMX952_CLK_PDM>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2>,
+ <&clk_dummy>;
+ clock-names = "ipg_clk", "ipg_clk_app",
+ "pll8k", "pll11k", "clkext3";
+ dmas = <&edma1 6 0 5>;
+ dma-names = "rx";
+ #sound-dai-cells = <0>;
+ status = "disabled";
+ };
+
adc1: adc@44530000 {
compatible = "nxp,imx93-adc";
reg = <0x44530000 0x10000>;
@@ -1281,5 +1465,20 @@ usbmisc2: usbmisc@4c200200 {
reg = <0x0 0x4c200200 0x0 0x200>,
<0x0 0x4c010014 0x0 0x4>;
};
+
+ sai2: sai@4c880000 {
+ compatible = "fsl,imx952-sai", "fsl,imx95-sai";
+ reg = <0x0 0x4c880000 0x0 0x10000>;
+ interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&scmi_clk IMX952_CLK_BUSNETCMIX>, <&clk_dummy>,
+ <&scmi_clk IMX952_CLK_SAI2>, <&clk_dummy>,
+ <&clk_dummy>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma2 59 0 FSL_EDMA_RX>, <&edma2 58 0 0>;
+ dma-names = "rx", "tx";
+ #sound-dai-cells = <0>;
+ power-domains = <&scmi_devpd IMX952_PD_NETC>;
+ status = "disabled";
+ };
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support
2026-03-12 3:49 [PATCH 0/4] arm64: dts: imx952-evk: Add audio sound cards Shengjiu Wang
2026-03-12 3:49 ` [PATCH 1/4] arm64: dts: imx952: Add audio device nodes Shengjiu Wang
@ 2026-03-12 3:49 ` Shengjiu Wang
2026-03-12 6:51 ` Daniel Baluta
2026-03-12 9:43 ` Alexander Stein
2026-03-12 3:49 ` [PATCH 3/4] arm64: dts: imx952-evk: Add bt-sco sound card support Shengjiu Wang
2026-03-12 3:49 ` [PATCH 4/4] arm64: dts: imx952-evk: Add PDM microphone " Shengjiu Wang
3 siblings, 2 replies; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 3:49 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Add wm8962 sound card. By connecting with ASRC1, the sound card support
sample rate conversion.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx952-evk.dts | 119 +++++++++++++++++++
1 file changed, 119 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
index 509704c23e89..ef0058b98573 100644
--- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
@@ -110,6 +110,15 @@ reg_vref_1v8: regulator-adc-vref {
regulator-max-microvolt = <1800000>;
};
+ reg_audio_pwr: regulator-audio-pwr {
+ compatible = "regulator-fixed";
+ regulator-name = "audio-pwr";
+ regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <3300000>;
+ gpio = <&i2c4_pcal6408 1 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
reg_usdhc2_vmmc: regulator-usdhc2 {
compatible = "regulator-fixed";
pinctrl-names = "default";
@@ -131,6 +140,51 @@ reg_usb_vbus: regulator-vbus {
enable-active-high;
};
+ sound-wm8962 {
+ compatible = "fsl,imx-audio-wm8962";
+ audio-asrc = <&asrc1>;
+ audio-codec = <&wm8962>;
+ audio-cpu = <&sai3>;
+ audio-routing = "Headphone Jack", "HPOUTL",
+ "Headphone Jack", "HPOUTR",
+ "Ext Spk", "SPKOUTL",
+ "Ext Spk", "SPKOUTR",
+ "AMIC", "MICBIAS",
+ "IN3R", "AMIC",
+ "IN1R", "AMIC";
+ hp-det-gpio = <&gpio2 11 GPIO_ACTIVE_HIGH>;
+ model = "wm8962-audio";
+ pinctrl-0 = <&pinctrl_hp>;
+ pinctrl-names = "default";
+ };
+};
+
+&asrc1 {
+ assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2>,
+ <&scmi_clk IMX952_CLK_ASRC1>;
+ assigned-clock-parents = <0>, <0>, <0>, <0>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>;
+ assigned-clock-rates = <3932160000>, <3612672000>,
+ <393216000>, <361267200>, <49152000>;
+ fsl,asrc-rate = <48000>;
+ status = "okay";
+};
+
+&asrc2 {
+ assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2>,
+ <&scmi_clk IMX952_CLK_ASRC2>;
+ assigned-clock-parents = <0>, <0>, <0>, <0>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>;
+ assigned-clock-rates = <3932160000>, <3612672000>,
+ <393216000>, <361267200>, <49152000>;
+ fsl,asrc-rate = <48000>;
+ status = "okay";
};
/* pin conflict with PDM */
@@ -185,6 +239,27 @@ &lpi2c4 {
pinctrl-0 = <&pinctrl_lpi2c4>;
status = "okay";
+ wm8962: audio-codec@1a {
+ compatible = "wlf,wm8962";
+ reg = <0x1a>;
+ clocks = <&scmi_clk IMX952_CLK_SAI3>;
+ AVDD-supply = <®_audio_pwr>;
+ CPVDD-supply = <®_audio_pwr>;
+ DBVDD-supply = <®_audio_pwr>;
+ DCVDD-supply = <®_audio_pwr>;
+ gpio-cfg = < 0x0000 /* 0:Default */
+ 0x0000 /* 1:Default */
+ 0x0000 /* 2:FN_DMICCLK */
+ 0x0000 /* 3:Default */
+ 0x0000 /* 4:FN_DMICCDAT */
+ 0x0000 /* 5:Default */
+ >;
+ MICVDD-supply = <®_audio_pwr>;
+ PLLVDD-supply = <®_audio_pwr>;
+ SPKVDD1-supply = <®_audio_pwr>;
+ SPKVDD2-supply = <®_audio_pwr>;
+ };
+
i2c4_pcal6408: gpio@21 {
compatible = "nxp,pcal6408";
reg = <0x21>;
@@ -312,6 +387,24 @@ &lpspi7 {
status = "okay";
};
+&sai3 {
+ assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2>,
+ <&scmi_clk IMX952_CLK_SAI3>;
+ assigned-clock-parents = <0>, <0>, <0>, <0>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>;
+ assigned-clock-rates = <3932160000>, <3612672000>,
+ <393216000>, <361267200>, <12288000>;
+ pinctrl-0 = <&pinctrl_sai3>;
+ pinctrl-1 = <&pinctrl_sai3_sleep>;
+ pinctrl-names = "default", "sleep";
+ fsl,sai-amix-mode = "bypass";
+ fsl,sai-mclk-direction-output;
+ status = "okay";
+};
+
&scmi_misc {
nxp,ctrl-ids = <BRD_SM_CTRL_SD3_WAKE 1
BRD_SM_CTRL_M2E_WAKE 1
@@ -402,6 +495,12 @@ IMX952_PAD_GPIO_IO27__WAKEUPMIX_TOP_CAN2_RX 0x39e
>;
};
+ pinctrl_hp: hpgrp {
+ fsl,pins = <
+ IMX952_PAD_GPIO_IO11__WAKEUPMIX_TOP_GPIO2_IO_11 0x31e
+ >;
+ };
+
pinctrl_lpi2c2: lpi2c2grp {
fsl,pins = <
IMX952_PAD_I2C2_SCL__AONMIX_TOP_LPI2C2_SCL 0x40000b9e
@@ -476,6 +575,26 @@ IMX952_PAD_SD2_RESET_B__WAKEUPMIX_TOP_GPIO3_IO_7 0x31e
>;
};
+ pinctrl_sai3: sai3grp {
+ fsl,pins = <
+ IMX952_PAD_GPIO_IO17__WAKEUPMIX_TOP_SAI3_MCLK 0x31e
+ IMX952_PAD_GPIO_IO16__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXBCLK 0x31e
+ IMX952_PAD_GPIO_IO26__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXSYNC 0x31e
+ IMX952_PAD_GPIO_IO20__WAKEUPMIX_TOP_SAI3_RX_DATA_0 0x31e
+ IMX952_PAD_GPIO_IO21__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXDATA 0x31e
+ >;
+ };
+
+ pinctrl_sai3_sleep: sai3sleepgrp {
+ fsl,pins = <
+ IMX952_PAD_GPIO_IO17__WAKEUPMIX_TOP_GPIO2_IO_17 0x31e
+ IMX952_PAD_GPIO_IO16__WAKEUPMIX_TOP_GPIO2_IO_16 0x31e
+ IMX952_PAD_GPIO_IO26__WAKEUPMIX_TOP_GPIO2_IO_26 0x31e
+ IMX952_PAD_GPIO_IO20__WAKEUPMIX_TOP_GPIO2_IO_20 0x31e
+ IMX952_PAD_GPIO_IO21__WAKEUPMIX_TOP_GPIO2_IO_21 0x31e
+ >;
+ };
+
pinctrl_tpm3: tpm3grp {
fsl,pins = <
IMX952_PAD_GPIO_IO12__WAKEUPMIX_TOP_TPM3_CH2 0x51e
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/4] arm64: dts: imx952-evk: Add bt-sco sound card support
2026-03-12 3:49 [PATCH 0/4] arm64: dts: imx952-evk: Add audio sound cards Shengjiu Wang
2026-03-12 3:49 ` [PATCH 1/4] arm64: dts: imx952: Add audio device nodes Shengjiu Wang
2026-03-12 3:49 ` [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support Shengjiu Wang
@ 2026-03-12 3:49 ` Shengjiu Wang
2026-03-12 6:50 ` Daniel Baluta
2026-03-12 3:49 ` [PATCH 4/4] arm64: dts: imx952-evk: Add PDM microphone " Shengjiu Wang
3 siblings, 1 reply; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 3:49 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Add bt-sco sound card, which is used by BT HFP case.
It supports wb profile as default.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx952-evk.dts | 59 ++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
index ef0058b98573..2615fbb63145 100644
--- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
@@ -43,6 +43,11 @@ aliases {
spi6 = &lpspi7;
};
+ bt_sco_codec: audio-codec-bt-sco {
+ #sound-dai-cells = <1>;
+ compatible = "linux,bt-sco";
+ };
+
chosen {
stdout-path = &lpuart1;
};
@@ -140,6 +145,25 @@ reg_usb_vbus: regulator-vbus {
enable-active-high;
};
+ sound-bt-sco {
+ compatible = "simple-audio-card";
+ simple-audio-card,bitclock-inversion;
+ simple-audio-card,bitclock-master = <&btcpu>;
+ simple-audio-card,format = "dsp_a";
+ simple-audio-card,frame-master = <&btcpu>;
+ simple-audio-card,name = "bt-sco-audio";
+
+ simple-audio-card,codec {
+ sound-dai = <&bt_sco_codec 1>;
+ };
+
+ btcpu: simple-audio-card,cpu {
+ dai-tdm-slot-num = <2>;
+ dai-tdm-slot-width = <16>;
+ sound-dai = <&sai1>;
+ };
+ };
+
sound-wm8962 {
compatible = "fsl,imx-audio-wm8962";
audio-asrc = <&asrc1>;
@@ -387,6 +411,23 @@ &lpspi7 {
status = "okay";
};
+&sai1 {
+ assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2>,
+ <&scmi_clk IMX952_CLK_SAI1>;
+ assigned-clock-parents = <0>, <0>, <0>, <0>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>;
+ assigned-clock-rates = <3932160000>, <3612672000>,
+ <393216000>, <361267200>, <12288000>;
+ pinctrl-0 = <&pinctrl_sai1>;
+ pinctrl-1 = <&pinctrl_sai1_sleep>;
+ pinctrl-names = "default", "sleep";
+ fsl,sai-mclk-direction-output;
+ status = "okay";
+};
+
&sai3 {
assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
<&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
@@ -575,6 +616,24 @@ IMX952_PAD_SD2_RESET_B__WAKEUPMIX_TOP_GPIO3_IO_7 0x31e
>;
};
+ pinctrl_sai1: sai1grp {
+ fsl,pins = <
+ IMX952_PAD_SAI1_RXD0__AONMIX_TOP_SAI1_RX_DATA_0 0x31e
+ IMX952_PAD_SAI1_TXC__AONMIX_TOP_SAI1_TX_BCLK 0x31e
+ IMX952_PAD_SAI1_TXFS__AONMIX_TOP_SAI1_TX_SYNC 0x31e
+ IMX952_PAD_SAI1_TXD0__AONMIX_TOP_SAI1_TX_DATA_0 0x31e
+ >;
+ };
+
+ pinctrl_sai1_sleep: sai1sleepgrp {
+ fsl,pins = <
+ IMX952_PAD_SAI1_RXD0__AONMIX_TOP_GPIO1_IO_14 0x51e
+ IMX952_PAD_SAI1_TXC__AONMIX_TOP_GPIO1_IO_12 0x51e
+ IMX952_PAD_SAI1_TXFS__AONMIX_TOP_GPIO1_IO_11 0x51e
+ IMX952_PAD_SAI1_TXD0__AONMIX_TOP_GPIO1_IO_13 0x51e
+ >;
+ };
+
pinctrl_sai3: sai3grp {
fsl,pins = <
IMX952_PAD_GPIO_IO17__WAKEUPMIX_TOP_SAI3_MCLK 0x31e
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/4] arm64: dts: imx952-evk: Add PDM microphone sound card support
2026-03-12 3:49 [PATCH 0/4] arm64: dts: imx952-evk: Add audio sound cards Shengjiu Wang
` (2 preceding siblings ...)
2026-03-12 3:49 ` [PATCH 3/4] arm64: dts: imx952-evk: Add bt-sco sound card support Shengjiu Wang
@ 2026-03-12 3:49 ` Shengjiu Wang
2026-03-12 6:49 ` Daniel Baluta
3 siblings, 1 reply; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 3:49 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Add PDM micphone sound card support, configure the pinmux.
This sound card supports recording sound from PDM microphone
and convert the PDM format data to PCM data.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx952-evk.dts | 54 ++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
index 2615fbb63145..62d1c1c7c501 100644
--- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
@@ -52,6 +52,12 @@ chosen {
stdout-path = &lpuart1;
};
+ dmic: dmic {
+ compatible = "dmic-codec";
+ #sound-dai-cells = <0>;
+ num-channels = <2>;
+ };
+
memory@80000000 {
device_type = "memory";
reg = <0x0 0x80000000 0 0x80000000>;
@@ -164,6 +170,24 @@ btcpu: simple-audio-card,cpu {
};
};
+ sound-micfil {
+ compatible = "fsl,imx-audio-card";
+ model = "micfil-audio";
+
+ pri-dai-link {
+ format = "i2s";
+ link-name = "micfil hifi";
+
+ codec {
+ sound-dai = <&dmic>;
+ };
+
+ cpu {
+ sound-dai = <&micfil>;
+ };
+ };
+ };
+
sound-wm8962 {
compatible = "fsl,imx-audio-wm8962";
audio-asrc = <&asrc1>;
@@ -411,6 +435,22 @@ &lpspi7 {
status = "okay";
};
+&micfil {
+ assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL2>,
+ <&scmi_clk IMX952_CLK_PDM>;
+ assigned-clock-parents = <0>, <0>, <0>, <0>,
+ <&scmi_clk IMX952_CLK_AUDIOPLL1>;
+ assigned-clock-rates = <3932160000>, <3612672000>,
+ <393216000>, <361267200>, <49152000>;
+ pinctrl-0 = <&pinctrl_pdm>;
+ pinctrl-1 = <&pinctrl_pdm_sleep>;
+ pinctrl-names = "default", "sleep";
+ status = "okay";
+};
+
&sai1 {
assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
<&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
@@ -604,6 +644,20 @@ IMX952_PAD_GPIO_IO36__WAKEUPMIX_TOP_GPIO5_IO_16 0x31e
>;
};
+ pinctrl_pdm: pdmgrp {
+ fsl,pins = <
+ IMX952_PAD_PDM_CLK__AONMIX_TOP_PDM_CLK 0x31e
+ IMX952_PAD_PDM_BIT_STREAM0__AONMIX_TOP_PDM_BIT_STREAM_0 0x31e
+ >;
+ };
+
+ pinctrl_pdm_sleep: pdmsleepgrp {
+ fsl,pins = <
+ IMX952_PAD_PDM_CLK__AONMIX_TOP_GPIO1_IO_8 0x31e
+ IMX952_PAD_PDM_BIT_STREAM0__AONMIX_TOP_GPIO1_IO_9 0x31e
+ >;
+ };
+
pinctrl_ptn5110: ptn5110grp {
fsl,pins = <
IMX952_PAD_GPIO_IO34__WAKEUPMIX_TOP_GPIO5_IO_14 0x31e
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] arm64: dts: imx952: Add audio device nodes
2026-03-12 3:49 ` [PATCH 1/4] arm64: dts: imx952: Add audio device nodes Shengjiu Wang
@ 2026-03-12 6:40 ` Daniel Baluta
2026-03-12 6:54 ` Shengjiu Wang
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Baluta @ 2026-03-12 6:40 UTC (permalink / raw)
To: Shengjiu Wang, robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel,
festevam, devicetree, imx, linux-arm-kernel, linux-kernel
On 3/12/26 05:49, Shengjiu Wang wrote:
> Add audio device nodes, include SAI, MICFIL, ASRC, Audio Mixer.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx952.dtsi | 199 ++++++++++++++++++++++
> 1 file changed, 199 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx952.dtsi b/arch/arm64/boot/dts/freescale/imx952.dtsi
> index 0f86b5626cdd..5787c12e788f 100644
> --- a/arch/arm64/boot/dts/freescale/imx952.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx952.dtsi
> @@ -823,6 +823,156 @@ usdhc3: mmc@42c40000 {
> };
> };
>
> + aips5: bus@43000000 {
> + compatible = "fsl,aips-bus", "simple-bus";
> + reg = <0 0x43000000 0 0x800000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x43000000 0x0 0x43000000 0x800000>;
> +
> + asrc1: asrc@43000000 {
> + compatible = "fsl,imx952-asrc";
> + reg = <0x43000000 0x10000>;
> + interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>,
> + <&scmi_clk IMX952_CLK_BUSWAKEUP>,
> + <&scmi_clk IMX952_CLK_ASRC1>,
> + <&scmi_clk IMX952_CLK_ASRC2>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>;
> + clock-names = "mem", "ipg",
> + "asrck_0", "asrck_1", "asrck_2", "asrck_3",
> + "asrck_4", "asrck_5", "asrck_6", "asrck_7",
> + "asrck_8", "asrck_9", "asrck_a", "asrck_b",
> + "asrck_c", "asrck_d", "asrck_e", "asrck_f",
> + "spba";
> + dmas = <&edma2 97 0 0>, <&edma2 98 0 0>, <&edma2 99 0 0>,
> + <&edma2 100 0 1>, <&edma2 101 0 1>, <&edma2 102 0 1>;
For consistency we should use symbolic macros for directions like you did below.
Use FSL_EDMA_RX for rx direction and also introduce FSL_EDMA_TX for tx direction.
> + dma-names = "rxa", "rxb", "rxc",
> + "txa", "txb", "txc";
> + #sound-dai-cells = <0>;
> + fsl,asrc-rate = <8000>;
> + fsl,asrc-width = <16>;
> + status = "disabled";
> + };
[...]
> + sai3: sai@433e0000 {
> + compatible = "fsl,imx952-sai", "fsl,imx95-sai";
> + reg = <0x433e0000 0x10000>;
> + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>, <&clk_dummy>,
> + <&scmi_clk IMX952_CLK_SAI3>, <&clk_dummy>,
> + <&clk_dummy>;
> + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> + dmas = <&edma2 61 0 FSL_EDMA_RX>, <&edma2 60 0 0>;
As I said we should introduce FSL_EDMA_TX and this will read as:
dmas = <&edma2 61 0 FSL_EDMA_RX>, <&edma2 60 0 FSL_EDMA_TX>;
Otherwise, looks good to me.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] arm64: dts: imx952-evk: Add PDM microphone sound card support
2026-03-12 3:49 ` [PATCH 4/4] arm64: dts: imx952-evk: Add PDM microphone " Shengjiu Wang
@ 2026-03-12 6:49 ` Daniel Baluta
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Baluta @ 2026-03-12 6:49 UTC (permalink / raw)
To: Shengjiu Wang, robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel,
festevam, devicetree, imx, linux-arm-kernel, linux-kernel
On 3/12/26 05:49, Shengjiu Wang wrote:
> Add PDM micphone sound card support, configure the pinmux.
>
> This sound card supports recording sound from PDM microphone
> and convert the PDM format data to PCM data.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] arm64: dts: imx952-evk: Add bt-sco sound card support
2026-03-12 3:49 ` [PATCH 3/4] arm64: dts: imx952-evk: Add bt-sco sound card support Shengjiu Wang
@ 2026-03-12 6:50 ` Daniel Baluta
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Baluta @ 2026-03-12 6:50 UTC (permalink / raw)
To: Shengjiu Wang, robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel,
festevam, devicetree, imx, linux-arm-kernel, linux-kernel
On 3/12/26 05:49, Shengjiu Wang wrote:
> Add bt-sco sound card, which is used by BT HFP case.
> It supports wb profile as default.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support
2026-03-12 3:49 ` [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support Shengjiu Wang
@ 2026-03-12 6:51 ` Daniel Baluta
2026-03-12 9:43 ` Alexander Stein
1 sibling, 0 replies; 14+ messages in thread
From: Daniel Baluta @ 2026-03-12 6:51 UTC (permalink / raw)
To: Shengjiu Wang, robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel,
festevam, devicetree, imx, linux-arm-kernel, linux-kernel
On 3/12/26 05:49, Shengjiu Wang wrote:
> Add wm8962 sound card. By connecting with ASRC1, the sound card support
> sample rate conversion.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] arm64: dts: imx952: Add audio device nodes
2026-03-12 6:40 ` Daniel Baluta
@ 2026-03-12 6:54 ` Shengjiu Wang
2026-03-12 7:13 ` Daniel Baluta
0 siblings, 1 reply; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 6:54 UTC (permalink / raw)
To: Daniel Baluta
Cc: Shengjiu Wang, robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel,
festevam, devicetree, imx, linux-arm-kernel, linux-kernel
On Thu, Mar 12, 2026 at 2:40 PM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>
> On 3/12/26 05:49, Shengjiu Wang wrote:
> > Add audio device nodes, include SAI, MICFIL, ASRC, Audio Mixer.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx952.dtsi | 199 ++++++++++++++++++++++
> > 1 file changed, 199 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx952.dtsi b/arch/arm64/boot/dts/freescale/imx952.dtsi
> > index 0f86b5626cdd..5787c12e788f 100644
> > --- a/arch/arm64/boot/dts/freescale/imx952.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx952.dtsi
> > @@ -823,6 +823,156 @@ usdhc3: mmc@42c40000 {
> > };
> > };
> >
> > + aips5: bus@43000000 {
> > + compatible = "fsl,aips-bus", "simple-bus";
> > + reg = <0 0x43000000 0 0x800000>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x43000000 0x0 0x43000000 0x800000>;
> > +
> > + asrc1: asrc@43000000 {
> > + compatible = "fsl,imx952-asrc";
> > + reg = <0x43000000 0x10000>;
> > + interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>,
> > + <&scmi_clk IMX952_CLK_BUSWAKEUP>,
> > + <&scmi_clk IMX952_CLK_ASRC1>,
> > + <&scmi_clk IMX952_CLK_ASRC2>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>,
> > + <&clk_dummy>;
> > + clock-names = "mem", "ipg",
> > + "asrck_0", "asrck_1", "asrck_2", "asrck_3",
> > + "asrck_4", "asrck_5", "asrck_6", "asrck_7",
> > + "asrck_8", "asrck_9", "asrck_a", "asrck_b",
> > + "asrck_c", "asrck_d", "asrck_e", "asrck_f",
> > + "spba";
> > + dmas = <&edma2 97 0 0>, <&edma2 98 0 0>, <&edma2 99 0 0>,
> > + <&edma2 100 0 1>, <&edma2 101 0 1>, <&edma2 102 0 1>;
>
> For consistency we should use symbolic macros for directions like you did below.
> Use FSL_EDMA_RX for rx direction and also introduce FSL_EDMA_TX for tx direction.
Yes, should use FSL_EDMA_RX.
But introduce FSL_EDMA_TX, it should be zero, FSL_EDMA_TX = 0.
is it necessary to add it in include/dt-bindings/dma/fsl-edma.h?
Best regards
Shengjiu Wang
>
>
> > + dma-names = "rxa", "rxb", "rxc",
> > + "txa", "txb", "txc";
> > + #sound-dai-cells = <0>;
> > + fsl,asrc-rate = <8000>;
> > + fsl,asrc-width = <16>;
> > + status = "disabled";
> > + };
>
>
> [...]
>
> > + sai3: sai@433e0000 {
> > + compatible = "fsl,imx952-sai", "fsl,imx95-sai";
> > + reg = <0x433e0000 0x10000>;
> > + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>, <&clk_dummy>,
> > + <&scmi_clk IMX952_CLK_SAI3>, <&clk_dummy>,
> > + <&clk_dummy>;
> > + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> > + dmas = <&edma2 61 0 FSL_EDMA_RX>, <&edma2 60 0 0>;
> As I said we should introduce FSL_EDMA_TX and this will read as:
>
> dmas = <&edma2 61 0 FSL_EDMA_RX>, <&edma2 60 0 FSL_EDMA_TX>;
>
> Otherwise, looks good to me.
>
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] arm64: dts: imx952: Add audio device nodes
2026-03-12 6:54 ` Shengjiu Wang
@ 2026-03-12 7:13 ` Daniel Baluta
2026-03-12 9:53 ` Shengjiu Wang
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Baluta @ 2026-03-12 7:13 UTC (permalink / raw)
To: Shengjiu Wang
Cc: Shengjiu Wang, robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel,
festevam, devicetree, imx, linux-arm-kernel, linux-kernel
On 3/12/26 08:54, Shengjiu Wang wrote:
>> On 3/12/26 05:49, Shengjiu Wang wrote:
>>> Add audio device nodes, include SAI, MICFIL, ASRC, Audio Mixer.
>>>
>>> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx952.dtsi | 199 ++++++++++++++++++++++
>>> 1 file changed, 199 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx952.dtsi b/arch/arm64/boot/dts/freescale/imx952.dtsi
>>> index 0f86b5626cdd..5787c12e788f 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx952.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx952.dtsi
>>> @@ -823,6 +823,156 @@ usdhc3: mmc@42c40000 {
>>> };
>>> };
>>>
>>> + aips5: bus@43000000 {
>>> + compatible = "fsl,aips-bus", "simple-bus";
>>> + reg = <0 0x43000000 0 0x800000>;
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x43000000 0x0 0x43000000 0x800000>;
>>> +
>>> + asrc1: asrc@43000000 {
>>> + compatible = "fsl,imx952-asrc";
>>> + reg = <0x43000000 0x10000>;
>>> + interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>,
>>> + <&scmi_clk IMX952_CLK_BUSWAKEUP>,
>>> + <&scmi_clk IMX952_CLK_ASRC1>,
>>> + <&scmi_clk IMX952_CLK_ASRC2>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>,
>>> + <&clk_dummy>;
>>> + clock-names = "mem", "ipg",
>>> + "asrck_0", "asrck_1", "asrck_2", "asrck_3",
>>> + "asrck_4", "asrck_5", "asrck_6", "asrck_7",
>>> + "asrck_8", "asrck_9", "asrck_a", "asrck_b",
>>> + "asrck_c", "asrck_d", "asrck_e", "asrck_f",
>>> + "spba";
>>> + dmas = <&edma2 97 0 0>, <&edma2 98 0 0>, <&edma2 99 0 0>,
>>> + <&edma2 100 0 1>, <&edma2 101 0 1>, <&edma2 102 0 1>;
>> For consistency we should use symbolic macros for directions like you did below.
>> Use FSL_EDMA_RX for rx direction and also introduce FSL_EDMA_TX for tx direction.
> Yes, should use FSL_EDMA_RX.
>
> But introduce FSL_EDMA_TX, it should be zero, FSL_EDMA_TX = 0.
> is it necessary to add it in include/dt-bindings/dma/fsl-edma.h?
I would say yes. For consistency with FSL_EDMA_RX and also for
code readability.
A user doesn't know that 0 means TX.
We could go on and merge this patch as is right now, no problems. And come back later
with a set of cleanup patches that do this for all dtses.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support
2026-03-12 3:49 ` [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support Shengjiu Wang
2026-03-12 6:51 ` Daniel Baluta
@ 2026-03-12 9:43 ` Alexander Stein
2026-03-12 9:49 ` Shengjiu Wang
1 sibling, 1 reply; 14+ messages in thread
From: Alexander Stein @ 2026-03-12 9:43 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Cc: Shengjiu Wang
Am Donnerstag, 12. März 2026, 04:49:10 CET schrieb Shengjiu Wang:
> Add wm8962 sound card. By connecting with ASRC1, the sound card support
> sample rate conversion.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx952-evk.dts | 119 +++++++++++++++++++
> 1 file changed, 119 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> index 509704c23e89..ef0058b98573 100644
> --- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> @@ -110,6 +110,15 @@ reg_vref_1v8: regulator-adc-vref {
> regulator-max-microvolt = <1800000>;
> };
>
> + reg_audio_pwr: regulator-audio-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "audio-pwr";
> + regulator-max-microvolt = <3300000>;
> + regulator-min-microvolt = <3300000>;
> + gpio = <&i2c4_pcal6408 1 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> reg_usdhc2_vmmc: regulator-usdhc2 {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> @@ -131,6 +140,51 @@ reg_usb_vbus: regulator-vbus {
> enable-active-high;
> };
>
> + sound-wm8962 {
> + compatible = "fsl,imx-audio-wm8962";
> + audio-asrc = <&asrc1>;
> + audio-codec = <&wm8962>;
> + audio-cpu = <&sai3>;
> + audio-routing = "Headphone Jack", "HPOUTL",
> + "Headphone Jack", "HPOUTR",
> + "Ext Spk", "SPKOUTL",
> + "Ext Spk", "SPKOUTR",
> + "AMIC", "MICBIAS",
> + "IN3R", "AMIC",
> + "IN1R", "AMIC";
> + hp-det-gpio = <&gpio2 11 GPIO_ACTIVE_HIGH>;
> + model = "wm8962-audio";
> + pinctrl-0 = <&pinctrl_hp>;
> + pinctrl-names = "default";
> + };
> +};
> +
> +&asrc1 {
> + assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL1>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL2>,
> + <&scmi_clk IMX952_CLK_ASRC1>;
> + assigned-clock-parents = <0>, <0>, <0>, <0>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL1>;
> + assigned-clock-rates = <3932160000>, <3612672000>,
> + <393216000>, <361267200>, <49152000>;
> + fsl,asrc-rate = <48000>;
> + status = "okay";
> +};
> +
> +&asrc2 {
> + assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL1>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL2>,
> + <&scmi_clk IMX952_CLK_ASRC2>;
> + assigned-clock-parents = <0>, <0>, <0>, <0>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL1>;
> + assigned-clock-rates = <3932160000>, <3612672000>,
> + <393216000>, <361267200>, <49152000>;
> + fsl,asrc-rate = <48000>;
> + status = "okay";
Is asrc2 actually required? AFAICS this is not referenced.
Best regards,
Alexander
> };
>
> /* pin conflict with PDM */
> @@ -185,6 +239,27 @@ &lpi2c4 {
> pinctrl-0 = <&pinctrl_lpi2c4>;
> status = "okay";
>
> + wm8962: audio-codec@1a {
> + compatible = "wlf,wm8962";
> + reg = <0x1a>;
> + clocks = <&scmi_clk IMX952_CLK_SAI3>;
> + AVDD-supply = <®_audio_pwr>;
> + CPVDD-supply = <®_audio_pwr>;
> + DBVDD-supply = <®_audio_pwr>;
> + DCVDD-supply = <®_audio_pwr>;
> + gpio-cfg = < 0x0000 /* 0:Default */
> + 0x0000 /* 1:Default */
> + 0x0000 /* 2:FN_DMICCLK */
> + 0x0000 /* 3:Default */
> + 0x0000 /* 4:FN_DMICCDAT */
> + 0x0000 /* 5:Default */
> + >;
> + MICVDD-supply = <®_audio_pwr>;
> + PLLVDD-supply = <®_audio_pwr>;
> + SPKVDD1-supply = <®_audio_pwr>;
> + SPKVDD2-supply = <®_audio_pwr>;
> + };
> +
> i2c4_pcal6408: gpio@21 {
> compatible = "nxp,pcal6408";
> reg = <0x21>;
> @@ -312,6 +387,24 @@ &lpspi7 {
> status = "okay";
> };
>
> +&sai3 {
> + assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL1>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL2>,
> + <&scmi_clk IMX952_CLK_SAI3>;
> + assigned-clock-parents = <0>, <0>, <0>, <0>,
> + <&scmi_clk IMX952_CLK_AUDIOPLL1>;
> + assigned-clock-rates = <3932160000>, <3612672000>,
> + <393216000>, <361267200>, <12288000>;
> + pinctrl-0 = <&pinctrl_sai3>;
> + pinctrl-1 = <&pinctrl_sai3_sleep>;
> + pinctrl-names = "default", "sleep";
> + fsl,sai-amix-mode = "bypass";
> + fsl,sai-mclk-direction-output;
> + status = "okay";
> +};
> +
> &scmi_misc {
> nxp,ctrl-ids = <BRD_SM_CTRL_SD3_WAKE 1
> BRD_SM_CTRL_M2E_WAKE 1
> @@ -402,6 +495,12 @@ IMX952_PAD_GPIO_IO27__WAKEUPMIX_TOP_CAN2_RX 0x39e
> >;
> };
>
> + pinctrl_hp: hpgrp {
> + fsl,pins = <
> + IMX952_PAD_GPIO_IO11__WAKEUPMIX_TOP_GPIO2_IO_11 0x31e
> + >;
> + };
> +
> pinctrl_lpi2c2: lpi2c2grp {
> fsl,pins = <
> IMX952_PAD_I2C2_SCL__AONMIX_TOP_LPI2C2_SCL 0x40000b9e
> @@ -476,6 +575,26 @@ IMX952_PAD_SD2_RESET_B__WAKEUPMIX_TOP_GPIO3_IO_7 0x31e
> >;
> };
>
> + pinctrl_sai3: sai3grp {
> + fsl,pins = <
> + IMX952_PAD_GPIO_IO17__WAKEUPMIX_TOP_SAI3_MCLK 0x31e
> + IMX952_PAD_GPIO_IO16__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXBCLK 0x31e
> + IMX952_PAD_GPIO_IO26__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXSYNC 0x31e
> + IMX952_PAD_GPIO_IO20__WAKEUPMIX_TOP_SAI3_RX_DATA_0 0x31e
> + IMX952_PAD_GPIO_IO21__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXDATA 0x31e
> + >;
> + };
> +
> + pinctrl_sai3_sleep: sai3sleepgrp {
> + fsl,pins = <
> + IMX952_PAD_GPIO_IO17__WAKEUPMIX_TOP_GPIO2_IO_17 0x31e
> + IMX952_PAD_GPIO_IO16__WAKEUPMIX_TOP_GPIO2_IO_16 0x31e
> + IMX952_PAD_GPIO_IO26__WAKEUPMIX_TOP_GPIO2_IO_26 0x31e
> + IMX952_PAD_GPIO_IO20__WAKEUPMIX_TOP_GPIO2_IO_20 0x31e
> + IMX952_PAD_GPIO_IO21__WAKEUPMIX_TOP_GPIO2_IO_21 0x31e
> + >;
> + };
> +
> pinctrl_tpm3: tpm3grp {
> fsl,pins = <
> IMX952_PAD_GPIO_IO12__WAKEUPMIX_TOP_TPM3_CH2 0x51e
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support
2026-03-12 9:43 ` Alexander Stein
@ 2026-03-12 9:49 ` Shengjiu Wang
0 siblings, 0 replies; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 9:49 UTC (permalink / raw)
To: Alexander Stein
Cc: robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel, festevam,
devicetree, imx, linux-arm-kernel, linux-kernel, Shengjiu Wang
On Thu, Mar 12, 2026 at 5:45 PM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Am Donnerstag, 12. März 2026, 04:49:10 CET schrieb Shengjiu Wang:
> > Add wm8962 sound card. By connecting with ASRC1, the sound card support
> > sample rate conversion.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx952-evk.dts | 119 +++++++++++++++++++
> > 1 file changed, 119 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> > index 509704c23e89..ef0058b98573 100644
> > --- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> > @@ -110,6 +110,15 @@ reg_vref_1v8: regulator-adc-vref {
> > regulator-max-microvolt = <1800000>;
> > };
> >
> > + reg_audio_pwr: regulator-audio-pwr {
> > + compatible = "regulator-fixed";
> > + regulator-name = "audio-pwr";
> > + regulator-max-microvolt = <3300000>;
> > + regulator-min-microvolt = <3300000>;
> > + gpio = <&i2c4_pcal6408 1 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + };
> > +
> > reg_usdhc2_vmmc: regulator-usdhc2 {
> > compatible = "regulator-fixed";
> > pinctrl-names = "default";
> > @@ -131,6 +140,51 @@ reg_usb_vbus: regulator-vbus {
> > enable-active-high;
> > };
> >
> > + sound-wm8962 {
> > + compatible = "fsl,imx-audio-wm8962";
> > + audio-asrc = <&asrc1>;
> > + audio-codec = <&wm8962>;
> > + audio-cpu = <&sai3>;
> > + audio-routing = "Headphone Jack", "HPOUTL",
> > + "Headphone Jack", "HPOUTR",
> > + "Ext Spk", "SPKOUTL",
> > + "Ext Spk", "SPKOUTR",
> > + "AMIC", "MICBIAS",
> > + "IN3R", "AMIC",
> > + "IN1R", "AMIC";
> > + hp-det-gpio = <&gpio2 11 GPIO_ACTIVE_HIGH>;
> > + model = "wm8962-audio";
> > + pinctrl-0 = <&pinctrl_hp>;
> > + pinctrl-names = "default";
> > + };
> > +};
> > +
> > +&asrc1 {
> > + assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL1>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL2>,
> > + <&scmi_clk IMX952_CLK_ASRC1>;
> > + assigned-clock-parents = <0>, <0>, <0>, <0>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL1>;
> > + assigned-clock-rates = <3932160000>, <3612672000>,
> > + <393216000>, <361267200>, <49152000>;
> > + fsl,asrc-rate = <48000>;
> > + status = "okay";
> > +};
> > +
> > +&asrc2 {
> > + assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL1>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL2>,
> > + <&scmi_clk IMX952_CLK_ASRC2>;
> > + assigned-clock-parents = <0>, <0>, <0>, <0>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL1>;
> > + assigned-clock-rates = <3932160000>, <3612672000>,
> > + <393216000>, <361267200>, <49152000>;
> > + fsl,asrc-rate = <48000>;
> > + status = "okay";
>
> Is asrc2 actually required? AFAICS this is not referenced.
Yes. It can provide memory to memory interface to user space standalone.
Best regards
Shengjiu Wang
>
> Best regards,
> Alexander
>
> > };
> >
> > /* pin conflict with PDM */
> > @@ -185,6 +239,27 @@ &lpi2c4 {
> > pinctrl-0 = <&pinctrl_lpi2c4>;
> > status = "okay";
> >
> > + wm8962: audio-codec@1a {
> > + compatible = "wlf,wm8962";
> > + reg = <0x1a>;
> > + clocks = <&scmi_clk IMX952_CLK_SAI3>;
> > + AVDD-supply = <®_audio_pwr>;
> > + CPVDD-supply = <®_audio_pwr>;
> > + DBVDD-supply = <®_audio_pwr>;
> > + DCVDD-supply = <®_audio_pwr>;
> > + gpio-cfg = < 0x0000 /* 0:Default */
> > + 0x0000 /* 1:Default */
> > + 0x0000 /* 2:FN_DMICCLK */
> > + 0x0000 /* 3:Default */
> > + 0x0000 /* 4:FN_DMICCDAT */
> > + 0x0000 /* 5:Default */
> > + >;
> > + MICVDD-supply = <®_audio_pwr>;
> > + PLLVDD-supply = <®_audio_pwr>;
> > + SPKVDD1-supply = <®_audio_pwr>;
> > + SPKVDD2-supply = <®_audio_pwr>;
> > + };
> > +
> > i2c4_pcal6408: gpio@21 {
> > compatible = "nxp,pcal6408";
> > reg = <0x21>;
> > @@ -312,6 +387,24 @@ &lpspi7 {
> > status = "okay";
> > };
> >
> > +&sai3 {
> > + assigned-clocks = <&scmi_clk IMX952_CLK_AUDIOPLL1_VCO>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL2_VCO>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL1>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL2>,
> > + <&scmi_clk IMX952_CLK_SAI3>;
> > + assigned-clock-parents = <0>, <0>, <0>, <0>,
> > + <&scmi_clk IMX952_CLK_AUDIOPLL1>;
> > + assigned-clock-rates = <3932160000>, <3612672000>,
> > + <393216000>, <361267200>, <12288000>;
> > + pinctrl-0 = <&pinctrl_sai3>;
> > + pinctrl-1 = <&pinctrl_sai3_sleep>;
> > + pinctrl-names = "default", "sleep";
> > + fsl,sai-amix-mode = "bypass";
> > + fsl,sai-mclk-direction-output;
> > + status = "okay";
> > +};
> > +
> > &scmi_misc {
> > nxp,ctrl-ids = <BRD_SM_CTRL_SD3_WAKE 1
> > BRD_SM_CTRL_M2E_WAKE 1
> > @@ -402,6 +495,12 @@ IMX952_PAD_GPIO_IO27__WAKEUPMIX_TOP_CAN2_RX 0x39e
> > >;
> > };
> >
> > + pinctrl_hp: hpgrp {
> > + fsl,pins = <
> > + IMX952_PAD_GPIO_IO11__WAKEUPMIX_TOP_GPIO2_IO_11 0x31e
> > + >;
> > + };
> > +
> > pinctrl_lpi2c2: lpi2c2grp {
> > fsl,pins = <
> > IMX952_PAD_I2C2_SCL__AONMIX_TOP_LPI2C2_SCL 0x40000b9e
> > @@ -476,6 +575,26 @@ IMX952_PAD_SD2_RESET_B__WAKEUPMIX_TOP_GPIO3_IO_7 0x31e
> > >;
> > };
> >
> > + pinctrl_sai3: sai3grp {
> > + fsl,pins = <
> > + IMX952_PAD_GPIO_IO17__WAKEUPMIX_TOP_SAI3_MCLK 0x31e
> > + IMX952_PAD_GPIO_IO16__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXBCLK 0x31e
> > + IMX952_PAD_GPIO_IO26__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXSYNC 0x31e
> > + IMX952_PAD_GPIO_IO20__WAKEUPMIX_TOP_SAI3_RX_DATA_0 0x31e
> > + IMX952_PAD_GPIO_IO21__WAKEUPMIX_TOP_AUDMIX_TDM_OUT_TXDATA 0x31e
> > + >;
> > + };
> > +
> > + pinctrl_sai3_sleep: sai3sleepgrp {
> > + fsl,pins = <
> > + IMX952_PAD_GPIO_IO17__WAKEUPMIX_TOP_GPIO2_IO_17 0x31e
> > + IMX952_PAD_GPIO_IO16__WAKEUPMIX_TOP_GPIO2_IO_16 0x31e
> > + IMX952_PAD_GPIO_IO26__WAKEUPMIX_TOP_GPIO2_IO_26 0x31e
> > + IMX952_PAD_GPIO_IO20__WAKEUPMIX_TOP_GPIO2_IO_20 0x31e
> > + IMX952_PAD_GPIO_IO21__WAKEUPMIX_TOP_GPIO2_IO_21 0x31e
> > + >;
> > + };
> > +
> > pinctrl_tpm3: tpm3grp {
> > fsl,pins = <
> > IMX952_PAD_GPIO_IO12__WAKEUPMIX_TOP_TPM3_CH2 0x51e
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] arm64: dts: imx952: Add audio device nodes
2026-03-12 7:13 ` Daniel Baluta
@ 2026-03-12 9:53 ` Shengjiu Wang
0 siblings, 0 replies; 14+ messages in thread
From: Shengjiu Wang @ 2026-03-12 9:53 UTC (permalink / raw)
To: Daniel Baluta
Cc: Shengjiu Wang, robh, krzk+dt, conor+dt, Frank.Li, s.hauer, kernel,
festevam, devicetree, imx, linux-arm-kernel, linux-kernel
On Thu, Mar 12, 2026 at 3:10 PM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>
> On 3/12/26 08:54, Shengjiu Wang wrote:
> >> On 3/12/26 05:49, Shengjiu Wang wrote:
> >>> Add audio device nodes, include SAI, MICFIL, ASRC, Audio Mixer.
> >>>
> >>> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> >>> ---
> >>> arch/arm64/boot/dts/freescale/imx952.dtsi | 199 ++++++++++++++++++++++
> >>> 1 file changed, 199 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/freescale/imx952.dtsi b/arch/arm64/boot/dts/freescale/imx952.dtsi
> >>> index 0f86b5626cdd..5787c12e788f 100644
> >>> --- a/arch/arm64/boot/dts/freescale/imx952.dtsi
> >>> +++ b/arch/arm64/boot/dts/freescale/imx952.dtsi
> >>> @@ -823,6 +823,156 @@ usdhc3: mmc@42c40000 {
> >>> };
> >>> };
> >>>
> >>> + aips5: bus@43000000 {
> >>> + compatible = "fsl,aips-bus", "simple-bus";
> >>> + reg = <0 0x43000000 0 0x800000>;
> >>> + #address-cells = <1>;
> >>> + #size-cells = <1>;
> >>> + ranges = <0x43000000 0x0 0x43000000 0x800000>;
> >>> +
> >>> + asrc1: asrc@43000000 {
> >>> + compatible = "fsl,imx952-asrc";
> >>> + reg = <0x43000000 0x10000>;
> >>> + interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
> >>> + clocks = <&scmi_clk IMX952_CLK_BUSWAKEUP>,
> >>> + <&scmi_clk IMX952_CLK_BUSWAKEUP>,
> >>> + <&scmi_clk IMX952_CLK_ASRC1>,
> >>> + <&scmi_clk IMX952_CLK_ASRC2>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>,
> >>> + <&clk_dummy>;
> >>> + clock-names = "mem", "ipg",
> >>> + "asrck_0", "asrck_1", "asrck_2", "asrck_3",
> >>> + "asrck_4", "asrck_5", "asrck_6", "asrck_7",
> >>> + "asrck_8", "asrck_9", "asrck_a", "asrck_b",
> >>> + "asrck_c", "asrck_d", "asrck_e", "asrck_f",
> >>> + "spba";
> >>> + dmas = <&edma2 97 0 0>, <&edma2 98 0 0>, <&edma2 99 0 0>,
> >>> + <&edma2 100 0 1>, <&edma2 101 0 1>, <&edma2 102 0 1>;
> >> For consistency we should use symbolic macros for directions like you did below.
> >> Use FSL_EDMA_RX for rx direction and also introduce FSL_EDMA_TX for tx direction.
> > Yes, should use FSL_EDMA_RX.
> >
> > But introduce FSL_EDMA_TX, it should be zero, FSL_EDMA_TX = 0.
> > is it necessary to add it in include/dt-bindings/dma/fsl-edma.h?
>
> I would say yes. For consistency with FSL_EDMA_RX and also for
>
> code readability.
>
> A user doesn't know that 0 means TX.
>
> We could go on and merge this patch as is right now, no problems. And come back later
>
> with a set of cleanup patches that do this for all dtses.
I think it is better to have another patch set to introduce
FSL_EDMA_TX for all dtses.
I will add FSL_EDMA_RX in the next version.
Best regards
shengjiu Wang
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2026-03-12 9:54 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-12 3:49 [PATCH 0/4] arm64: dts: imx952-evk: Add audio sound cards Shengjiu Wang
2026-03-12 3:49 ` [PATCH 1/4] arm64: dts: imx952: Add audio device nodes Shengjiu Wang
2026-03-12 6:40 ` Daniel Baluta
2026-03-12 6:54 ` Shengjiu Wang
2026-03-12 7:13 ` Daniel Baluta
2026-03-12 9:53 ` Shengjiu Wang
2026-03-12 3:49 ` [PATCH 2/4] arm64: dts: imx952-evk: Add sound-wm8962 support Shengjiu Wang
2026-03-12 6:51 ` Daniel Baluta
2026-03-12 9:43 ` Alexander Stein
2026-03-12 9:49 ` Shengjiu Wang
2026-03-12 3:49 ` [PATCH 3/4] arm64: dts: imx952-evk: Add bt-sco sound card support Shengjiu Wang
2026-03-12 6:50 ` Daniel Baluta
2026-03-12 3:49 ` [PATCH 4/4] arm64: dts: imx952-evk: Add PDM microphone " Shengjiu Wang
2026-03-12 6:49 ` Daniel Baluta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox