From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A9D7C52D71 for ; Fri, 9 Aug 2024 07:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wgMk2t3lJl4fD+BEHLQCbtEI8rz6l+c1qkOx4FIfQsQ=; b=4gHwATNPOL5Q59D3SVrJ8U2ySD zCyd2cfjGFRIR4ZSihDbO0vRrOT3rNlsQuB+H+p3Z6fTXjc5Pop6mEv5HWDVxnga9xuzhkJK7oeJJ ZqbVMdpw0IUz6m7W/KvZmQlfDaGwlujdJHw8CcQpjcbd04tshxwgA4pgCZwKGBJiUbC7OUsjyDLXF E891W8BLJnKb+OOZMOAgsVhvonQEhaPT44tGQy+b7MYDqaHwQQOpDVyGvqLTAxNxe51+AaTY/mWz6 F9wxgpFpGTnWM7Al4XcfMY9fWDCw2zE827gvUZ7S7pw4vfmoiCU0vCx58ZsPDaVcOKXMPW5mffX71 CgSXfieA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scKTd-0000000AcaU-3tSx; Fri, 09 Aug 2024 07:55:57 +0000 Received: from mgamail.intel.com ([198.175.65.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scKT3-0000000AcT4-44sk for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2024 07:55:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723190122; x=1754726122; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=RSx2eWpr1wYdEah1lxHqBl9NBPFaOCsVVnKSUHDiYKc=; b=SsEoUqpLKa7fZZL+ma2BN0FyGVtmEjZ46mRyhk0uYaCCricPWbzz1BVK YzkabIMh2b6vGG4eXKlJi5HJLN/aMLTsdtwlEQuuH6bCkd1tb9Z9LWCoD E9El0FaaT2TWj4vppoH3BtiCVWeDghrurBSNLcAUt7WlEmAKV6gxzMe0H 3XfFO2BjqIcGCgPtLiPhz7s9+J0zpaczzd13uOJs8fvV0BaDMItJ3r0XV AJ4L3nMn8aLY3nbyy4sgiX5KQ9r7lnYGm9J7akU/fyVqHs8KKQLdaMAfS AObCr8ml+7rHASJqnNYxG2yR/Gph0o49UyIv9oXcaYYIUuDgBICELd/sk w==; X-CSE-ConnectionGUID: 9bsdSeEKQjCLVNG48UR9kA== X-CSE-MsgGUID: r9F+BizfRMulFTr/LXoWAw== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="21477921" X-IronPort-AV: E=Sophos;i="6.09,275,1716274800"; d="scan'208";a="21477921" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 00:55:21 -0700 X-CSE-ConnectionGUID: sf2mU6w0SDWLRAXC5wMT6w== X-CSE-MsgGUID: Qt2ST2OjSC2z49DeQcrEzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,275,1716274800"; d="scan'208";a="57141428" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.245.197.217]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 00:55:15 -0700 Message-ID: <391a2bd7-b236-467e-aa68-575201bf7a1d@intel.com> Date: Fri, 9 Aug 2024 10:55:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/9] perf auxtrace: Use evsel__is_aux_event() for checking AUX event To: Leo Yan , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , James Clark , Suzuki K Poulose , Mike Leach , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Liang, Kan" References: <20240806204130.720977-1-leo.yan@arm.com> <20240806204130.720977-2-leo.yan@arm.com> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20240806204130.720977-2-leo.yan@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_005522_095705_C42ECD5E X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/08/24 23:41, Leo Yan wrote: > Use evsel__is_aux_event() to decide if an event is a AUX event, this is > a refactoring to replace comparing the PMU type. > > Signed-off-by: Leo Yan Reviewed-by: Adrian Hunter > --- > tools/perf/util/auxtrace.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c > index e2f317063eec..c3f0ef4349fc 100644 > --- a/tools/perf/util/auxtrace.c > +++ b/tools/perf/util/auxtrace.c > @@ -671,11 +671,11 @@ int auxtrace_record__read_finish(struct auxtrace_record *itr, int idx) > { > struct evsel *evsel; > > - if (!itr->evlist || !itr->pmu) > + if (!itr->evlist) > return -EINVAL; > > evlist__for_each_entry(itr->evlist, evsel) { > - if (evsel->core.attr.type == itr->pmu->type) { > + if (evsel__is_aux_event(evsel)) { > if (evsel->disabled) > return 0; > return evlist__enable_event_idx(itr->evlist, evsel, idx);