From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A948C5321D for ; Mon, 26 Aug 2024 07:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZXC8LPaGlFKAb1lVhb8Na89DQ1wSRPlOox9E5ezA6WU=; b=0o0xekao4wAOkabHBfVAeDeTSD fYNBm7x2aoN5ko5gyoa+R82vZ3EEI0a+s8vpOghDm7zQCyYgdBLfkWKNTigK7zm+XxwRmgBsa8R3l KZm2EyzlV67o7UjF8UQVrXHe8N7l69C/4lzqD051+h+6pajUrE4JX3IAdXKF74Ja1GAQwO1mnxBN7 IvI+8XhEbGGU7jFOG/m2Au1k0trdQp54aSD0u5/emwjwE7bZTyYQJR0qQq6T26Ff6AjRhb3zyL89Y PaQih3INOvydkOXGd5h4IMj4LZf3xxLR9o7AVAzecf9ETiqWSm/p/YYy7aEuTzWQcnStU+8t86W5i zpBJWBZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siTiA-00000006A5i-132x; Mon, 26 Aug 2024 07:00:22 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siThC-000000069k1-2JJl for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 06:59:23 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4280ef642fbso4909315e9.1 for ; Sun, 25 Aug 2024 23:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724655561; x=1725260361; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ZXC8LPaGlFKAb1lVhb8Na89DQ1wSRPlOox9E5ezA6WU=; b=wEAH310tet4SGV/MIPGtGdtOv6SRAcmVcA773XVATeVDYwCwYp36FY/d40EVsFdWgG GzWonFoIiOcpYckAqET78ULd8HyxekACyVCtNsepyMjqPoGPTTq9J1yuIq6EBhlwCRWA wOTa1aEdT7xa0y+uLWIIIiBju3q+8dNw4KixrpMfgjpVPu46X9hIXvHNYwU+2MGU4YZx 9hw2f460P22rjn8yz+tLDq/PO1A37LCKVzFridDFBPasjCaGNmO2Sey93mjwwGSz+AaD t2Utszk7S4iFs0CPuAb8iGS9x1gt8iEIqGBvMH7yteEk96igHeRakfdVLJAIaUr+p1+K rc9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724655561; x=1725260361; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZXC8LPaGlFKAb1lVhb8Na89DQ1wSRPlOox9E5ezA6WU=; b=neKtv/8YxsUi9mduJXbd+CDlJq+eKUQQ0LRYK+ZfFbtYl4uG0Nz4+PIqZESZDbCgAy S7ZikPcCJ1eqioY1jQcX+RBr1yQZ3tuuwfa8rUbcrtKELasSDMjq/2+0TNMZdGqOViH0 TFRd65keSx8IL0sXZ9814UZino91yRmmCejNjdkS2XHRUPVdY/JN8D8CdNlKxIKGWXuA g+zFbEuekGzQj3EebDNt6OAVqlVz2o1bvU51hJbNuMkUo02xGg4Aj8D7KDwDekw2uONc r5lyqB5602GXSrr2y4L5S16aXJGWyoxrUUpUkWgNwyfHjisOtgdrAl2g9u3rHqB8bXF9 qveg== X-Forwarded-Encrypted: i=1; AJvYcCU8MoKlB0bZmq26u93CGwdI77Cfr84xv4y4sI5aoHf+jM+3iIiFRV19sq4BLke2arX0OatyZHV82l+34fQP7RZ+@lists.infradead.org X-Gm-Message-State: AOJu0YxeAYkhMRxjsvsMYXTvlsHC7N7Jc9MFv7A5qs4OOokaBefM6Gqf K1UOX7mW2nkl3fvQi0Bl5+0vaqDHp3Fcl2fBaIGSpmvqtN1RaR+BOpBw6f94aQE= X-Google-Smtp-Source: AGHT+IE+npQyzlIhtY9p1H5I6YfZb8gMIw1B9G+EDUhrVf2mwH77kiroEH+GVACuESM/uiF8DXQg+w== X-Received: by 2002:a05:600c:3b8b:b0:426:67e0:3aa with SMTP id 5b1f17b1804b1-42acc8d50f1mr39288345e9.1.1724655560609; Sun, 25 Aug 2024 23:59:20 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac51860e8sm142360175e9.48.2024.08.25.23.59.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2024 23:59:20 -0700 (PDT) Message-ID: <391cc2f7-4a88-4565-8653-e46bd77e28f8@linaro.org> Date: Mon, 26 Aug 2024 08:59:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rtc: at91sam9: fix OF node leak in probe() error path To: Markus Elfring , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Arnd Bergmann , Boris Brezillon , Claudiu Beznea , Johan Hovold , Nicolas Ferre Cc: stable@vger.kernel.org, LKML References: <20240825183103.102904-1-krzysztof.kozlowski@linaro.org> <675f1e34-784f-44d2-9774-2652b919eecd@web.de> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <675f1e34-784f-44d2-9774-2652b919eecd@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_235922_628380_7D6FC179 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/08/2024 21:35, Markus Elfring wrote: >> Driver is leaking an OF node reference obtained from >> of_parse_phandle_with_fixed_args(). > > Is there a need to improve such a change description another bit? > > + Imperative mood I have enough of your stupid emails. Commit msg is fine. > > + Tags like “Fixes” and “Cc” Read the patch. PLONK. Best regards, Krzysztof