From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] memory: atmel-ebi: unwind SMC clock on probe failures
Date: Tue, 30 Jun 2026 19:26:32 +0200 [thread overview]
Message-ID: <39213ee4-4424-46fd-9e8c-12e2f2e02b50@kernel.org> (raw)
In-Reply-To: <20260616151757.32322-1-pengpeng@iscas.ac.cn>
On 16/06/2026 17:17, Pengpeng Hou wrote:
> reg_cells += val;
> @@ -603,11 +605,23 @@ static int atmel_ebi_probe(struct platform_device *pdev)
>
> ret = atmel_ebi_dev_disable(ebi, child);
> if (ret)
> - return ret;
> + goto err_disable_smc_clk;
> }
> }
>
> - return of_platform_populate(np, NULL, NULL, dev);
> + ret = of_platform_populate(np, NULL, NULL, dev);
> + if (ret) {
> + of_platform_depopulate(dev);
Why do we need to depopulate when populate returned with an error?
Best regards,
Krzysztof
prev parent reply other threads:[~2026-06-30 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 15:17 [PATCH] memory: atmel-ebi: unwind SMC clock on probe failures Pengpeng Hou
2026-06-30 17:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39213ee4-4424-46fd-9e8c-12e2f2e02b50@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox