From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E23C2D0E2 for ; Tue, 22 Sep 2020 10:16:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AA6A2395C for ; Tue, 22 Sep 2020 10:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qJsFzfg+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AA6A2395C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iUdz2PIeDE6Bafdh0ikmfNB2+QFJxejiqFU8Z30S1nA=; b=qJsFzfg++HuWrB03KZXlnZptG b73Nk9GHSV796ldrUmPpVmZolhOX7DryA0GzPIa+5A+1lU3y4SIegJcxY3dqEmmtfot/ynJbwcWzh ZD2k9gLSlrVvmHFo1shHe6w2A5hVwXRO/NYtI6Ch17fe9bRjgcT10jeUywvBTJfPfNxRbZFJ1EQXb om0FeywIr6xSy/GDfa6jBbYRo2OBLmtaEunEVQKDqnClMOKKGJAG9xIYdDcuFtKaiNxtIgzjgyDJ1 /87z8NNRoGNDmc8qzUzBS0o9XhWzmP7XZ20BvnaTMjfBrH2EeeawRGDeay+2se+PRHy7u9xN0yv/S UCRRG8bow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKfIz-0006m3-SQ; Tue, 22 Sep 2020 10:13:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKfIr-0006ie-Ja for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 10:13:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90D4F1516; Tue, 22 Sep 2020 03:13:38 -0700 (PDT) Received: from [10.37.8.152] (unknown [10.37.8.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE4853F718; Tue, 22 Sep 2020 03:13:35 -0700 (PDT) Subject: Re: [PATCH v2 22/37] arm64: mte: Add in-kernel MTE helpers To: Catalin Marinas References: <4ac1ed624dd1b0851d8cf2861b4f4aac4d2dbc83.1600204505.git.andreyknvl@google.com> <20200917134653.GB10662@gaia> <7904f7c2-cf3b-315f-8885-e8709c232718@arm.com> <20200918093656.GB6335@gaia> From: Vincenzo Frascino Message-ID: <392180d4-95cf-fed9-5650-bbf52ec5c087@arm.com> Date: Tue, 22 Sep 2020 11:16:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200918093656.GB6335@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_061341_865416_4B6EE21D X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Elena Petrova , Andrey Konovalov , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/18/20 10:36 AM, Catalin Marinas wrote: >> Same as above but I will use the orr in the next version. > I wonder whether system_supports_mte() makes more sense here than the > alternative: > > if (!system_supports_mte()) > return 0xff; > > ... mte irg stuff ... > > (you could do the same for the mte_get_mem_tag() function) > This would have been my preference from the beginning but then you mentioned alternatives ;) Anyway, more then happy to change the code in this way, seems more clean and easy to understand. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel