public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] rtc: sa1100: convert to run-time register mapping
Date: Wed, 04 Feb 2015 14:25:07 +0100	[thread overview]
Message-ID: <39285522.vUKlahhjIR@wuerfel> (raw)
In-Reply-To: <1423005775-26457-3-git-send-email-robh@kernel.org>

On Tuesday 03 February 2015 17:22:53 Rob Herring wrote:
> SA1100 and PXA differ only in register offsets which are currently
> hardcoded in a machine specific header. Some arm64 platforms (PXA1928)
> have this RTC block also.
> 
> Convert the driver to use ioremap and set the register offsets dynamically.
> Since we are touching all the register accesses, convert them all to
> readl/writel.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: rtc-linux at googlegroups.com

Hmm, I really should have sent out my version of the patch ages ago. :(

Can you have a look at

http://git.kernel.org/cgit/linux/kernel/git/arnd/playground.git/commit/?h=multiplatform-3.19-next&id=4d9727883a363fb839e7d1633599166c0a08d644

to see compare the approaches and see if there is anything I did that you
missed?

	Arnd

  reply	other threads:[~2015-02-04 13:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 23:22 [PATCH 0/4] SA1100 RTC clean-up for ARM64 Rob Herring
2015-02-03 23:22 ` [PATCH 1/4] ARM: pxa: add memory resource to RTC device Rob Herring
2015-02-03 23:22 ` [PATCH 2/4] rtc: sa1100: convert to run-time register mapping Rob Herring
2015-02-04 13:25   ` Arnd Bergmann [this message]
2015-02-04 13:44     ` Rob Herring
2015-02-04 13:49       ` Rob Herring
2015-02-04 14:24         ` Arnd Bergmann
2015-02-04 17:30   ` Robert Jarzmik
2015-02-05 13:34     ` Rob Herring
2015-02-05 13:50       ` Russell King - ARM Linux
2015-02-05 19:18         ` Robert Jarzmik
2015-02-05 20:47           ` Rob Herring
2015-02-06 16:26             ` Robert Jarzmik
2015-02-05 23:37           ` Russell King - ARM Linux
2015-02-06 16:20             ` =Robert Jarzmik
2015-02-14 12:22   ` Robert Jarzmik
2015-02-03 23:22 ` [PATCH 3/4] ARM: sa1100: remove unused RTC register definitions Rob Herring
2015-02-03 23:22 ` [PATCH 4/4] ARM: mmp: " Rob Herring
2015-02-04 10:44 ` [PATCH 0/4] SA1100 RTC clean-up for ARM64 Russell King - ARM Linux
2015-02-04 13:58   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39285522.vUKlahhjIR@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox