From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62BEBC47DDF for ; Thu, 1 Feb 2024 12:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jDCspfZNTSKujvaknyUmDm0eU1Y7MtgGA9h4ZV3lXpU=; b=ziZQOQzFtUJ3C1 8gEgeuBCv06qMe+EL4SbRxSGI8XgM5/IvBL6kF4ER/uGyzu8h/6WN6+VdGciwPb0dqDhw8R6w1sn2 nDu+Hz+wJG+4kF0lr5Ws3At86k7r3THOgg6t+PNuxAarCMXW14FFkxcYVFEbesgjAx8F8JbqnF+Yi 3iwVBrYo3LMxdd6cNstx0bCa2hJjBZHLuWbbqwAXynDeQ4Xz8V2EMqaPE/VEbpJ5EOCXh0gtt8gw7 rWK49tJQkXJo0t+FpNJQqoeGn2SZlAGB+Jm1ZJiNm4BiB9WXHZuwN+zfSbs7a4eP/IKnSohSbNRiV HmQrveiVzZMh22Ij49mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVVpH-00000007gMU-2Bu9; Thu, 01 Feb 2024 12:05:51 +0000 Received: from mail-lj1-f182.google.com ([209.85.208.182]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVVpC-00000007gIM-16CI for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 12:05:49 +0000 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2cf3a095ba6so10971641fa.2 for ; Thu, 01 Feb 2024 04:05:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706789144; x=1707393944; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0fjOoUvz+p1Glr5jyHqYPv+9kiOEbm6VD6iqXP6pNtw=; b=nAYieHOVL98pqkjd21VYBzyyQpPYr4+Iue3WiWqdjZgC7qKnAJfII2oi0wvatwDuQy 7EvkiiVgKwiLPDRcJz8jr1lAAV9sQEYAMv1HGsAf/zFJL8iRJOz41EInUmTRGKnMosN2 /HdewDZ21oV5pj/OPOaKnszdVSkf/wtnnkctFnLyPAmKd+EJ++pGO5/I5bme4xx1S39E CqoZIKpgX1XV7TwHAd/YU3GmkSFeKQ/1aT+ASClzeJ7I5NPOeiyM8zljajEaJl875MZ5 JnWnyXpLY+Gk55t8VH92G0sZ573x5CAKRGY7/j0wFb9D1V95hGJodLm0hvTG+/uJXGmR rNMA== X-Gm-Message-State: AOJu0YxNPFg2zheZxiuySRyTYCk94BnGFASpYqvS04xP8RFeoToN3EK/ fW6fkY76LHlm+qlL/21pnfxcsH2bXG16O24u0PWKVY3Ffo9xT2oL X-Google-Smtp-Source: AGHT+IGZC0QfBQ4l8HdsMGlFNcjSGY6S1HLX0pqMo8PkW/5+l5A0xllFqIUg4e4XeIe6JcNvsjybCQ== X-Received: by 2002:a05:651c:19a8:b0:2d0:4ef8:347a with SMTP id bx40-20020a05651c19a800b002d04ef8347amr4272991ljb.18.1706789143806; Thu, 01 Feb 2024 04:05:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUNFGV5Tm04Ju2FjYay2XauTsKUmTHPXWQIDhv7vqEwLOMATXnb7ObOYQHB7PsC4/UeOONTVGaCP+Ze4YgMOdTclneQGnKpknmuTwWbFldt0BxYXrWKLZPgwClp7guql9xeTTJvrFmy+O5fnYufzo3GB3W4qHzCRCf1O4jyy5nvP/gGzFzCtQzkfHICGn53dhzER9DXONbEavoaOqH6yDq6saLxVB1rDjahiKY/Nh58LSJRNM9cOM6O1cloYXvbyEYkQS3DnEH9ZpzeLVh4c2GX5o0VKObiPGW9BeVXDIWphOt7egbftPbIaOeZFGK+kHALvndxihsrlKVqJg== Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id i26-20020aa7c9da000000b005581573e251sm6752683edt.2.2024.02.01.04.05.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Feb 2024 04:05:43 -0800 (PST) Message-ID: <3935b841-77b7-4265-a727-98a358cd56be@kernel.org> Date: Thu, 1 Feb 2024 13:05:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] serial: mxs-auart: fix tx Content-Language: en-US To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Emil Kronborg , Shawn Guo , Sascha Hauer , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Fabio Estevam , NXP Linux Team , "linux-arm-kernel@lists.infradead.org" References: <20240201105557.28043-1-jirislaby@kernel.org> <20240201105557.28043-2-jirislaby@kernel.org> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20240201105557.28043-2-jirislaby@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_040546_446018_60695883 X-CRM114-Status: GOOD ( 22.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01. 02. 24, 11:55, Jiri Slaby (SUSE) wrote: > Emil reports: > After updating Linux on an i.MX28 board, serial communication over > AUART broke. When I TX from the board and measure on the TX pin, it > seems like the HW fifo is not emptied before the transmission is > stopped. > > MXS performs weird things with stop_tx(). The driver makes it > conditional on uart_tx_stopped(). > > So the driver needs special handling. Pass the brand new UART_TX_NOSTOP > to uart_port_tx_flags() and handle the stop on its own. > > Signed-off-by: Jiri Slaby (SUSE) > Reported-by: Emil Kronborg > Fixes: 2d141e683e9a ("tty: serial: use uart_port_tx() helper") > Closes: https://lore.kernel.org/all/miwgbnvy3hjpnricubg76ytpn7xoceehwahupy25bubbduu23s@om2lptpa26xw/ Am I unable to send a proper patch anymore? I forgot to add mxs+arm maintainers: Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-kernel@lists.infradead.org I can resend with those fixed, if you prefer... > --- > drivers/tty/serial/mxs-auart.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > index 3ec725555bcc..4749331fe618 100644 > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -605,13 +605,16 @@ static void mxs_auart_tx_chars(struct mxs_auart_port *s) > return; > } > > - pending = uart_port_tx(&s->port, ch, > + pending = uart_port_tx_flags(&s->port, ch, UART_TX_NOSTOP, > !(mxs_read(s, REG_STAT) & AUART_STAT_TXFF), > mxs_write(ch, s, REG_DATA)); > if (pending) > mxs_set(AUART_INTR_TXIEN, s, REG_INTR); > else > mxs_clr(AUART_INTR_TXIEN, s, REG_INTR); > + > + if (uart_tx_stopped(&s->port)) > + mxs_auart_stop_tx(&s->port); > } > > static void mxs_auart_rx_char(struct mxs_auart_port *s) -- js suse labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel