* [PATCH] pmdomain: rockchip: add regulator dependency
@ 2025-03-04 14:27 Arnd Bergmann
2025-03-04 14:31 ` Sebastian Reichel
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Arnd Bergmann @ 2025-03-04 14:27 UTC (permalink / raw)
To: Ulf Hansson, Heiko Stuebner, Sebastian Reichel
Cc: Arnd Bergmann, linux-pm, linux-arm-kernel, linux-rockchip,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:
drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]
653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
| ^~~~~~~~~~~~~~~~~~~~~
| devm_regulator_get
drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
| ^
Add a Kconfig dependency.
Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pmdomain/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
index 7e4f9b628f0b..218d43186e5b 100644
--- a/drivers/pmdomain/rockchip/Kconfig
+++ b/drivers/pmdomain/rockchip/Kconfig
@@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
bool "Rockchip generic power domain"
depends on PM
depends on HAVE_ARM_SMCCC_DISCOVERY
+ depends on REGULATOR
select PM_GENERIC_DOMAINS
help
Say y here to enable power domain support.
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pmdomain: rockchip: add regulator dependency
2025-03-04 14:27 [PATCH] pmdomain: rockchip: add regulator dependency Arnd Bergmann
@ 2025-03-04 14:31 ` Sebastian Reichel
2025-03-04 20:23 ` Dragan Simic
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2025-03-04 14:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Hansson, Heiko Stuebner, Arnd Bergmann, linux-pm,
linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]
Hi,
On Tue, Mar 04, 2025 at 03:27:59PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:
>
> drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
> | ^~~~~~~~~~~~~~~~~~~~~
> | devm_regulator_get
> drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
> | ^
>
> Add a Kconfig dependency.
>
> Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> drivers/pmdomain/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
> index 7e4f9b628f0b..218d43186e5b 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
> bool "Rockchip generic power domain"
> depends on PM
> depends on HAVE_ARM_SMCCC_DISCOVERY
> + depends on REGULATOR
> select PM_GENERIC_DOMAINS
> help
> Say y here to enable power domain support.
> --
> 2.39.5
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pmdomain: rockchip: add regulator dependency
2025-03-04 14:27 [PATCH] pmdomain: rockchip: add regulator dependency Arnd Bergmann
2025-03-04 14:31 ` Sebastian Reichel
@ 2025-03-04 20:23 ` Dragan Simic
2025-03-04 20:44 ` Heiko Stübner
2025-03-05 14:53 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Dragan Simic @ 2025-03-04 20:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Hansson, Heiko Stuebner, Sebastian Reichel, Arnd Bergmann,
linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel
Hello Arnd,
On 2025-03-04 15:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:
>
> drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit
> declaration of function 'devm_of_regulator_get'; did you mean
> 'devm_regulator_get'? [-Wimplicit-function-declaration]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev,
> pd->node, "domain");
> | ^~~~~~~~~~~~~~~~~~~~~
> | devm_regulator_get
> drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to
> 'struct regulator *' from 'int' makes pointer from integer without a
> cast [-Wint-conversion]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev,
> pd->node, "domain");
> | ^
>
> Add a Kconfig dependency.
>
> Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pmdomain/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/rockchip/Kconfig
> b/drivers/pmdomain/rockchip/Kconfig
> index 7e4f9b628f0b..218d43186e5b 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
> bool "Rockchip generic power domain"
> depends on PM
> depends on HAVE_ARM_SMCCC_DISCOVERY
> + depends on REGULATOR
> select PM_GENERIC_DOMAINS
> help
> Say y here to enable power domain support.
Looking good to me, thanks for this patch.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pmdomain: rockchip: add regulator dependency
2025-03-04 14:27 [PATCH] pmdomain: rockchip: add regulator dependency Arnd Bergmann
2025-03-04 14:31 ` Sebastian Reichel
2025-03-04 20:23 ` Dragan Simic
@ 2025-03-04 20:44 ` Heiko Stübner
2025-03-05 14:53 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2025-03-04 20:44 UTC (permalink / raw)
To: Ulf Hansson, Sebastian Reichel, Arnd Bergmann
Cc: Arnd Bergmann, linux-pm, linux-arm-kernel, linux-rockchip,
linux-kernel
Am Dienstag, 4. März 2025, 15:27:59 MEZ schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:
>
> drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
> | ^~~~~~~~~~~~~~~~~~~~~
> | devm_regulator_get
> drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
> | ^
>
> Add a Kconfig dependency.
>
> Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pmdomain: rockchip: add regulator dependency
2025-03-04 14:27 [PATCH] pmdomain: rockchip: add regulator dependency Arnd Bergmann
` (2 preceding siblings ...)
2025-03-04 20:44 ` Heiko Stübner
@ 2025-03-05 14:53 ` Ulf Hansson
3 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2025-03-05 14:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Heiko Stuebner, Sebastian Reichel, Arnd Bergmann, linux-pm,
linux-arm-kernel, linux-rockchip, linux-kernel
On Tue, 4 Mar 2025 at 15:28, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_REGULATOR is disabled, this pmdomain driver fails to build:
>
> drivers/pmdomain/rockchip/pm-domains.c:653:30: error: implicit declaration of function 'devm_of_regulator_get'; did you mean 'devm_regulator_get'? [-Wimplicit-function-declaration]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
> | ^~~~~~~~~~~~~~~~~~~~~
> | devm_regulator_get
> drivers/pmdomain/rockchip/pm-domains.c:653:28: error: assignment to 'struct regulator *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 653 | pd->supply = devm_of_regulator_get(pmu->dev, pd->node, "domain");
> | ^
>
> Add a Kconfig dependency.
>
> Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
> index 7e4f9b628f0b..218d43186e5b 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -5,6 +5,7 @@ config ROCKCHIP_PM_DOMAINS
> bool "Rockchip generic power domain"
> depends on PM
> depends on HAVE_ARM_SMCCC_DISCOVERY
> + depends on REGULATOR
> select PM_GENERIC_DOMAINS
> help
> Say y here to enable power domain support.
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-05 14:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-04 14:27 [PATCH] pmdomain: rockchip: add regulator dependency Arnd Bergmann
2025-03-04 14:31 ` Sebastian Reichel
2025-03-04 20:23 ` Dragan Simic
2025-03-04 20:44 ` Heiko Stübner
2025-03-05 14:53 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).