From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Richard Zhu <hongxing.zhu@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
marcel.ziswiler@toradex.com, marex@denx.de,
tharvey@gateworks.com, richard.leitner@linux.dev,
lukas@mntre.com, patchwork-lst@pengutronix.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: soc: imx8mp-hsio-blk-ctrl: add clock cells
Date: Wed, 14 Dec 2022 07:42:35 +0100 [thread overview]
Message-ID: <3950061.kQq0lBPeGt@steina-w> (raw)
In-Reply-To: <20221213160112.1900410-1-l.stach@pengutronix.de>
Hi Lucas,
Am Dienstag, 13. Dezember 2022, 17:01:09 CET schrieb Lucas Stach:
> The HSIO blk-ctrl has a internal PLL, which can be used as a reference
> clock for the PCIe PHY. Add clock-cells to the binding to allow the
> driver to expose this PLL.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> .../devicetree/bindings/soc/imx/fsl,imx8mp-hsio-blk-ctrl.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hsio-blk-ctrl.yaml
> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hsio-blk-ctrl.yaml
> index c29181a9745b..1cc7c2bdf2bb 100644
> ---
> a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hsio-blk-ctrl.yaml
> +++
> b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hsio-blk-ctrl.yaml
> @@ -39,6 +39,9 @@ properties:
> - const: pcie
> - const: pcie-phy
>
> + '#clock-cells':
> + const: 1
Rob's bot already noticed the mismatch between this and the example.
Best regards,
Alexander
> +
> clocks:
> minItems: 2
> maxItems: 2
> @@ -85,4 +88,5 @@ examples:
> power-domain-names = "bus", "usb", "usb-phy1",
> "usb-phy2", "pcie", "pcie-phy";
> #power-domain-cells = <1>;
> + #clock-cells = <0>;
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-12-14 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 16:01 [PATCH 1/4] dt-bindings: soc: imx8mp-hsio-blk-ctrl: add clock cells Lucas Stach
2022-12-13 16:01 ` [PATCH 2/4] arm64: dts: imx8mp: add clock-cells to hsio-blk-ctrl Lucas Stach
2022-12-13 16:01 ` [PATCH 3/4] soc: imx: imx8mp-blk-ctrl: add instance specific probe function Lucas Stach
2022-12-13 16:01 ` [PATCH 4/4] soc: imx: imx8mp-blk-ctrl: expose high performance PLL clock Lucas Stach
2022-12-13 16:34 ` Lucas Stach
[not found] ` <202212140421.k5Qj6UGm-lkp@intel.com>
2022-12-14 6:30 ` Marcel Ziswiler
2022-12-13 20:15 ` [PATCH 1/4] dt-bindings: soc: imx8mp-hsio-blk-ctrl: add clock cells Lukas F. Hartmann
2022-12-14 2:22 ` Rob Herring
2022-12-14 5:41 ` Marcel Ziswiler
2022-12-14 5:51 ` Hongxing Zhu
2022-12-14 6:22 ` Marcel Ziswiler
2022-12-14 8:30 ` Hongxing Zhu
2022-12-14 6:42 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3950061.kQq0lBPeGt@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=lukas@mntre.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=patchwork-lst@pengutronix.de \
--cc=richard.leitner@linux.dev \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).