public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Dingxian Wen" <shawn.wen@rock-chips.com>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	"Shreeya Patel" <shreeya.patel@collabora.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, kernel@collabora.com,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Jose Abreu" <Jose.Abreu@synopsys.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Nelson Costa" <Nelson.Costa@synopsys.com>,
	"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Stephen Boyd" <sboyd@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi input driver
Date: Sun, 21 Jul 2024 17:06:24 +0200	[thread overview]
Message-ID: <39542eb6-8616-468b-889e-d9e1db5bcac0@web.de> (raw)
In-Reply-To: <20240719124032.26852-5-shreeya.patel@collabora.com>

…
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -0,0 +1,2763 @@
> +static void hdmirx_writel(struct snps_hdmirx_dev *hdmirx_dev, int reg, u32 val)
> +{
> +	spin_lock_irqsave(&hdmirx_dev->rst_lock, lock_flags);
> +	writel(val, hdmirx_dev->regs + reg);
> +	spin_unlock_irqrestore(&hdmirx_dev->rst_lock, lock_flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&hdmirx_dev->rst_lock);”?
https://elixir.bootlin.com/linux/v6.10/source/include/linux/spinlock.h#L574

Regards,
Markus


  parent reply	other threads:[~2024-07-21 15:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 12:40 [PATCH v4 0/4] Add Synopsys DesignWare HDMI RX Controller Shreeya Patel
2024-07-19 12:40 ` [PATCH v4 1/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver Shreeya Patel
2024-07-19 12:47   ` Christopher Obbard
2024-07-19 12:40 ` [PATCH v4 2/4] dt-bindings: media: Document bindings for HDMI RX Controller Shreeya Patel
2024-07-19 22:10   ` Rob Herring (Arm)
2024-07-25  9:46     ` Shreeya Patel
2024-07-20 10:44   ` Johan Jonker
2024-07-22 13:53     ` Shreeya Patel
2024-07-23 11:16       ` Johan Jonker
2024-07-23 17:28         ` Sebastian Reichel
2024-07-24 13:20           ` Johan Jonker
2024-07-25  6:35             ` Krzysztof Kozlowski
2024-07-25  6:38               ` Krzysztof Kozlowski
2024-07-25  7:58             ` AngeloGioacchino Del Regno
2024-07-25 14:10             ` Sebastian Reichel
2024-08-25  7:03   ` Krzysztof Kozlowski
2024-08-26  8:19   ` Michael Riesch
2024-07-19 12:40 ` [PATCH v4 3/4] arm64: dts: rockchip: Add device tree support " Shreeya Patel
     [not found] ` <20240719124032.26852-5-shreeya.patel@collabora.com>
2024-07-20 11:33   ` [PATCH v4 4/4] media: platform: synopsys: Add support for hdmi input driver Johan Jonker
2024-07-22 14:19     ` Shreeya Patel
2024-07-20 23:43   ` George Stark
2024-07-21  8:51   ` Hans Verkuil
2024-07-25  9:56     ` Shreeya Patel
2024-07-21 15:06   ` Markus Elfring [this message]
     [not found]   ` <c5b9be4d-16ee-45f7-b980-d2e0e4b3ef23@xs4all.nl>
2024-09-23 22:24     ` Dmitry Osipenko
2024-09-23 22:36     ` Dmitry Osipenko
     [not found] ` <20240722193946.1246372-1-hoff.benjamin.k@gmail.com>
2024-07-22 20:26   ` Shreeya Patel
2024-08-03 23:57 ` [PATCH v4 0/4] Add Synopsys DesignWare HDMI RX Controller Tim Surber
     [not found]   ` <929d2f50-6b0e-4d1e-a6d3-482d615bd06a@collabora.com>
2024-08-06 20:37     ` Tim Surber
     [not found]   ` <19150697f90.11f343d091099757.4301715823219222254@collabora.com>
2024-08-24 23:03     ` Tim Surber
2024-08-28 22:13     ` Tim Surber
     [not found]       ` <1919d97402f.b403f96c443474.1860819764033812181@collabora.com>
2024-09-06 20:02         ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39542eb6-8616-468b-889e-d9e1db5bcac0@web.de \
    --to=markus.elfring@web.de \
    --cc=Jose.Abreu@synopsys.com \
    --cc=Nelson.Costa@synopsys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.osipenko@collabora.com \
    --cc=heiko@sntech.de \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shawn.wen@rock-chips.com \
    --cc=shreeya.patel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox