From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CFDBE7B5F1 for ; Wed, 4 Oct 2023 11:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=seeqH+M79bcsDe3oGzppSzVS3PF2Kuidr5rengXY5BE=; b=peTRmR03oLkwn0 YWa6cSkvV9YM2yABaI4Zuo+5gx1me+au4nUZiBsftfJgqUHBm9cG3gdkFoiuPLxXuzJf0jIVc5Ils lOBwXh2EywrAQSecQJxBPYLRNTsToEFeC4U22qtDaO7szzRtVT2x49gX3IK7QCyClySaY6fZb3QhJ RGXHfWGf6jFLISwJeQecwyvtE09PI/aRl27dr4JwCaj9oLuMB6pnIWWWghQ/Uj+mh+tcg1jVCfO01 iD2o3nyi1obY3u9w1kK5/3bYAfablV5bQW3feSTin+miQqPHPSZTNQJlVwumZ0RcXBJrej55h7SLT 17aKF4kfC79ClrYVjBTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnzp7-00HSGG-1K; Wed, 04 Oct 2023 11:13:49 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnzp4-00HSFA-1G for linux-arm-kernel@lists.infradead.org; Wed, 04 Oct 2023 11:13:48 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 394BDgCc018714; Wed, 4 Oct 2023 06:13:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696418022; bh=3uoyr+JW6VEuPEtXqA1Yqm1VcrYyfrhzgcubOT8isrU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=w3XsiyKowWSjx81bGg9zl+c0yAoDfAE5vzs9gv22VvpCTgMP5AU+KWb5Y6+j/gef1 8J+9AKPp3dQ9L8Q9QtVhYP0nhTb2ZlrYoZXP2GxYHAXf2ZUCu6W0su9Nk3ACd8wQtN yMu5uQs5Jto1VaF9FjGmD8z8naeH5qT1wD88WYtY= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 394BDgf8024666 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Oct 2023 06:13:42 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 4 Oct 2023 06:13:42 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 4 Oct 2023 06:13:41 -0500 Received: from [172.24.227.112] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 394BDbOp098083; Wed, 4 Oct 2023 06:13:37 -0500 Message-ID: <395f1670-d9cd-42ed-99f0-8d33bc6164e5@ti.com> Date: Wed, 4 Oct 2023 16:43:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/5] arm64: dts: ti: k3-j784s4-main: Add DSS and DP-bridge node Content-Language: en-US To: Nishanth Menon CC: , , , , , , , , , , , , , References: <20230927121157.278592-1-j-choudhary@ti.com> <20230927121157.278592-4-j-choudhary@ti.com> <20230927122437.4a76enao7xqyw7hp@retreat> From: Jayesh Choudhary In-Reply-To: <20230927122437.4a76enao7xqyw7hp@retreat> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_041346_510117_8BD0DBDC X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/09/23 17:54, Nishanth Menon wrote: > On 17:41-20230927, Jayesh Choudhary wrote: >> From: Rahul T R >> >> Add DSS and DP-bridge node for J784S4 SoC. DSS IP in J784S4 is >> same as DSS IP in J721E, so same compatible is being used. >> The DP is Cadence MHDP8546. >> >> Signed-off-by: Rahul T R >> [j-choudhary@ti.com: move dss & mhdp node together in main, fix dss node] >> Signed-off-by: Jayesh Choudhary >> Reviewed-by: Aradhya Bhatia >> --- >> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 61 ++++++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> index a0e4d8808693..5ae11b0d5d0a 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> @@ -1772,4 +1772,65 @@ c71_3: dsp@67800000 { >> firmware-name = "j784s4-c71_3-fw"; >> status = "disabled"; >> }; >> + >> + mhdp: bridge@a000000 { >> + compatible = "ti,j721e-mhdp8546"; >> + reg = <0x0 0xa000000 0x0 0x30a00>, >> + <0x0 0x4f40000 0x0 0x20>; >> + reg-names = "mhdptx", "j721e-intg"; >> + clocks = <&k3_clks 217 11>; >> + interrupt-parent = <&gic500>; >> + interrupts = ; >> + power-domains = <&k3_pds 217 TI_SCI_PD_EXCLUSIVE>; >> + status = "disabled"; > > Document why disabled. Okay. > >> + >> + dp0_ports: ports { >> + }; > > Document why empty node I will mention that the remote-endpoint are on the board so all the properties are defined there together. So keeping it empty here. Other way could be to add #address-cells and #size-cell here with port child-node. And its remote end point added in the board file. But node would still be incomplete here. Warm Regards, -Jayesh > >> + }; >> + >> + dss: dss@4a00000 { >> + compatible = "ti,j721e-dss"; >> + reg = <0x00 0x04a00000 0x00 0x10000>, /* common_m */ >> + <0x00 0x04a10000 0x00 0x10000>, /* common_s0*/ >> + <0x00 0x04b00000 0x00 0x10000>, /* common_s1*/ >> + <0x00 0x04b10000 0x00 0x10000>, /* common_s2*/ >> + <0x00 0x04a20000 0x00 0x10000>, /* vidl1 */ >> + <0x00 0x04a30000 0x00 0x10000>, /* vidl2 */ >> + <0x00 0x04a50000 0x00 0x10000>, /* vid1 */ >> + <0x00 0x04a60000 0x00 0x10000>, /* vid2 */ >> + <0x00 0x04a70000 0x00 0x10000>, /* ovr1 */ >> + <0x00 0x04a90000 0x00 0x10000>, /* ovr2 */ >> + <0x00 0x04ab0000 0x00 0x10000>, /* ovr3 */ >> + <0x00 0x04ad0000 0x00 0x10000>, /* ovr4 */ >> + <0x00 0x04a80000 0x00 0x10000>, /* vp1 */ >> + <0x00 0x04aa0000 0x00 0x10000>, /* vp1 */ >> + <0x00 0x04ac0000 0x00 0x10000>, /* vp1 */ >> + <0x00 0x04ae0000 0x00 0x10000>, /* vp4 */ >> + <0x00 0x04af0000 0x00 0x10000>; /* wb */ >> + reg-names = "common_m", "common_s0", >> + "common_s1", "common_s2", >> + "vidl1", "vidl2","vid1","vid2", >> + "ovr1", "ovr2", "ovr3", "ovr4", >> + "vp1", "vp2", "vp3", "vp4", >> + "wb"; >> + clocks = <&k3_clks 218 0>, >> + <&k3_clks 218 2>, >> + <&k3_clks 218 5>, >> + <&k3_clks 218 14>, >> + <&k3_clks 218 18>; >> + clock-names = "fck", "vp1", "vp2", "vp3", "vp4"; >> + power-domains = <&k3_pds 218 TI_SCI_PD_EXCLUSIVE>; >> + interrupts = , >> + , >> + , >> + ; >> + interrupt-names = "common_m", >> + "common_s0", >> + "common_s1", >> + "common_s2"; >> + status = "disabled"; > > Same > >> + >> + dss_ports: ports { > > Same > >> + }; >> + }; >> }; >> -- >> 2.25.1 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel