public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: rockford@yandex.ru (Панов Андрей)
To: linux-arm-kernel@lists.infradead.org
Subject: Bug in drivers/net/ethernet/freescale/fec_main.c, TX is broken. In 4.0.0-rc3
Date: Mon, 23 Mar 2015 11:22:13 +0300	[thread overview]
Message-ID: <397281427098933@web12o.yandex.ru> (raw)
In-Reply-To: <BLUPR03MB373FC71B9A8559E51084C26F50D0@BLUPR03MB373.namprd03.prod.outlook.com>



23.03.2015, 05:42, "fugang.duan at freescale.com" <fugang.duan@freescale.com>:
> From: Fabio Estevam <festevam@gmail.com> Sent: Sunday, March 22, 2015 6:36 AM
>> ?To: Russell King - ARM Linux
>> ?Cc: ????? ??????; Duan Fugang-B38611; netdev at vger.kernel.org; linux-arm-
>> ?kernel
>> ?Subject: Re: Bug in drivers/net/ethernet/freescale/fec_main.c, TX is
>> ?broken. In 4.0.0-rc3
>>
>> ?Hi Russell,
>>
>> ?On Sat, Mar 21, 2015 at 5:53 PM, Russell King - ARM Linux
>> ?<linux@arm.linux.org.uk> wrote:
>>> ?Given that this bug can seriously screw data up in undetectable ways
>>> ?(TCP checksums don't save you, because the FEC generates them on the
>>> ?data which it read from memory, even if it happened to read the data
>>> ?from the SoC's boot ROM) we do need to get this fixed ASAP.
>> ?Current mainline has 2b995f63987013 reverted, so 4.0-rc5 will not have
>> ?this corruption problem.
>>
>> ?Regards,
>>
>> ?Fabio Estevam
>
> We cannot revert the commit 2b995f63987013, otherwise there introduce other issue. The correct fix method is Russell King's fix in the previous mail.
> It is strange thing that I cannot reproduce the issue on i.MX6q sabresd board. Anyway, we must consider TSO case that it's not a fragmented skb.

It is just DMA_API_DEBUG=y error versus several data corruption error. DMA_API_DEBUG can be wrong too.
And did you do the check with that option enabled? This can cause delays in kernel enough to do actually write to the network before code in commit freed non-send data blocks.
I have it disabled all the time.

And you can check it by compiling a kernel over NFS, or big git merges over NFS, or doing big ftp transfer, etc.

--
 ??????

      parent reply	other threads:[~2015-03-23  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <390621425930628@web28o.yandex.ru>
2015-03-10 20:12 ` Bug in drivers/net/ethernet/freescale/fec_main.c, TX is broken. In 4.0.0-rc3 Панов Андрей
2015-03-16  9:21   ` fugang.duan at freescale.com
2015-03-16 13:37     ` Панов Андрей
2015-03-16 14:01       ` fugang.duan at freescale.com
2015-03-16 19:09         ` Панов Андрей
2015-03-21 20:53           ` Russell King - ARM Linux
2015-03-21 22:35             ` Fabio Estevam
2015-03-22 20:08               ` Панов Андрей
     [not found]               ` <BLUPR03MB373FC71B9A8559E51084C26F50D0@BLUPR03MB373.namprd03.prod.outlook.com>
2015-03-23  8:22                 ` Панов Андрей [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=397281427098933@web12o.yandex.ru \
    --to=rockford@yandex.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox