From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>,
mike.kravetz@oracle.com, songmuchun@bytedance.com,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: hugetlb: kill set_huge_swap_pte_at()
Date: Tue, 28 Jun 2022 11:17:32 +0530 [thread overview]
Message-ID: <397f73f7-14d6-ee0c-af42-39e193df030c@arm.com> (raw)
In-Reply-To: <Yrm/+UoOtDY7G5bi@casper.infradead.org>
On 6/27/22 20:04, Matthew Wilcox wrote:
> On Mon, Jun 27, 2022 at 01:05:00PM +0530, Anshuman Khandual wrote:
>>> For the swap entry of hugetlb, we need to remember that we should
>>> call set_huge_swap_pte_at() instead of set_huge_pte_at() every
>>
>> Which is intuitive, so what is the problem ?
>
> The problem is that HugeTLB is DIFFERENT from the rest of the VM.
Agreed.
> This has a huge cost in programmer time, which is infinitely more
> valuable than the cycle shaving you're quibbling over. We should take
> any and every opportunity to make huge pages work the same way as THP
> and order-0 pages.
Got it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-28 5:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 14:57 [PATCH] mm: hugetlb: kill set_huge_swap_pte_at() Qi Zheng
2022-06-27 3:32 ` Muchun Song
2022-06-27 6:18 ` Anshuman Khandual
2022-06-27 6:55 ` Qi Zheng
2022-06-27 7:14 ` Anshuman Khandual
2022-06-27 7:29 ` Qi Zheng
2022-06-27 7:35 ` Anshuman Khandual
2022-06-27 14:34 ` Matthew Wilcox
2022-06-28 5:47 ` Anshuman Khandual [this message]
2022-06-27 7:44 ` Muchun Song
2022-06-27 8:27 ` Anshuman Khandual
2022-06-27 14:41 ` Matthew Wilcox
2022-06-28 3:34 ` Qi Zheng
2023-09-21 16:25 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=397f73f7-14d6-ee0c-af42-39e193df030c@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).