From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: i.MX6Q: Add fixup for RTL8211E Gigabit Ethernet PHY
Date: Wed, 04 Mar 2015 00:29:19 +0100 [thread overview]
Message-ID: <3988965.hS0GXm2TNL@wuerfel> (raw)
In-Reply-To: <1425404579-30591-1-git-send-email-rockford@yandex.ru>
On Tuesday 03 March 2015 20:42:59 Andrey Panov wrote:
> +static int rtl8211e_phy_fixup(struct phy_device *dev)
> +{
> + phy_write(dev, 0x00, 0x3140);
> + mdelay(10);
> + phy_write(dev, 0x00, 0x3340);
> + mdelay(10);
> +
> + return 0;
> +}
>
mdelay(10) is rather evil, can you use msleep(10) here instead?
> + phy_register_fixup_for_uid(PHY_ID_RTL8211E, 0xffffffff,
> + rtl8211e_phy_fixup);
How do you ensure that this fixup is only applied on the boards that need
it, rather than all machines that happen to have this phy?
Arnd
next prev parent reply other threads:[~2015-03-03 23:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 17:42 [PATCH] ARM: i.MX6Q: Add fixup for RTL8211E Gigabit Ethernet PHY Andrey Panov
2015-03-03 23:29 ` Arnd Bergmann [this message]
2015-03-04 19:08 ` Панов Андрей
2015-03-04 19:44 ` Arnd Bergmann
2015-03-04 20:05 ` Панов Андрей
2015-03-04 20:18 ` Fabio Estevam
2015-03-04 20:32 ` Панов Андрей
2015-03-04 21:31 ` Arnd Bergmann
2015-03-05 6:40 ` Панов Андрей
[not found] <1424892206-18679-1-git-send-email-rockford@yandex.ru>
2015-02-25 19:34 ` Marc Kleine-Budde
2015-03-03 2:57 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3988965.hS0GXm2TNL@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).