From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED75C433E0 for ; Fri, 17 Jul 2020 09:55:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AD8620684 for ; Fri, 17 Jul 2020 09:55:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VWEvPm25" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AD8620684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uxGSOHi/CIzLrjZ6Kat9YXM+GFtRb1SaMK7zkwXbpQ0=; b=VWEvPm254+LNBSLsxK1wOLdc2 xEhBUXaYHmfehi0K8ALetODxalKP6WkZOUreuchnva87jJ1YXcbk6hDom5oCFhw0SSjD4Fbrwjf3m vfcP9rqhRWC9/nZjkG/cYPJ8pyJdtaZNvtaLvng7OcrcKdMerVWC/iyI/5hQ6vEfBhDzdeWBtrahp 0rbJymot/K9kcPYspmuhReORKjtlp/XcWgZaseZMsDmEApxnWT+SeI3Oyn65/g53w7bHo2/0V7k5T FV2uWj2NSQU4bagA0hGof1t6NhVds1pkhAICjg4vv+bb4+/Y2XE8gyknOpL+elE4IDemBNtgMPw4j wqmwa1vYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwN3x-0004fD-AW; Fri, 17 Jul 2020 09:53:53 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwN3t-0004dY-EI for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 09:53:50 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id A72CA2A4F59 Subject: Re: [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" To: Rob Herring , Bhanu Prakash Maiya References: <20200715221150.v3.2.I113cdbaf66d48b37ac0faefb9b845480d122f3b9@changeid> <20200716191318.GA2683551@bogus> From: Enric Balletbo i Serra Message-ID: <3995892c-340c-3419-3c2d-934a3067f51b@collabora.com> Date: Fri, 17 Jul 2020 11:53:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200716191318.GA2683551@bogus> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_055349_579905_AE3C9765 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mauro Carvalho Chehab , Duncan Laurie , Furquan Shaikh , Benson Leung , linux-kernel@vger.Kernel.org, "David S . Miller" , Raul E Rangel , Greg Kroah-Hartman , Guenter Roeck , Lee Jones , Eric Peers , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On 16/7/20 21:13, Rob Herring wrote: > On Wed, Jul 15, 2020 at 10:16:04PM -0700, Bhanu Prakash Maiya wrote: >> From: Bhanu Prakash Maiya >> >> Add DT compatible string in >> Documentation/devicetree/bindings/mfd/cros_ec.txt > > Need to update this. > > With that, > > Reviewed-by: Rob Herring > So this is an ACPI-only driver that is instantiated by using the Device Tree namespace link in ACPI. I am not sure how to deal with this, but I suspect we need a proper OF binding definition before accept it. The driver gets at least the baudrate and the flowcontrol from ACPI resources, so I'm wondering if we should also add the properties in the device-tree description (although we're not able to really test because there is not OF hardware that supports it yet). Or is fine to just accept the compatible for now and we can do this later when we have the possibility to test with OF-based hardware. Rob, any thoughts on this? Thanks, Enric >> Signed-off-by: Bhanu Prakash Maiya >> --- >> >> Changes in v3: >> - Rebased changes on google,cros-ec.yaml >> >> Changes in v2: >> - No change >> >> Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel