From: Krzysztof Kozlowski <krzk@kernel.org>
To: Youngmin Nam <youngmin.nam@samsung.com>,
s.nawrocki@samsung.com, alim.akhtar@samsung.com,
linus.walleij@linaro.org, peter.griffin@linaro.org,
semen.protsenko@linaro.org, ivo.ivanov.ivanov1@gmail.com
Cc: ryu.real@samsung.com, d7271.choe@samsung.com,
shin.son@samsung.com, jaewon02.kim@samsung.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] pinctrl: samsung: add per-bank FLTCON offset to EXYNOS9_PIN_BANK_* and fix tables
Date: Sun, 28 Dec 2025 12:41:44 +0100 [thread overview]
Message-ID: <39a6dce9-ea6e-4a43-9bbc-54d822118db4@kernel.org> (raw)
In-Reply-To: <20251202093613.852109-4-youngmin.nam@samsung.com>
On 02/12/2025 10:36, Youngmin Nam wrote:
> Several Exynos9-era pin-bank tables were implicitly assuming that the
> filter control (FLTCON) registers are laid out contiguously from the
> EINT base offset. Per the TRMs this is not always true. FLTCON can live
> at a separate per-bank offset, and the current tables cause the driver
> to program the wrong FLTCON addresses for some banks.
"Can live" or "Does live"? Adding unused offset is not improving the
code. The implicit offset is fine, if it is correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-28 11:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251202093024epcas2p1567dddf09e3599867e9dc14a9a234d38@epcas2p1.samsung.com>
2025-12-02 9:36 ` [PATCH v3 0/5] pinctrl: samsung: exynos9 cleanups and fixes Youngmin Nam
2025-12-02 9:36 ` [PATCH v3 1/5] pinctrl: samsung: Consolidate pin-bank macros under EXYNOS9_* and pass bank_type explicitly Youngmin Nam
2025-12-17 4:28 ` Alim Akhtar
2025-12-28 11:40 ` Krzysztof Kozlowski
2025-12-02 9:36 ` [PATCH v3 2/5] pinctrl: samsung: fix incorrect pin-bank entries on Exynos2200/7885/8890/8895 Youngmin Nam
2025-12-17 4:33 ` Alim Akhtar
2025-12-28 11:37 ` Krzysztof Kozlowski
2025-12-02 9:36 ` [PATCH v3 3/5] pinctrl: samsung: add per-bank FLTCON offset to EXYNOS9_PIN_BANK_* and fix tables Youngmin Nam
2025-12-17 4:46 ` Alim Akhtar
2025-12-28 11:41 ` Krzysztof Kozlowski [this message]
2025-12-02 9:36 ` [PATCH v3 4/5] pinctrl: samsung: fold GS101 pin-bank macros into EXYNOS9_* Youngmin Nam
2025-12-17 4:43 ` Alim Akhtar
2025-12-02 9:36 ` [PATCH v3 5/5] pinctrl: samsung: rename gs101_pinctrl_* to exynos9_pinctrl_* Youngmin Nam
2025-12-17 4:53 ` Alim Akhtar
2025-12-28 11:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a6dce9-ea6e-4a43-9bbc-54d822118db4@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=d7271.choe@samsung.com \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=jaewon02.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=ryu.real@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=shin.son@samsung.com \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).