From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F058CC433EF for ; Thu, 9 Dec 2021 01:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x78UVUY1SUJDYziib7niRR1g2NXI/wbvI/1Efra8z7Q=; b=WaOpwpDvOXflHA BwKyBwd3ZcBvE8ROfCiF9BoHz/qJNqKqtUxj1ElwC7DrM/x6mCt+cAOMER63ZFW1yYfQAN1v4jZsf M8B3WPvNhp77S6Sm2yC1kTxJgwK6Nn2cg+PaxmPMNtGMBZHuk3wZmlZmc+YugHTaQILTzDN4K8etC fcNxsfgn8g0WK9OeohSFXUSY7oBPUTa38PVqWibzAMoeGYimdYQ7z3yWID9kQu+qwuM530k1eBGIb 0qr7ypOHdkpI+i1xXdeVZ2q19FbQ/LB+qc+yVSybvQDWYLnLvhQtkuYxfRxu+P8xcPDxews4BZD2e fD8Q0Yd0zs0oRcQZXPaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv8Y1-00Egmi-8B; Thu, 09 Dec 2021 01:48:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv8Xw-00Egkt-AO; Thu, 09 Dec 2021 01:48:33 +0000 X-UUID: a3d705c955d3467a8b952b40e4756cbc-20211208 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XjABykCBjXFelT4zEiqGcJGg15Ult0B96f3Fb8EdYNs=; b=JEQMqBRWf7fQUOHn/Pm6V3VxkGp7vj6h5pUr6+CdfcdfmpjNOKXXWHfrJDhiC7ryTfZ5ehKNvACitzAGDeOhYvt0pn6jtmau31/68d9/+60/LRmrHMjzOuOwHlDy9kbsCeTNQrEtIzxSNBZKWVRK0d0+MUxwNrLdrGm9nQfTro8=; X-UUID: a3d705c955d3467a8b952b40e4756cbc-20211208 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1961316490; Wed, 08 Dec 2021 18:48:29 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Dec 2021 17:48:27 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 9 Dec 2021 09:48:26 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 9 Dec 2021 09:48:25 +0800 Message-ID: <39aa23e1a48bc36a631b3074af2abfd5d1e2256d.camel@mediatek.com> Subject: Re: [PATCH net-next v7 5/6] stmmac: dwmac-mediatek: add support for mt8195 From: Biao Huang To: Jakub Kicinski CC: , Rob Herring , Matthias Brugger , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , , , , , , , , , , Date: Thu, 9 Dec 2021 09:48:25 +0800 In-Reply-To: <20211208063820.264df62d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20211208054716.603-1-biao.huang@mediatek.com> <20211208054716.603-6-biao.huang@mediatek.com> <20211208063820.264df62d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211208_174832_391382_CF507935 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Jakub, Sorry for some typo in previous reply, fix it here. All these warning lines share a similar semantics: delay_val |= FIELD_PREP(xxx, !!val); and, should come from the expansion of FIELD_PREP in include/linux/bitfiled.h: FIELD _PREP --> __BF_FILED_CHECK --> "~((_mask) >> __bf_shf(_mask)) & (_val) : 0," =============================================================== __BF_FILED_CHECK { ... BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \ ~((_mask) >> __bf_shf(_mask)) & (_val) : 0, \ _pfx "value too large for the field"); \ ... =============================================================== Should I fix it by converting delay_val |= FIELD_PREP(ETH_DLY_TXC_ENABLE, !!mac_delay->tx_delay); to en_val = !!mac_delay->tx_delay; delay_val |= FIELD_PREP(ETH_DLY_TXC_ENABLE, en_val); or other suggestions for these warnings? Thanks~ On Wed, 2021-12-08 at 06:38 -0800, Jakub Kicinski wrote: > On Wed, 8 Dec 2021 13:47:15 +0800 Biao Huang wrote: > > Add Ethernet support for MediaTek SoCs from the mt8195 family. > > > > Signed-off-by: Biao Huang > > Acked-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > sparse reports whole bunch of warnings like this: > > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:213:30: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:217:30: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:228:38: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:232:38: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:247:46: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:255:46: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:273:30: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:277:30: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:375:30: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:379:30: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:390:43: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:397:43: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:415:46: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:426:46: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:439:35: warning: > dubious: x & !y > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:443:30: warning: > dubious: x & !y > > Any idea on where these come from? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel