From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16ACDC52D7C for ; Tue, 13 Aug 2024 07:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XO4lypl8RYK1KTwdq5N/m5efZLalwMg7C5ui88nvChg=; b=05/vhNSJp5na+QG8oBSBfx+f4n cqKvUHFQqFz0BebpCUhfQmSr/kCRaKyariZufZ3uAbaeqD7G4Ke169SSg8hkjS97B/cN0f7ZzkdjL 6za1wEKwUGDG40SUBsxQn0A7a/q7EfjgB3I3BFKa+JFga/mJom+jzubumNur85YPlIbZmI3EDQDOI ouTUGtM1jAc/2TY+X0uPNz/hDNWP27564+WC7aMLrecEr9IevkTsqv3HTVPrIgNa+nPFrqCkNnOgi f0ZP1P2C7dFcI5iNtm7tpc9iuyneXE+rrZXp06WRvW86W/mamgJ39brUqLIV4+CH5SppIJ1kFKkoj ID756elg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdlm6-00000002feF-2lJG; Tue, 13 Aug 2024 07:16:58 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdllV-00000002fYw-19v6 for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2024 07:16:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 46568CE1171; Tue, 13 Aug 2024 07:16:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DB13C4AF09; Tue, 13 Aug 2024 07:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723533377; bh=Zw38o+oLyow2tsJrgb+SA6FlgG4nHiNDqOq3Xu6bCOE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oQfshzgBYzi06GWTwVnYuFQ3M2OJFuGmpSKXX2xposVRmUl+p/hkTjLGQitQoIj1O Ra6aElb2eP9oQjEOzDt+h2rSVKUXHA61UlL83EveTxWSW3rNRzzZ4p/zNBn5qWBD+D QZ+PQwQXITqEMtVzQO9eOXjjn1h8UQcjkBNg3vjj/XdPm6kuc41gkdSCG6C1y7lR6I JS30VHXT4yf6F/DQSSFqFQ3quo9EMIWwucL1Kpd6DojwlhH3Q9AWJN24kz18jHw/KX ublu3qxLW8rt88IMS1z6/l7TTnfvyQq7doYIi26FptgdASvmxrz8/gVBpYt9NRkSp+ VNFQdtt7aVF3g== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sdllP-003F8N-7R; Tue, 13 Aug 2024 08:16:15 +0100 MIME-Version: 1.0 Date: Tue, 13 Aug 2024 08:16:15 +0100 From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [RFC 10/10] KVM: arm64: nv: Add new HDFGRTR2_GROUP & HDFGRTR2_GROUP based FGU handling In-Reply-To: <6c479aba-10b9-46ba-92fa-d3b20cc82d61@arm.com> References: <20240620065807.151540-1-anshuman.khandual@arm.com> <20240620065807.151540-11-anshuman.khandual@arm.com> <865xu3kh4r.wl-maz@kernel.org> <4d256df7-1ec7-4300-b5c8-355f46c0e869@arm.com> <878qyy35e5.wl-maz@kernel.org> <47dc4299-52cc-4f98-929b-fb86bd9757ae@arm.com> <86tthhi0nz.wl-maz@kernel.org> <86o76c1b8p.wl-maz@kernel.org> <86bk2b198o.wl-maz@kernel.org> <87sevk4kgr.wl-maz@kernel.org> <6c479aba-10b9-46ba-92fa-d3b20cc82d61@arm.com> User-Agent: Roundcube Webmail/1.4.15 Message-ID: <39b14f98acfa1afcbdcb46950c62e6c7@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240813_001621_532236_49FD5DEF X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-08-13 07:53, Anshuman Khandual wrote: > On 8/4/24 16:35, Marc Zyngier wrote: >> which shows that an SPMEVFILT2Rn_EL0 access from EL1 traps to EL2 if: >> >> - either HDFGRTR2_EL2.nSPMEVTYPERn_EL0 == '0', (check) >> - or MDCR_EL2.EnSPM == '0', (check) >> - or SPMACCESSR_EL2<(UInt(SPMSELR_EL0.SYSPMUSEL) * 2) + >> 1:UInt(SPMSELR_EL0.SYSPMUSEL) * 2> == '00' >> >> and that last condition requires some more handling as you need to >> evaluate both SPMSELR_EL0.SYSPMUSEL and the corresponding field of >> SPMACCESSR_EL2 to make a decision. It's not majorly complicated, but >> it isn't solved by simply setting a static attribute. > > So IIUC you are suggesting to handle SYS_SPMEVFILT2R_EL0() registers > via > complex condition checks where the CGT_XXX can be directed to a > function > callback instead ? For example, something like the following > (untested). [...] Something like that, yes. M. -- Jazz is not dead. It just smells funny...