Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: "Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Carlos O'Donell" <carlos@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Florian Weimer" <fweimer@redhat.com>,
	"Rich Felker" <dalias@aerifal.cx>,
	"Torvald Riegel" <triegel@redhat.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Uros Bizjak" <ubizjak@gmail.com>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Liam R. Howlett" <liam@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-arch@vger.kernel.org, kernel-dev@igalia.com
Subject: Re: [PATCH v4 1/5] arm64/entry: Unify user mode handling
Date: Mon, 6 Jul 2026 16:03:46 -0300	[thread overview]
Message-ID: <39c3f5cb-5b56-423b-b679-eafc67bbf44f@igalia.com> (raw)
In-Reply-To: <20260705-tonyk-robust_arm-v4-1-e0fd0fa259d3@igalia.com>

Em 05/07/2026 14:56, André Almeida escreveu:
> Currently, arm64 has two functions to prepare and handle context switches
> from userspace: arm64_syscall_enter_from_user_mode() and
> arm64_enter_from_user_mode(). The only difference is that the later calls
> rseq_note_user_irq_entry() that sets rseq.event.user_irq as true.
> 
> To ensure that futex_fixup_robust_unlock() works correctly, unify the
> handling from user mode functions into one that always calls
> rseq_note_user_irq_entry().
> 
> Other architectures calls irqentry_enter_from_user_mode() for syscalls
> and interruptions, that sets rseq.event.user_irq as well.
> 
> Signed-off-by: André Almeida <andrealmeid@igalia.com>

It turns out that this patch is not needed at all and 
futex_fixup_robust_unlock() is already working correctly for arm64. The 
user thread can't call a syscall in the middle of the vdso function.


  reply	other threads:[~2026-07-06 19:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-05 17:56 [PATCH v4 0/5] arm64: vdso: Implement __vdso_futex_robust_try_unlock() André Almeida
2026-07-05 17:56 ` [PATCH v4 1/5] arm64/entry: Unify user mode handling André Almeida
2026-07-06 19:03   ` André Almeida [this message]
2026-07-05 17:56 ` [PATCH v4 2/5] arm64: vdso: Prepare for robust futex unlock support André Almeida
2026-07-05 17:56 ` [PATCH v4 3/5] arm64: vdso: Implement __vdso_futex_robust_try_unlock() André Almeida
2026-07-05 17:56 ` [PATCH v4 4/5] arm64: vdso32: Bring vdso32-offsets.h back André Almeida
2026-07-05 17:56 ` [PATCH v4 5/5] arm64: vdso32: Implement __vdso_futex_robust_try_unlock() André Almeida
2026-07-05 20:23 ` [PATCH v4 0/5] arm64: vdso: " Thomas Gleixner
2026-07-06 19:02   ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39c3f5cb-5b56-423b-b679-eafc67bbf44f@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=bigeasy@linutronix.de \
    --cc=carlos@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=dalias@aerifal.cx \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=fweimer@redhat.com \
    --cc=kernel-dev@igalia.com \
    --cc=liam@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    --cc=triegel@redhat.com \
    --cc=ubizjak@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox