From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 747FCC6FD18 for ; Tue, 28 Mar 2023 19:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T2TBYcZ8ft001ARNn1IrJDjRB5/DM0TVRIzCVGRqaTo=; b=BVsQDeTsbiCbkF PYuQxMHJBrQbefM8qconoLITNVWeedjKk+o9PjXTpJ7Ypi2/UhD5hWaYKY0VXqEpbOJC4G8FGsZMo EzN8TcidzRJJCrRPsKRJtVY3M/Qc6YV22JQw30nCUaMohKhM0vhF/OWvSK8P16WEje+y8YWh3A/St na0r8fXxfmaV5hvPG9da3R01Hw5Ld6VX636enq/j6z4t1HXy+CTChAZ07NeTAfwwZeu1cKwJAeAxf 6MY7Zfs+H7dKa9o/l199g81v77OhXWIvZEot79k6JEXFVgfhxHYNvld/kBR1o/0I+5DDQDeaHE1a7 o0tGbmwvYeba/7gYEbhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phFHa-00FgU5-0L; Tue, 28 Mar 2023 19:47:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phFHS-00FgSC-0z for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 19:46:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A124D6192B; Tue, 28 Mar 2023 19:46:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07BA1C433D2; Tue, 28 Mar 2023 19:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680032813; bh=Lmu/Mq2nMz3/AF7qQFtIhYKDY1SCuBIjyGhCVC4C96g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sz4ARuzNm8dKti0tdjEdSeHll5ISYj6remDDdQ4Heml9kiLskkVRYbkhTq/bjSwhW R8hzgRlumr+NzSxuzHeRaxopEsJxIYhAJrDBiGByQdo2ZdVwu2GFnweD3VYQVIdHtc xkHbqxp1WPZh+nVQKAOWP6k2trSzSaN4tSgh9DWWjGhL3VEoDwVrk78JpGumcvKXLS AdvTTBFciEUM8pF/JZwRXb5EiUcsoGGzd0BiCGwUedkHSeMlRz4nTQ4XQCEwygmmEj P6wNkRds2hG4W2DSFU3ewcqXKCX9wMNigGBFLiXVFLRB6EFGzlM3dtRM3ZrfzO5BuH tTcB1gzjfocZw== Message-ID: <39cb4f8c-d10f-f543-ddca-8a8507757f4c@kernel.org> Date: Tue, 28 Mar 2023 22:46:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port for USB0 Content-Language: en-US To: Nishanth Menon Cc: vigneshr@ti.com, kristo@kernel.org, srk@ti.com, r-gunasekaran@ti.com, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230328124315.123778-1-rogerq@kernel.org> <20230328124315.123778-3-rogerq@kernel.org> <20230328131810.x2j6uvwzhniclvwf@evoke> <3bd6191c-caa4-15a8-92ad-17a07ec085e2@kernel.org> <20230328133024.ow6cvm22o2c5heem@untrimmed> From: Roger Quadros In-Reply-To: <20230328133024.ow6cvm22o2c5heem@untrimmed> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_124654_424941_3752EAF6 X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/03/2023 16:30, Nishanth Menon wrote: > On 16:20-20230328, Roger Quadros wrote: >> >> >> On 28/03/2023 16:18, Nishanth Menon wrote: >>> On 15:43-20230328, Roger Quadros wrote: >>>> USB0 is a Type-C port with dual data role and power sink. >>>> >>>> Signed-off-by: Roger Quadros >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 4 ++ >>>> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 44 ++++++++++++++++++- >>>> .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 4 -- >>>> 3 files changed, 47 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts >>>> index b2ca19e3042e..a3c3609833fd 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts >>>> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts >>>> @@ -225,3 +225,7 @@ ldo4_reg: ldo4 { >>>> }; >>>> }; >>>> }; >>>> + >>>> +&usb0 { >>>> + dr_mode = "peripheral"; >>>> +}; >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts >>>> index cdc0858dd1b2..13fdaa9ce4e7 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts >>>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts >>>> @@ -136,6 +136,35 @@ AM62X_IOPAD(0x01d4, PIN_INPUT, 7) /* (B15) UART0_RTSn.GPIO1_23 */ >>>> }; >>>> }; >>>> >>>> +&main_i2c0 { >>>> + typec_pd: tps6598x@3f { >>>> + compatible = "ti,tps6598x"; >>>> + reg = <0x3f>; >>>> + interrupt-parent = <&exp1>; >>>> + interrupts = <17 IRQ_TYPE_EDGE_FALLING>; >>>> + interrupt-names = "irq"; >>>> + >>>> + connector { >>>> + compatible = "usb-c-connector"; >>>> + label = "USB-C"; >>>> + self-powered; >>>> + data-role = "dual"; >>>> + power-role = "sink"; >>>> + ports { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + port@0 { >>>> + reg = <0>; >>>> + usb_con_hs: endpoint { >>>> + remote-endpoint = <&usb0_hs_ep>; >>>> + }; >>>> + }; >>>> + }; >>>> + }; >>>> + }; >>>> +}; >>>> + >>>> &main_i2c1 { >>>> exp1: gpio@22 { >>>> compatible = "ti,tca6424"; >>>> @@ -150,7 +179,7 @@ exp1: gpio@22 { >>>> "UART1_FET_BUF_EN", "WL_LT_EN", >>>> "GPIO_HDMI_RSTn", "CSI_GPIO1", >>>> "CSI_GPIO2", "PRU_3V3_EN", >>>> - "HDMI_INTn", "TEST_GPIO2", >>>> + "HDMI_INTn", "PD_I2C_IRQ", >>>> "MCASP1_FET_EN", "MCASP1_BUF_BT_EN", >>>> "MCASP1_FET_SEL", "UART1_FET_SEL", >>>> "TSINT#", "IO_EXP_TEST_LED"; >>>> @@ -256,3 +285,16 @@ partition@3fc0000 { >>>> }; >>>> }; >>>> }; >>>> + >>>> +&usb0 { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + usb-role-switch; >>>> + >>>> + port@0 { >>>> + reg = <0>; >>>> + usb0_hs_ep: endpoint { >>>> + remote-endpoint = <&usb_con_hs>; >>>> + }; >>>> + }; >>>> +}; >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi >>>> index 80e8b9b9a5f5..e3223088b90c 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi >>>> @@ -264,10 +264,6 @@ &usbss1 { >>>> ti,vbus-divider; >>>> }; >>>> >>>> -&usb0 { >>>> - dr_mode = "peripheral"; >>>> -}; >>>> - >>> >>> How about sk-lp ? >> >> moved it to sk-lp. see above in this patch. >> > > A bit confused. Looking at [1] vs [2], it seems to indicate pd controller at > 0x3f as well? Am I misreading the schematics? > > [1] https://www.ti.com/tool/SK-AM62-LP#design-files > [2] https://www.ti.com/tool/SK-AM62#design-files Yes PD controller is at 0x3f for both boards but IRQ is not routed on AM62-LP. I tried to explain this the cover letter. ;) Pasting here for convenience. > Although k3-am625-lp-sk USB is exactly the same as on k3-am625-sk, > it is missing the IRQ line from Type-C chip which is currently > required as per chip's DT binding. So we don't add Type-C support > for k3-am625-lp-sk till h/w is fixed or polling mode support for > Type-C chip is accepted [2] > > [2] - https://lore.kernel.org/lkml/20230324133741.43408-1-rogerq@kernel.org/T/ cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel