From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4C07C4345F for ; Tue, 30 Apr 2024 13:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+KVSe6BuXgXIRYi9f1QfOGRiPRHmQtvgBBD5GMiYqNU=; b=Az0jhLYWMazB13 00rt1DY4HGXBtFnC7/7fSSxWUxD1poq//7Ki9kvxDQCXwgcdTVngVjkhJ32oN3S+6s0PvWrOMj9/J U8m/nH+l5+/5MtWXuYciCyXhMSTjIY/nUoPmTw34GBaMQ+Zk0j8tvoWXSKM8NdHBcXkdI/cppvBrH 2kZjkPXP2RmIuAuMVDE8T+iaEKlzcv60IIbMGz0nQ4wpo3T07MWtigTc/rE11wtNf86XkaGA2czW6 0TaWafnCt/7sVf7FBfkORuqVZ9caqr3SOeWIcNbGsSMmy5XgiH68WH4WTBJt8nAkWc/3qxDhxVSJ0 xRz88TWkBkEU9ZeJp8vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1ncc-00000006Yc2-3Pqd; Tue, 30 Apr 2024 13:34:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1ncZ-00000006Ybf-39Vh for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 13:34:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B50552F4; Tue, 30 Apr 2024 06:34:36 -0700 (PDT) Received: from [10.1.38.140] (XHFQ2J9959.cambridge.arm.com [10.1.38.140]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C3F393F793; Tue, 30 Apr 2024 06:34:08 -0700 (PDT) Message-ID: <3a1669be-2cf4-486c-901a-3350cf7ffd25@arm.com> Date: Tue, 30 Apr 2024 14:34:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64/mm: Refactor PMD_PRESENT_INVALID and PTE_PROT_NONE bits Content-Language: en-GB To: Catalin Marinas Cc: Will Deacon , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , David Hildenbrand , Peter Xu , Mike Rapoport , Shivansh Vij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240429140208.238056-1-ryan.roberts@arm.com> <20240429140208.238056-2-ryan.roberts@arm.com> <839d6975-ce12-4fc9-aa3b-8ec5787bf577@arm.com> <8cf74e5f-e6a5-465e-83b4-205233c78005@arm.com> From: Ryan Roberts In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_063411_999722_F187AD6B X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/04/2024 14:28, Catalin Marinas wrote: > On Tue, Apr 30, 2024 at 12:35:49PM +0100, Ryan Roberts wrote: >> There is still one problem I need to resolve; During this work I discovered that >> core-mm can call pmd_mkinvalid() for swap pmds. On arm64 this will turn the swap >> pmd into a present pmd, and BadThings can happen in GUP-fast (and any other >> lockless SW table walkers). My original fix modified core-mm to only call >> pmd_mkinvalid() for present pmds. But discussion over there has shown that arm64 >> is the only arch that cannot handle this. So I've been convinced that it's >> probably more robust to make arm64 handle it gracefully and add tests to >> debug_vm_pgtable.c to check for this. Patch incoming shortly, but it will cause >> a conflict with this series. So I'll send a v2 of this once that fix is accepted. > > Sounds fine. I can queue the arm64 pmd_mkinvalid() fix for 6.9 and you > can base this series on top. But I have a preference for this patchset > to sit in -next for a bit anyway, so it might be 6.11 material. Yeah that works for me. I just sent the pmd_mkinvalid() fix. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel