From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30045C4360F for ; Fri, 5 Apr 2019 08:50:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFBC721850 for ; Fri, 5 Apr 2019 08:50:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sjLZ+DG+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="XdyKKUmf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFBC721850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:MIME-Version: Date:Message-ID:From:To:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g/0+GYkmqBWS71BuwRC73TMa97f/8hSrKOIrqwZasrE=; b=sjLZ+DG+lKR4Xh Z3oF6YfNubT+K5yB+zHNxDGDe85ivl9PikU4S9zdtIXIEsPzypmsY6yrpkn1ndsDnyTzrsK0umCKZ a8s8EbU3EaivVGOYdCA7KUzy3e34WtX3WSApLuZFzdajqgNwFfW+4sUnBrq49KG5sETbNhegIS0SQ VqHLCf4ryoqcDv+7q8JLan2AtyzFx0Vw9L3lRknRyXNsBVRQfkZvEqBf/fUCBM8e2NSdymQR/5M2G 7J+0PccRFYErbQni6A8HnQcuZtAdxweK+6/MxsGNH9ZxFNv1jjoZ9NqQeakSS/V8d4UTBUjTieGIq P2mzF+muq7qo0lUCyIuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCKXt-0007MZ-IL; Fri, 05 Apr 2019 08:49:57 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCKXp-0007Lr-T4 for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2019 08:49:56 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190405084950euoutp02e40baed5a1225c95fb9121b21cced8c2~Sh9mhYGF_2392523925euoutp02B for ; Fri, 5 Apr 2019 08:49:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190405084950euoutp02e40baed5a1225c95fb9121b21cced8c2~Sh9mhYGF_2392523925euoutp02B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1554454190; bh=U4VJyRIUX4N+ujQAVvD7OEQgLQFDTrqWaq7fN40sblo=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=XdyKKUmfnrfJaBpFS+N1MqF7yFFhQsyNKxD6sBiglkh5jhPmwh6ce+o+l7Eg9eXye OsaOGA2Jfvg9Cpkdjob+MHl1DJCMe+RpGszhpNRfMnyup8EVzl9svKMxFwQnkEjK9L ecaBlhqYB5LyfAQqTSpC+38k0j1iqOcLL7/NZp2E= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190405084949eucas1p2c8827598489c3d7280713401b08827cd~Sh9l8ztPc1609316093eucas1p2O; Fri, 5 Apr 2019 08:49:49 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 88.53.04377.DA617AC5; Fri, 5 Apr 2019 09:49:49 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190405084948eucas1p1a482e6daa4b89cdf261f7bd3a0c8498e~Sh9lRkITP2241122411eucas1p1a; Fri, 5 Apr 2019 08:49:48 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190405084948eusmtrp1b7f40905e7cb600cfa37f795ee7bf3fe~Sh9lDXNpK1694616946eusmtrp1t; Fri, 5 Apr 2019 08:49:48 +0000 (GMT) X-AuditID: cbfec7f4-12dff70000001119-8f-5ca716ad30e3 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 43.33.04146.CA617AC5; Fri, 5 Apr 2019 09:49:48 +0100 (BST) Received: from [106.120.51.75] (unknown [106.120.51.75]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190405084947eusmtip17432c4cc1eca3a25b40bc49560a4ce1e~Sh9kerd_k1639916399eusmtip1K; Fri, 5 Apr 2019 08:49:47 +0000 (GMT) Subject: Re: [PATCH RFC 1/8] soc: samsung: Add exynos chipid driver support To: Krzysztof Kozlowski From: Sylwester Nawrocki Message-ID: <3a381f69-da67-384a-dfe2-22e38c5570f7@samsung.com> Date: Fri, 5 Apr 2019 10:49:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRju2zlnO45mx2n6YqIx/FFKmtGPA5kVGQxEyn5FWrby4CU3ZVPT LqjJZF7ykog6vGGWOhWvOZkm5OZdnFppMLyEiqVowQamqeU8Sv57nud7nvd9H/hITDhIOJOR sjhGLpNEi7h8vKN/c+xco2NNyPmWGSHdUtxE0NOWZYKuMIwRdO7CKkYbjc08unVhiqA/6Uq5 dLGxh0M3GmZ49NvpCQ5tSq3l0lXvLTxa+cHAuyoQN5Q3IHGrJoMrbqtOFue0a5DY3Op6i7jL 9w1joiMTGLm33wN+ROGuT+zkicSWsQpuClIKMpENCdRFGJpaQpmITwqpWgQ7VWk8llgQDG5/ 5rDEjGA2Nx8/jJS+0R24ahCUrY/jLFlDMKpvRlaXPRUAhrafhBU7UGdhemeDsJowagQDbYlq fxSX8oFXfTn7AQHlB9Wajb2xJIlT7jC84mGVT1J3YK6/mWAtdjBUsrgftaGCYFeZw7VijHKC l5Y6gsVuoF0rxay7gJrlQfHvzIOz/aF+q57HYntYGWg/wC4wUpCNs4E0BNldJh5L8hDMDVQi 1nUJ9AMThPU6bK9Ok86bla9B2ZwOs8pA2cLXNTv2CFt43VF0IAtAlS5k3e7wR1PEYbEzZC3+ xfOQSH2kmvpIHfWROur/eysRrkFOTLxCGs4oLsiYJ14KiVQRLwv3ehQjbUV7/2tkd8DSiXTb D3sRRSLRccEZzrsQISFJUCRJexGQmMhB4Fq3JwnCJElPGXlMqDw+mlH0olMkLnISPDs2Hyyk wiVxzGOGiWXkh68c0sY5BVVMZvFPRxJLGT2+wXnx+iYZx/92Ud/oplYVlb9l/jGq/eJcoVR1 9g7dUJoIz4/3sr+Fev7qxqLdJtYvh0gTy8eTMl0Co8z3x7ueF6amVWq2dP30sNGUHGR3Pb1b 7ai36SwMWE2MM6rzXxTcnKauGOebUxjv7+2Bx9yXxe7dcyJcESHx8cDkCsk/bY2z+lsDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsVy+t/xu7prxJbHGBz4o2CxccZ6VovrX56z Wsw/co7Vov/xa2aL8+c3sFtsenyN1eLyrjlsFjPO72OyWHvkLrvF0usXmSxuN65gs1i09Qu7 ReveI+wOvB5r5q1h9Ni0qpPNY/OSeo++LasYPT5vkgtgjdKzKcovLUlVyMgvLrFVija0MNIz tLTQMzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DLmPrPsOASf8XGc/PZGhhbebsYOTkkBEwk 5izexd7FyMUhJLCUUWLDujbmLkYOoISUxPwWJYgaYYk/17rYIGpeM0qsP7yfESQhLOAtcWTz e1YQW0RAU+L63++sIEXMAqeZJVa/2cYC0dHBJLH6wXwmkCo2AUOJ3qN9YN28AnYSS1Z9ZwfZ xiKgInHqlRZIWFQgQuLM+xUsECWCEidnPgGzOQUCJf619rGB2MwC6hJ/5l1ihrDFJZq+rGSF sOUltr+dwzyBUWgWkvZZSFpmIWmZhaRlASPLKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMBo 3Xbs5+YdjJc2Bh9iFOBgVOLhbWBZFiPEmlhWXJl7iFGCg1lJhFduJVCINyWxsiq1KD++qDQn tfgQoynQbxOZpUST84GJJK8k3tDU0NzC0tDc2NzYzEJJnPe8QWWUkEB6YklqdmpqQWoRTB8T B6dUA6Noo2RVw6NTVlGpB5Zc/cjr3cTtJWp65my/2dKQ83Ifi5h/hud9Xa3Ps/az6amM2Ww2 d28LfqoRSfHs13DNXbWusFns0VK11Sf8Lu0s7F2SdfXQy1rRqrhXbBtknyzV93z9tNybra/r EGP49NOpKYpsDCJe6k2Rn8NXfzse1Sfiu9WLs0lTXImlOCPRUIu5qDgRAEVhQvbsAgAA X-CMS-MailID: 20190405084948eucas1p1a482e6daa4b89cdf261f7bd3a0c8498e X-Msg-Generator: CA X-RootMTR: 20190404172224epcas2p21b449c0ae8e36f7e800ae67c18db35a2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190404172224epcas2p21b449c0ae8e36f7e800ae67c18db35a2 References: <20190404171735.12815-1-s.nawrocki@samsung.com> <20190404171735.12815-2-s.nawrocki@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_014954_241685_C096294A X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , =?UTF-8?Q?Bart=c5=82omiej_=c5=bbo=c5=82nierkiewicz?= , pankaj.dubey@samsung.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Chanwoo Choi , kgene@kernel.org, myungjoo.ham@samsung.com, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/5/19 08:53, Krzysztof Kozlowski wrote: > On Thu, 4 Apr 2019 at 19:22, Sylwester Nawrocki wrote: >> From: Pankaj Dubey >> >> Exynos SoCs have Chipid, for identification of product IDs and SoC >> revisions. This patch intends to provide initialization code for all >> these functionalities, at the same time it provides some sysfs entries >> for accessing these information to user-space. >> Signed-off-by: Pankaj Dubey >> [m.szyprowski: for suggestion and code snippet of product_id_to_soc_id] >> Signed-off-by: Marek Szyprowski >> Signed-off-by: Bartlomiej Zolnierkiewicz > > Toy need to add your SoB here. Will correct that in next iteration. >> diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c >> new file mode 100644 >> index 000000000000..5cb018807817 >> --- /dev/null >> +++ b/drivers/soc/samsung/exynos-chipid.c >> @@ -0,0 +1,111 @@ >> +#include >> +#include >> +#include >> +#include >> +#include > > I commented Bartlomiej's patch which you included here. I did not > receive any further feedback from him so I do not know whether he > agrees with my comments or not... but if you send the same patch again > without addressing these comments, I feel like ignored. > > I stopped on first ignored comment. > > Therefore please address be sure that you addressed my comments from > Bartlomiej's patchset. If you do not agree with them, please let me > know. The comments are here: > https://patchwork.kernel.org/project/linux-samsung-soc/list/?series=43565&state=* I will drop that unneeded header inclusion in next iteration. It was just my oversight, I somehow missed your previous comments. And of course your reviews are appreciated. -- Regards, Sylwester _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel