From: Florian Fainelli <f.fainelli@gmail.com>
To: "André Przywara" <andre.przywara@arm.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node
Date: Wed, 26 Aug 2020 11:59:47 -0700 [thread overview]
Message-ID: <3a3ce1d4-ddd5-f000-9cf0-5d06e2cc2047@gmail.com> (raw)
In-Reply-To: <44992125-7eaa-f35b-3344-16ae0d48f646@arm.com>
On 8/26/20 11:53 AM, André Przywara wrote:
> On 26/08/2020 19:42, Florian Fainelli wrote:
>
> Hi,
>
>> On 8/26/20 11:38 AM, Andre Przywara wrote:
>>> The DT binding for SP804 requires to have an "arm,primecell" compatible
>>> string.
>>> Add this string so that the Linux primecell bus driver picks the device
>>> up and activates the clock.
>>>
>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>
>> The commit subject should be:
>>
>> ARM: dts: NSP: Fix SP804 compatible node
>>
>> and we should probably have a Fixes tag that is:
>>
>> Fixes: a0efb0d28b77 ("ARM: dts: NSP: Add SP804 Support to DT")
>>
>> Could you please re-submit with those things corrected? Thanks
>
> Sure, will include that in a v2.
>
> Out of curiosity, do you have the hardware and can check the impact that
> has?
I have the hardware and could run some tests if you would like.
> Not sure we actually create the device without the primecell compatible?
> Or is the sp804 an exception here, compared to the other AMBA devices
> (SP805, PL011)?
No idea, I have never used those timers personally, and I doubt that
anybody besides me within broadcom and hobbyists actually care about NSP
these days.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-26 19:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 18:37 [PATCH 0/6] dt-bindings: Convert SP804 to Json-schema (and fix users) Andre Przywara
2020-08-26 18:37 ` [PATCH 1/6] dt-bindings: timers: sp-804: Convert to json-schema Andre Przywara
2020-08-26 21:36 ` Rob Herring
2020-08-26 18:38 ` [PATCH 2/6] ARM: dts: arm: Fix SP804 users Andre Przywara
2020-08-28 14:03 ` Linus Walleij
2020-08-28 14:22 ` André Przywara
2020-08-26 18:38 ` [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node Andre Przywara
2020-08-26 18:42 ` Florian Fainelli
2020-08-26 18:53 ` André Przywara
2020-08-26 18:59 ` Florian Fainelli [this message]
2020-08-26 20:55 ` Florian Fainelli
2020-08-28 13:59 ` André Przywara
2020-08-26 21:29 ` Rob Herring
2020-08-26 18:38 ` [PATCH 4/6] ARM: dts: hisilicon: Fix SP804 users Andre Przywara
2020-08-26 18:38 ` [PATCH 5/6] ARM: dts: nspire: " Andre Przywara
2020-08-26 18:38 ` [PATCH 6/6] arm64: dts: lg: " Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a3ce1d4-ddd5-f000-9cf0-5d06e2cc2047@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andre.przywara@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=haojian.zhuang@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox