From: Markus Elfring <Markus.Elfring@web.de>
To: Florian Sylvestre <fsylvestre@baylibre.com>,
Julien Stephan <jstephan@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Paul Elder <paul.elder@ideasonboard.com>,
Phi-bang Nguyen <pnguyen@baylibre.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Andy Hsieh <andy.hsieh@mediatek.com>,
Angelo Gioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv
Date: Tue, 30 Jul 2024 09:46:41 +0200 [thread overview]
Message-ID: <3a764900-12ef-4026-af03-7e8cd2d09b04@web.de> (raw)
In-Reply-To: <20240704-add-mtk-isp-3-0-support-v5-4-bfccccc5ec21@baylibre.com>
…
> +++ b/drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv.h
> @@ -0,0 +1,196 @@
…
> +#ifndef __MTK_CAMSV_H__
> +#define __MTK_CAMSV_H__
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Regards,
Markus
next prev parent reply other threads:[~2024-07-30 7:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 13:36 [PATCH v5 0/5] Add Mediatek ISP3.0 Julien Stephan
2024-07-04 13:36 ` [PATCH v5 1/5] dt-bindings: media: add mediatek ISP3.0 sensor interface Julien Stephan
2024-07-04 16:26 ` Conor Dooley
2024-07-05 7:50 ` Julien Stephan
2024-07-05 9:23 ` Conor Dooley
2024-07-05 9:35 ` Julien Stephan
2024-07-04 13:36 ` [PATCH v5 2/5] dt-bindings: media: add mediatek ISP3.0 camsv Julien Stephan
2024-07-04 16:29 ` Conor Dooley
2024-07-04 22:51 ` Laurent Pinchart
2024-07-04 13:36 ` [PATCH v5 3/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface Julien Stephan
2024-07-18 2:36 ` CK Hu (胡俊光)
2024-07-18 2:44 ` CK Hu (胡俊光)
2024-07-29 12:46 ` Julien Stephan
2024-07-30 2:11 ` CK Hu (胡俊光)
2024-07-04 13:36 ` [PATCH v5 4/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv Julien Stephan
2024-07-18 2:54 ` CK Hu (胡俊光)
2024-07-29 13:40 ` Julien Stephan
2024-07-29 14:14 ` Laurent Pinchart
2024-07-30 2:39 ` CK Hu (胡俊光)
2024-07-18 2:59 ` CK Hu (胡俊光)
2024-07-18 3:26 ` CK Hu (胡俊光)
2024-07-18 3:32 ` CK Hu (胡俊光)
2024-07-30 7:25 ` Markus Elfring
2024-07-30 7:46 ` Markus Elfring [this message]
2024-07-04 13:36 ` [PATCH v5 5/5] arm64: dts: mediatek: mt8365: Add support for camera Julien Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a764900-12ef-4026-af03-7e8cd2d09b04@web.de \
--to=markus.elfring@web.de \
--cc=andy.hsieh@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fsylvestre@baylibre.com \
--cc=jstephan@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=paul.elder@ideasonboard.com \
--cc=pnguyen@baylibre.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox