From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E1CC04AA7 for ; Tue, 14 May 2019 03:30:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1562C21019 for ; Tue, 14 May 2019 03:30:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tJnQ5IQK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CG/hepeT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1562C21019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xi1WgW+sg+fYwKtqVVeU6Tc9Gvu0GrEjWNPremeb8+I=; b=tJnQ5IQK7UEAqfdB8qORGbGiF h4DSAh7CMsmWoUHBWw6bimMU7x35dWXmtZWUou4s2/6DFOPMYw5Qi3t5bpA/3Z0hjEkJN7pabYgQD c8Kt8HaNO0QYAfj9znbYUe5SD3TsUU1NIc2TZ8B8oCdcXY0r9xFFdVJmMjP8qYUDBbQP9QUcApvg2 TzHPS2N79OQCROtel1MqCMO1lfoebF1sTu9WnFRZhe9uT+vJXNeCaGPpriwkPGiXy/A4gcL0lJek2 KlSwGLQtLmqiNN0EqGH3imXVXZQXRIBQidcDAvRE9VQoNsnFgqzZJernttruF1PFt+VRIoJiMRCJa 6g/OVCU2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQO9B-00070C-Ht; Tue, 14 May 2019 03:30:33 +0000 Received: from hqemgate14.nvidia.com ([216.228.121.143]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQO98-0006yx-Q7 for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2019 03:30:32 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 13 May 2019 20:30:35 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 13 May 2019 20:30:28 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 13 May 2019 20:30:28 -0700 Received: from [10.24.47.172] (172.20.13.39) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 14 May 2019 03:30:22 +0000 Subject: Re: [PATCH V6 02/15] PCI/PME: Export pcie_pme_disable_msi() & pcie_pme_no_msi() APIs To: Christoph Hellwig References: <20190513050626.14991-1-vidyas@nvidia.com> <20190513050626.14991-3-vidyas@nvidia.com> <20190513072539.GA27708@infradead.org> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: <3a8cea93-2aeb-e5e2-4d56-f0c6449073c3@nvidia.com> Date: Tue, 14 May 2019 09:00:19 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190513072539.GA27708@infradead.org> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1557804635; bh=WF0v0tqItCQpPYntKi+aRXw99fOxbVxnrACwlglFS0M=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=CG/hepeT0PKprItd4aVLx0siRKGoqBQsVPtZB9n0+z3wKU/rBtSo7sUzqyrb5q6iw 20TBFHmDxZX/RK8u8iUDNYLnfx74+YmrrQ/gCL4EkiTDdaaVFSHjqNhR0leppyUeTB ChSatjDwvyeWU/kZOVfMBXjsWOUXESuOmghAzkEPZoBNkTBaF1iQpV0Kj10V2cZA2I EtXRmv/zTm2fa5APR7T2TPAQnDgfaV5lPPj9tI6Jeb8dHWbVTRgHGAIDWSdUP051FE W+WvGWMI4/xdAWzkTHiS5Ftamt2ooSjaPGDD8W6OdZSzbkXID0FlK8AnD/mtizScL8 cwz8vpu2Aoprw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_203030_863741_A86EBF6F X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, mperttunen@nvidia.com, mmaddireddy@nvidia.com, linux-pci@vger.kernel.org, catalin.marinas@arm.com, kthota@nvidia.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, thierry.reding@gmail.com, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, kishon@ti.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/13/2019 12:55 PM, Christoph Hellwig wrote: > On Mon, May 13, 2019 at 10:36:13AM +0530, Vidya Sagar wrote: >> Export pcie_pme_disable_msi() & pcie_pme_no_msi() APIs to enable drivers >> using these APIs be able to build as loadable modules. > > But this is a global setting. If you root port is broken you need > a per-rootport quirk instead. > There is nothing broken in Tegra194 root port as such, rather, this is more of software configuration choice and we are going with legacy interrupts than MSI interrupts (as Tegra194 doesn't support raising PME interrupts through MSI and please note that this doesn't mean root port is broken). Since Tegra194 has only Synopsys DesignWare core based host controllers and not any other hosts, I think it is fine to call this API in driver. Also, since this is a global setting, calling this APIs from anywhere (be it from quirk or from driver) would have the same effect, or did I miss anything here? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel