From: Baolu Lu <baolu.lu@linux.intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com
Cc: suravee.suthikulpanit@amd.com, will@kernel.org,
robin.murphy@arm.com, sven@kernel.org, j@jannau.net,
robin.clark@oss.qualcomm.com, m.szyprowski@samsung.com,
krzk@kernel.org, dwmw2@infradead.org, yong.wu@mediatek.com,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
tjeznach@rivosinc.com, pjw@kernel.org, palmer@dabbelt.com,
aou@eecs.berkeley.edu, heiko@sntech.de, schnelle@linux.ibm.com,
mjrosato@linux.ibm.com, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
jean-philippe@linaro.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
virtualization@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH v2 6/6] iommu: Pass in old domain to attach_dev callback functions
Date: Thu, 23 Oct 2025 12:58:18 +0800 [thread overview]
Message-ID: <3a9698ac-ac50-499f-871c-ee44d7371815@linux.intel.com> (raw)
In-Reply-To: <7f760e795097e3052da82abf410c6ee963e4c62b.1761017765.git.nicolinc@nvidia.com>
On 10/23/25 10:21, Nicolin Chen wrote:
> The IOMMU core attaches each device to a default domain on probe(). Then,
> every new "attach" operation has a fundamental meaning of two-fold:
> - detach from its currently attached (old) domain
> - attach to a given new domain
>
> Modern IOMMU drivers following this pattern usually want to clean up the
> things related to the old domain, so they call iommu_get_domain_for_dev()
> to fetch the old domain.
>
> Pass in the old domain pointer from the core to drivers, aligning with the
> set_dev_pasid op that does so already.
>
> Ensure all low-level attach fcuntions in the core can forward the correct
> old domain pointer. Thus, rework those functions as well.
>
> Suggested-by: Jason Gunthorpe<jgg@nvidia.com>
> Reviewed-by: Kevin Tian<kevin.tian@intel.com>
> Reviewed-by: Jason Gunthorpe<jgg@nvidia.com>
> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
> ---
> include/linux/iommu.h | 3 ++-
> arch/powerpc/kernel/iommu.c | 5 ++--
> drivers/iommu/amd/iommu.c | 11 ++++----
> drivers/iommu/apple-dart.c | 9 ++++---
> .../arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 5 ++--
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 24 +++++++++++-------
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 9 ++++---
> drivers/iommu/arm/arm-smmu/qcom_iommu.c | 11 ++++----
> drivers/iommu/exynos-iommu.c | 8 +++---
> drivers/iommu/fsl_pamu_domain.c | 12 ++++-----
> drivers/iommu/intel/iommu.c | 10 +++++---
> drivers/iommu/intel/nested.c | 2 +-
> drivers/iommu/iommu.c | 25 +++++++++++--------
> drivers/iommu/iommufd/selftest.c | 2 +-
> drivers/iommu/ipmmu-vmsa.c | 10 ++++----
> drivers/iommu/msm_iommu.c | 11 ++++----
> drivers/iommu/mtk_iommu.c | 8 +++---
> drivers/iommu/mtk_iommu_v1.c | 7 ++++--
> drivers/iommu/omap-iommu.c | 12 ++++-----
> drivers/iommu/riscv/iommu.c | 9 ++++---
> drivers/iommu/rockchip-iommu.c | 20 +++++++++++----
> drivers/iommu/s390-iommu.c | 13 ++++++----
> drivers/iommu/sprd-iommu.c | 3 ++-
> drivers/iommu/sun50i-iommu.c | 8 +++---
> drivers/iommu/tegra-smmu.c | 10 ++++----
> drivers/iommu/virtio-iommu.c | 6 +++--
> 26 files changed, 153 insertions(+), 100 deletions(-)
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
next prev parent reply other threads:[~2025-10-23 5:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 2:21 [PATCH v2 0/6] iommu: Pass in old_domain pointer to attach_dev Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 1/6] iommu: Generic support for RMRs during device release Nicolin Chen
2025-10-23 4:43 ` Baolu Lu
2025-10-23 2:21 ` [PATCH v2 2/6] iommu/arm-smmu-v3: Set release_domain to arm_smmu_blocked_domain Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 3/6] iommu/exynos-iommu: Set release_domain to exynos_identity_domain Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 4/6] iommu/amd: Set release_domain to blocked_domain Nicolin Chen
2025-10-23 2:21 ` [PATCH v2 5/6] iommu: Do not revert set_domain for the last gdev Nicolin Chen
2025-10-23 4:50 ` Baolu Lu
2025-10-23 2:21 ` [PATCH v2 6/6] iommu: Pass in old domain to attach_dev callback functions Nicolin Chen
2025-10-23 4:58 ` Baolu Lu [this message]
2025-10-27 12:55 ` [PATCH v2 0/6] iommu: Pass in old_domain pointer to attach_dev Jörg Rödel
2025-12-19 8:10 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a9698ac-ac50-499f-871c-ee44d7371815@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=dwmw2@infradead.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=jean-philippe@linaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=jgg@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=palmer@dabbelt.com \
--cc=patches@lists.linux.dev \
--cc=pjw@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=schnelle@linux.ibm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tjeznach@rivosinc.com \
--cc=virtualization@lists.linux.dev \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).