From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27888C64ED6 for ; Mon, 27 Feb 2023 08:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xBB15968XFeGaLmzuy02gC+VvMG4qGuwnapzSaF42B4=; b=y2GNo36lPhXqcZ nhe8usWCvqzoyaRWtvnqmnOU313S/6RdLdyiStEY3h5g5hdRHhjB86dQKJK0Y2r6EgAiJCrUvA/sd vzK9+Tyxtyat7EbK4ddpzSQA5UckdIlYRrTB8yseEwTQM7z26RD3R4Imn1w49OjxgUp34u7vHafaG dslQUq/vOMZHHYAwuW/sg5hKvrX9GFsX0zqLzd6hYDnV1Ow+lCYWybovANhekd7UTa7rGGNLXefZG cn2cUnTcDzrFom5+ZJDDCanUp99254jpjPXMEkkzNO/cl1CtIXzBwAXJXdI43VsI49fXwMNTzBnmv tsy29eHh9t1weZWNUKsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWZ6T-008tY2-0P; Mon, 27 Feb 2023 08:43:25 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWZ6O-008tWp-Qt for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 08:43:22 +0000 Received: by mail-lj1-x22e.google.com with SMTP id h3so5558418lja.12 for ; Mon, 27 Feb 2023 00:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677487397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pl3dkRXMmAk1JBFimIqhpxnC6XsfsDXMDQ44PxTCQ/s=; b=DtxNJ6ePjQ/i4m/NMWNDtDHj6jb+VPPrSwrShpD9ysYFk+mdEp1ayrEGACcGBLYzkV 2jyWy+BksOm5xtg2FTLlj5vcPRD1W4cN95un71DyKs7L+FilsP2x7WPsJBDkjJWhpKdC F3qbguO2fGdC/e4BRKHSRed36QUraJsMFex/pvrMCTpZY2J7ZIV+Jc4d5JWdpuyVMk5p b+z1PXXCw0DM3G9Ispl81es5iGClOZHsO1BQizMXge71LOCI7C/tySGssjGHEMls/L5m Epi/B0lFr91Ei45CM/egghyOdHb2H9gFn1r7DSbJQwyz47+qDOT2fGW8+EpflibkZt3F 5Huw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677487397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pl3dkRXMmAk1JBFimIqhpxnC6XsfsDXMDQ44PxTCQ/s=; b=wU7nIH34Xouq2QT99rsy8AIav4c0IKQxd/4KsniumQMySrj06y0uwnAUv+rRSClAmh TK+3iYMtq8C2hpwErwWRm/HVR4WQ/x2OWmqwFIgth1IpG2JROBGs2CcC78qcTLFkpf+Q 9Qtrvh2s9bHDBrDUyMg0b6lrJNNn4xjgPNvnDZSEogRzCQ0i4ed6J5T9xznakwUbLGDr +Dyz74w/42mseiS099ujch8rHcaDG+ephuLJo+MKKeD+CSPerwEHNn4JFvB64qB6KBzi fT0hGJRxQRrH4ZU0EfKOio1Pr7mRLT+p0uTKXPMUqGa1YkBZPs93PBi5R059ztsI+mx7 Jo5A== X-Gm-Message-State: AO0yUKUSdSiDLkUXkLaWNizAiupkOcgdeVqEMlsGEdyLDD3DmRb+8dFe uPUR4nwc+6h1Qydg2Jro4XCFvQ== X-Google-Smtp-Source: AK7set/Gvtsf5P7zOB+MC4cBLFFsUoGA6x+8HxOLVIaK3IY1MS+lDHx3oVzZik2heawiFH8nJ7qjMg== X-Received: by 2002:a05:651c:2228:b0:295:9c2e:7324 with SMTP id y40-20020a05651c222800b002959c2e7324mr7173325ljq.4.1677487397220; Mon, 27 Feb 2023 00:43:17 -0800 (PST) Received: from [192.168.1.101] (abym99.neoplus.adsl.tpnet.pl. [83.9.32.99]) by smtp.gmail.com with ESMTPSA id i2-20020a05651c120200b002935305ff4asm643079lja.82.2023.02.27.00.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 00:43:16 -0800 (PST) Message-ID: <3aa78b15-8e6c-9657-0d08-0d0452d51fbe@linaro.org> Date: Mon, 27 Feb 2023 09:43:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/6] dt-bindings: arm-smmu: Use qcom,smmu compatible for MMU500 adreno SMMUs To: Rob Herring Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, marijn.suijten@somainline.org, Will Deacon , Robin Murphy , Joerg Roedel , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230217111613.306978-1-konrad.dybcio@linaro.org> <20230226173706.GA60188-robh@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20230226173706.GA60188-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_004320_903851_227BF973 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26.02.2023 18:37, Rob Herring wrote: > On Fri, Feb 17, 2023 at 12:16:08PM +0100, Konrad Dybcio wrote: >> qcom,smmu-500 was introduced to prevent people from adding new >> compatibles for what seems to roughly be the same hardware. Use it for >> qcom,adreno-smmu-compatible targets as well. >> >> Signed-off-by: Konrad Dybcio >> --- >> v1 -> v2: >> - Add this patch, omitted previously (big oops) >> >> .../devicetree/bindings/iommu/arm,smmu.yaml | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 807cb511fe18..4d7f61700cae 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -75,9 +75,19 @@ properties: >> - qcom,sm8350-smmu-500 >> - qcom,sm8450-smmu-500 >> - const: arm,mmu-500 >> - >> - - description: Qcom Adreno GPUs implementing "arm,smmu-500" >> + - description: Qcom Adreno GPUs implementing "qcom,smmu-500" and "arm,smmu-500" >> + items: >> + - enum: >> + - qcom,sc7280-smmu-500 >> + - qcom,sm8150-smmu-500 >> + - qcom,sm8250-smmu-500 >> + - const: qcom,adreno-smmu >> + - const: qcom,smmu-500 >> + - const: arm,mmu-500 > > 4 compatibles seems excessive. Is adding one that helpful? Is > 'arm,mmu-500' useful on its own? Yes. per-soc compatible is there for per-soc quirks should there be any qcom,adreno-smmu enabled per-process pagetables qcom,smmu-500 matches the qcom smmu implementation arm,mmu-500 matches the smmu driver as a whole > >> + - description: Qcom Adreno GPUs implementing "arm,smmu-500" (legacy binding) > > Perhaps fix the existing typo: arm,mmu-500 Ack Konrad > >> + deprecated: true >> items: >> + # Do not add additional SoC to this list. Instead use previous list. >> - enum: >> - qcom,sc7280-smmu-500 >> - qcom,sm8150-smmu-500 >> -- >> 2.39.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel