From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3957C433ED for ; Tue, 13 Apr 2021 01:10:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E67A61074 for ; Tue, 13 Apr 2021 01:10:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E67A61074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cnVdHxqhTQBHSVZtVWxg//7CXfZuq6J25hghGWfzBdk=; b=Bmb+E5MKk1x5yfP0REUiTN+TK P3l9bCMWytJgEZKFiLf5l7g275gVVlbs0StjaqFiz3XSc8nitUuZV3vQxrzLXv2V3H/i4fSMwwEv8 TXANXr04AivAJenyossSXxw75DAQ7epa/XHE7XyCeTtotdIXeKkvE2WDovJJqW/9CIA+jPC/7oNCm 5Vgu4ZYc312DSzmBEkOEnFr57h+rzjPwedU5zhj0p5UjVeO6EPI+SmYyAtTpf3PrFo1nnkCTCIix3 Z4Z6YWpXvH6JpIAqb+KCQmiOOzUIAE2vUTTknHkjbv05bix//EEAXFh1HIMXOS9Hy5M9aYgQebeRr HuX8Nelyw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW7Xa-008025-Hq; Tue, 13 Apr 2021 01:08:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW7XX-00801r-RU for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 01:08:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=MChjTrtXMCDZxHelPI6+QWPr0E1AafjH8DN31qXvb3E=; b=XYDBIQFRJqWJ/hA+gv8aJ+9DrG 0ys45EWzpntBqR1X9v2FH09IxgHeE2BcJ2+fa+iF1VXRu97XB+n64q1bi1reQ/PNwbniGMUNfPXpa 5UeZUJU12bV8Hkli2nsjQ4B6wtIYGdSolKfiafNI6ARXKo14VQS1gik9bEO3DEJFpMf7W3ZORPZqt fqaWq45xjmX10nsU+nkPqCftUvqSuBifgMO8Evuor6ReiGwM1fo0BKFUFzREZ6wN6g574/9swEzbu eb92buvJwnRxBwVSceVk2mWsleU4cVACz4VXgKRaonujYj+yOXkIQ36ImLFarCtqEJBrOn0kVyaee hixsxZcQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW7XU-006fHG-Nl for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 01:08:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7EB5106F; Mon, 12 Apr 2021 18:08:16 -0700 (PDT) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB2793F792; Mon, 12 Apr 2021 18:08:11 -0700 (PDT) Subject: Re: [PATCH V2 4/6] mm: Drop redundant ARCH_ENABLE_[HUGEPAGE|THP]_MIGRATION To: Oscar Salvador Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org References: <1617259448-22529-1-git-send-email-anshuman.khandual@arm.com> <1617259448-22529-5-git-send-email-anshuman.khandual@arm.com> <20210412115952.GC27818@linux> From: Anshuman Khandual Message-ID: <3ae8627b-68dc-8a86-fbf0-5e65e25ebffb@arm.com> Date: Tue, 13 Apr 2021 06:38:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210412115952.GC27818@linux> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_180824_829681_D61AD9C7 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/12/21 5:29 PM, Oscar Salvador wrote: > On Thu, Apr 01, 2021 at 12:14:06PM +0530, Anshuman Khandual wrote: >> ARCH_ENABLE_[HUGEPAGE|THP]_MIGRATION configs have duplicate definitions on >> platforms that subscribe them. Drop these reduntant definitions and instead >> just select them appropriately. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Michael Ellerman >> Cc: Benjamin Herrenschmidt >> Cc: Paul Mackerras >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: "H. Peter Anvin" >> Cc: Andrew Morton >> Cc: x86@kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Acked-by: Catalin Marinas (arm64) >> Signed-off-by: Anshuman Khandual > > Hi Anshuman, > > X86 needs fixing, see below: > >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index 503d8b2e8676..10702ef1eb57 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -60,8 +60,10 @@ config X86 >> select ACPI_SYSTEM_POWER_STATES_SUPPORT if ACPI >> select ARCH_32BIT_OFF_T if X86_32 >> select ARCH_CLOCKSOURCE_INIT >> + select ARCH_ENABLE_HUGEPAGE_MIGRATION if x86_64 && HUGETLB_PAGE && MIGRATION >> select ARCH_ENABLE_MEMORY_HOTPLUG if X86_64 || (X86_32 && HIGHMEM) >> select ARCH_ENABLE_MEMORY_HOTREMOVE if MEMORY_HOTPLUG >> + select ARCH_ENABLE_THP_MIGRATION if x86_64 && TRANSPARENT_HUGEPAGE > > you need s/x86_64/X86_64/, otherwise we are left with no migration :-) Ahh, right. I guess this could not have got detected during a build test. As the series is in mmotm tree, wondering if Andrew could help fix these typos in this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel