From: chenyu56@huawei.com (Chen Yu)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960
Date: Tue, 24 Oct 2017 18:41:02 +0800 [thread overview]
Message-ID: <3afa825f-f851-e7df-bfa0-db5daa5d31fd@huawei.com> (raw)
In-Reply-To: <bbf80ebf-13c6-b589-6b38-6b09ce4119bb@huawei.com>
Hi, Felipe
On 2017/10/24 16:25, Felipe Balbi wrote:
> Hi,
>
> Yu Chen <chenyu56@huawei.com> writes:
>> > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 Controller.
>> > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on board Hikey960.
>> >
>> > Signed-off-by: Yu Chen
> <chenyu56@huawei.com>
> > Signed-off-by: Ning Fan <fanning4@hisilicon.com>
> > Signed-off-by: Di Yang <yangdi10@hisilicon.com>
> > Signed-off-by: Rui Li <lirui39@hisilicon.com>
> I think Linaro, recently, added support for chargers to mainline. You
> should use what they did.
>
> I'm gonna stop here. There's no way I'm going through this much code in
> a single patch. Specially since 90% of it is either completely
> unnecessary or should be done using already-existing generic APIs.
>
> Sorry, no cookie today.
Thanks a lot for your comments!
These codes have been tested on Hikey960 board and work well. But indeed the codes can be simplified and
made comply with already-existing architecture.
We will work on these codes according to your reviews and make parted patch next time.
Thanks,
Yu Chen
prev parent reply other threads:[~2017-10-24 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 6:06 [RFC 0/3] USB: Modify dwc3 code for support Hikey960 Yu Chen
2017-10-24 6:06 ` [RFC 1/3] USB: Add document for usb of Hikey960 Yu Chen
2017-10-27 3:47 ` Rob Herring
2017-10-24 6:06 ` [RFC 3/3] arm64: dts: Modify device tree for support Hikey960 Yu Chen
[not found] ` <20171024060610.10712-3-chenyu56@huawei.com>
2017-10-24 8:25 ` [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960 Felipe Balbi
[not found] ` <bbf80ebf-13c6-b589-6b38-6b09ce4119bb@huawei.com>
2017-10-24 10:41 ` Chen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3afa825f-f851-e7df-bfa0-db5daa5d31fd@huawei.com \
--to=chenyu56@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).