From mboxrd@z Thu Jan 1 00:00:00 1970 From: chenyu56@huawei.com (Chen Yu) Date: Tue, 24 Oct 2017 18:41:02 +0800 Subject: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960 In-Reply-To: References: <20171024060610.10712-1-chenyu56@huawei.com> <20171024060610.10712-3-chenyu56@huawei.com> <87a80hgdgf.fsf@linux.intel.com> Message-ID: <3afa825f-f851-e7df-bfa0-db5daa5d31fd@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Felipe On 2017/10/24 16:25, Felipe Balbi wrote: > Hi, > > Yu Chen writes: >> > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 Controller. >> > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on board Hikey960. >> > >> > Signed-off-by: Yu Chen > > > Signed-off-by: Ning Fan > > Signed-off-by: Di Yang > > Signed-off-by: Rui Li > I think Linaro, recently, added support for chargers to mainline. You > should use what they did. > > I'm gonna stop here. There's no way I'm going through this much code in > a single patch. Specially since 90% of it is either completely > unnecessary or should be done using already-existing generic APIs. > > Sorry, no cookie today. Thanks a lot for your comments! These codes have been tested on Hikey960 board and work well. But indeed the codes can be simplified and made comply with already-existing architecture. We will work on these codes according to your reviews and make parted patch next time. Thanks, Yu Chen