From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1939BC433DB for ; Tue, 22 Dec 2020 19:28:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBCB423130 for ; Tue, 22 Dec 2020 19:28:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBCB423130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V0Cs2T1HEAJ5A6hNp0bIMYqKg9mSTpYjRZLyS0lw6uU=; b=yHVRPMz8cZ5dOFcGtoAOQrjLv Jtf/cHS5CaoiWMEwVADrE8ThDzbVlI+qSnvjzTaoFuzkBUYs31Q9pNoJPcdIMdc24Bj6dpXg59D9F tgQuISw6dSe2EsrewaWgt5DkV7c38b/TEGN+p14ZE1QscF0DlQkGOUApevvhIFaoXFSeRGmkpda/7 v1wSOYXuQdZqtCmgdYR6qb0o657h8ORxmtzwTv/xwA77bx2eUtGVJ9RaU8dWz64GJpRefOFfgUupo 8srZ6+9nbdPGtJxYhJHm3Kkv8zhpRnmf7N5GMfta1yQBsSNYdRO235C8zw66wzgd5diwNrk0Yf3lY IMjj/bXuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krnJj-0000Bu-Ll; Tue, 22 Dec 2020 19:27:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krnJg-0000Ai-Li for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 19:27:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C19081FB; Tue, 22 Dec 2020 11:27:22 -0800 (PST) Received: from [10.57.34.90] (unknown [10.57.34.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D97A93F6CF; Tue, 22 Dec 2020 11:27:20 -0800 (PST) Subject: Re: [PATCH v2 3/7] iommu/arm-smmu: Add dependency on io-pgtable format modules To: "Isaac J. Manjarres" , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org References: <1608597876-32367-1-git-send-email-isaacm@codeaurora.org> <1608597876-32367-4-git-send-email-isaacm@codeaurora.org> From: Robin Murphy Message-ID: <3b0c191d-3fd0-73db-c1e3-4a80aa7953d7@arm.com> Date: Tue, 22 Dec 2020 19:27:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1608597876-32367-4-git-send-email-isaacm@codeaurora.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_142728_795471_3690EBDC X-CRM114-Status: GOOD ( 19.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pratikp@codeaurora.org, joro@8bytes.org, kernel-team@android.com, will@kernel.org, pdaly@codeaurora.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-12-22 00:44, Isaac J. Manjarres wrote: > The SMMU driver depends on the availability of the ARM LPAE and > ARM V7S io-pgtable format code to work properly. In preparation Nit: we don't really depend on v7s - we *can* use it if it's available, address constraints are suitable, and the SMMU implementation actually supports it (many don't), but we can still quite happily not use it even so. LPAE is mandatory in the architecture so that's our only hard requirement, embodied in the kconfig select. This does mean there may technically still be a corner case involving ARM_SMMU=y and IO_PGTABLE_ARM_V7S=m, but at worst it's now a runtime failure rather than a build error, so unless and until anyone demonstrates that it actually matters I don't feel particularly inclined to give it much thought. Robin. > for having the io-pgtable formats as modules, add a "pre" > dependency with MODULE_SOFTDEP() to ensure that the io-pgtable > format modules are loaded before loading the ARM SMMU driver module. > > Signed-off-by: Isaac J. Manjarres > --- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c > index d8c6bfd..a72649f 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c > @@ -2351,3 +2351,4 @@ MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); > MODULE_AUTHOR("Will Deacon "); > MODULE_ALIAS("platform:arm-smmu"); > MODULE_LICENSE("GPL v2"); > +MODULE_SOFTDEP("pre: io-pgtable-arm io-pgtable-arm-v7s"); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel