From: pierre-yves.mordret@st.com (Pierre Yves MORDRET)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] i2c:i2c-stm32f7: fix setup structure
Date: Fri, 6 Oct 2017 09:53:23 +0200 [thread overview]
Message-ID: <3b0e9bd4-298f-3ec9-7560-9758a8198e27@st.com> (raw)
In-Reply-To: <20171005111444.77qib2ddnz4jmbnr@ninjato>
On 10/05/2017 01:14 PM, Wolfram Sang wrote:
> On Thu, Sep 21, 2017 at 03:30:09PM +0200, Pierre-Yves MORDRET wrote:
>> I2C drive setup structure is not properly allocated.
>> Make it static instead of pointer to store driver data.
>>
>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
>
> Ouch! How did it work before?
Well yes it did. When it has been discovered during internal code review I was
skeptical but it turned out to be true. I tested on STM32 F7/H7 without any
trouble : scary !
>
> Applied to for-current, thanks! Please provide a Fixes: tag next time,
> did this for you now.
>
Sorry I wasn't aware about that. I gonna remember for the next time.
Thanks !
Py
prev parent reply other threads:[~2017-10-06 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 13:30 [PATCH v1] i2c:i2c-stm32f7: fix setup structure Pierre-Yves MORDRET
2017-10-05 11:14 ` Wolfram Sang
2017-10-06 7:53 ` Pierre Yves MORDRET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b0e9bd4-298f-3ec9-7560-9758a8198e27@st.com \
--to=pierre-yves.mordret@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox