From: Yureka Lilian <yureka@cyberchaos.dev>
To: Sven Peter <sven@kernel.org>,
Yureka Lilian <yureka@cyberchaos.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
Hector Martin <marcan@marcan.st>,
Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: arm: apple: apple,pmgr: Add t8140 compatible
Date: Fri, 4 Sep 2026 22:54:50 +0200 [thread overview]
Message-ID: <3b46906d-8008-429c-a37a-f64ec72f865e@cyberchaos.dev> (raw)
In-Reply-To: <f73a94c4-80a7-41b0-9671-d9b6ea436174@kernel.org>
On 9/4/26 22:30, Sven Peter wrote:
> On 04.09.26 21:49, Yureka Lilian wrote:
>> The PMGR blocks on the Apple silicon A18 Pro SoC (t8140) is compatible
>> with the M1-M4 SoCs. Add "apple,t8140-pmgr" as A18 Pro specific
>> compatible.
>>
>> Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
>> ---
>> Documentation/devicetree/bindings/arm/apple.yaml | 11
>> +++++++++++
>> Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml | 1 +
>
> There's something off with this commit, it's doing two things at once
> and the description only mentions the smaller change.
>
> Sven
Good catch! I must have added one hunk too much while committing the
change. Fixed locally / for v2.
Thanks,
- Yureka
next prev parent reply other threads:[~2026-09-04 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 19:49 [PATCH 0/6] Initial Apple Silicon A18 Pro device trees and dt-bindings Yureka Lilian
2026-09-04 19:49 ` [PATCH 1/6] dt-bindings: arm: cpus: Add Apple A18 Pro CPU core compatibles Yureka Lilian
2026-09-04 19:49 ` [PATCH 2/6] dt-bindings: arm: apple: apple,pmgr: Add t8140 compatible Yureka Lilian
2026-09-04 20:30 ` Sven Peter
2026-09-04 20:54 ` Yureka Lilian [this message]
2026-09-04 19:49 ` [PATCH 3/6] dt-bindings: arm: power: apple,pmgr-pwrstate: " Yureka Lilian
2026-09-04 19:49 ` [PATCH 4/6] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8140 compatible Yureka Lilian
2026-09-05 8:25 ` Nick Chan
2026-09-04 19:49 ` [PATCH 5/6] dt-bindings: watchdog: apple,wdt: Add t8140 compatible Yureka Lilian
2026-09-04 19:49 ` [PATCH 6/6] arm64: dts: apple: Add minimal MacBook Neo device tree Yureka Lilian
2026-09-04 20:34 ` Sven Peter
2026-09-04 20:57 ` Yureka Lilian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b46906d-8008-429c-a37a-f64ec72f865e@cyberchaos.dev \
--to=yureka@cyberchaos.dev \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpieralisi@kernel.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=radu@rendec.net \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
--cc=tglx@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox