From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 786C4EB64DC for ; Fri, 21 Jul 2023 07:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b2wnCFVE+H01xjP/l/wo5kHvP/nlOmUqWKCiWEsqwL0=; b=lcpWAQDfFPapB8 i8PtYpN6qfyuwk6LaMtaf6TS0Y2zOaTdwec1WUY96pLy6mo/DOVyUkyM62bs/IeChE4mZREjvx1xo z6WZ07UPEFXhs9VaEk4MF7uk5+TxxwBfbaxrwPKoVNADsNV++Funff0vhX3RrWI8K4bUbgEYh89gz 77A3nazJYA5EO1IvmFKNJN2h/jFHFxggvnzoTvoq5K5RHe4Aet4gf/2dYfET/SvwlQfdO+jb8thxT 0nzp22me1zOzuuiTupYhpOEGqOe79/vHg4n8xN8Pb3vNDZ+edKCwKMdwNPyGGcDjtrhYWeb2Lc7FY UzDDprJy2BUrNcjsUVlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMkxY-00DFoU-2A; Fri, 21 Jul 2023 07:53:56 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMkxV-00DFmm-0J for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 07:53:54 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51e28b299adso2294982a12.2 for ; Fri, 21 Jul 2023 00:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689926029; x=1690530829; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tEygh4c+HqxN74BgXq8Y1kfIxuqyz4efWO8eqzPzYks=; b=fBac3ap+iIZ5MwFfu4qTR52LVb+3L+GbxZS0jhoKvit/O6n/nYU3TPOvCqdwNED9Wz gdAkwg2LmQnSVQ/QZpThBvWEUcXJIXRvino9kzIMnKUTiueyURedoc1fOHY3BO0w9IAe IpaMr5bpoAU7PHMsaotH6zob4ogrhipQ4eyWqSLFDzIZK4EIBor0eXOxyo6D+fjzu8s1 PWdZhL2EVedkIxK/NXUc2JxvU4nGs09tjp8ZpJMeYdjGhgzq2ZyutKqp75UUIkm/lj0z yZo63VySV5QE0UyZXQCDcyshPMTMJOgSqesclet8ZKgwi2AhYAuPeEDo/ecwCEhjP83Q y9EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689926029; x=1690530829; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tEygh4c+HqxN74BgXq8Y1kfIxuqyz4efWO8eqzPzYks=; b=l4CBnCI+2CrmU6tSOvfb8cAtcR38idShCy8GnV0x2FVnSWDnzsxC4Vz51KqlYME+q0 bRptZKPgSTj4Yc+/lQ5s7vmmpu32pjZ343sqbVEWE7iGOKkFWl1XB5+vCGzQ7KR31/R9 vTVcycvUMt3UllG3/I2CYfHkExtmsy7qdrRDR+l32W3/z/VxdhxYSliFXs5pLRLGN+S2 RJJ53aFK2ScLZPU+vAKWngYbQRc422R8+ZSPsqLaCOo1fmD535JmRUtxfqqCdqQZIkar Omur9DfMOSSySWWjWVoREDnvActmLDRvMqX3Q37OFBIrwZlutM9D1XTpwWm/TTzwhks6 x1LA== X-Gm-Message-State: ABy/qLaNV/PNJNn1+TKo+iM8VHA3slo90IG6gfHacL3a0mM5f9/xEvQe kGZbddVfw3MkcrOjuV1rytni1w== X-Google-Smtp-Source: APBJJlG70ubi7PfFJ83R0SjvKKHGbb3LLJDfj8I88GeD6ZT48ozVs6lSrCK3Pq8XKEvVEn6OlGguEA== X-Received: by 2002:a05:6402:549:b0:51e:ebd:9f5b with SMTP id i9-20020a056402054900b0051e0ebd9f5bmr1000093edx.36.1689926028989; Fri, 21 Jul 2023 00:53:48 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id s11-20020aa7cb0b000000b0051def9be785sm1741132edt.85.2023.07.21.00.53.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 00:53:48 -0700 (PDT) Message-ID: <3b4eaf27-5e6e-f3d0-24fa-01d5c059c2f5@linaro.org> Date: Fri, 21 Jul 2023 09:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 4/4] ARM: dts: imx6q: Add Variscite MX6 Custom board support Content-Language: en-US To: James Hilliard , devicetree@vger.kernel.org Cc: Gregory CLEMENT , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marek Vasut , Frieder Schrempf , Stefan Wahren , Philippe Schenker , =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= , Marcel Ziswiler , Christoph Niedermaier , Li Yang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230721073626.3673429-1-james.hilliard1@gmail.com> <20230721073626.3673429-4-james.hilliard1@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230721073626.3673429-4-james.hilliard1@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_005353_143182_6509CFBA X-CRM114-Status: GOOD ( 22.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/07/2023 09:36, James Hilliard wrote: > This patch adds support for the Variscite MX6 SoM Carrier Board. > > This Carrier-Board has the following : > - LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display > - HDMI Connector > - USB Host + USB OTG Connector > - 10/100/1000 Mbps Ethernet > - miniPCI-Express slot > - SD Card connector > - Audio Headphone/Line In jack connectors > - S-ATA > - On-board DMIC > - RS485 Header > - CAN bus header > - SPI header > - Camera Interfaces header > - OnBoard RTC with Coin Backup battery socket > - RS232 Debug Header (IDC10) > - RS232 DTE > > Product Page : https://www.variscite.com/product/single-board-computers/var-mx6customboard > > The dts file based on the ones provided by Variscite on their own > kernel, but adapted for mainline. > > Signed-off-by: Gregory CLEMENT > Signed-off-by: James Hilliard > --- > arch/arm/boot/dts/nxp/imx/Makefile | 1 + > .../dts/nxp/imx/imx6q-var-mx6customboard.dts | 280 ++++++++++++++++++ > 2 files changed, 281 insertions(+) > create mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-var-mx6customboard.dts > > diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile > index 3629e343d322..258ec0e5b712 100644 > --- a/arch/arm/boot/dts/nxp/imx/Makefile > +++ b/arch/arm/boot/dts/nxp/imx/Makefile > @@ -244,6 +244,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > imx6q-udoo.dtb \ > imx6q-utilite-pro.dtb \ > imx6q-var-dt6customboard.dtb \ > + imx6q-var-mx6customboard.dtb \ > imx6q-vicut1.dtb \ > imx6q-wandboard.dtb \ > imx6q-wandboard-revb1.dtb \ > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-var-mx6customboard.dts b/arch/arm/boot/dts/nxp/imx/imx6q-var-mx6customboard.dts > new file mode 100644 > index 000000000000..3ca3662fd0d3 > --- /dev/null > +++ b/arch/arm/boot/dts/nxp/imx/imx6q-var-mx6customboard.dts > @@ -0,0 +1,280 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Support for Variscite MX6 Carrier-board > + * > + * Copyright 2016 Variscite, Ltd. All Rights Reserved > + * Copyright 2022 Bootlin > + */ > + > +/dts-v1/; > + > +#include "imx6qdl-var-som.dtsi" > +#include > + > +/ { > + model = "Variscite i.MX6 QUAD/DUAL VAR-SOM-MX6 Custom Board"; > + compatible = "variscite,mx6customboard", "variscite,var-som-imx6q", "fsl,imx6q"; This is not what you said in the bindings. And you did not test it. It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel