From: "Zhao Gongyi" <zhaogongyi@bytedance.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
"Ryan Roberts" <Ryan.Roberts@arm.com>
Cc: <dev.jain@arm.com>, <baolin.wang@linux.alibaba.com>,
<lance.yang@linux.dev>, <mark.rutland@arm.com>,
<akpm@linux-foundation.org>, <ljs@kernel.org>,
<liam@infradead.org>, <vbabka@kernel.org>, <rppt@kernel.org>,
<surenb@google.com>, <mhocko@suse.com>,
<linux-arm-kernel@lists.infradead.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] arm64/mm: restrict transparent contpte mappings to valid PTEs
Date: Sun, 25 Oct 2026 00:00:33 +0800 [thread overview]
Message-ID: <3b57c214-6a43-4fc7-a531-fb5eac196465@bytedance.com> (raw)
In-Reply-To: <cc2e3af6-bb56-41b1-9cde-151797c3068d@kernel.org>
On 10/24/26 4:55 AM, David Hildenbrand (Arm) wrote:
>
> Hi,
>
> sorry for the late reply.
>
> If we have the spare PTE bit, why shouldn't we just use it?
>
> It will make batching over PTEs faster. And we care about that for present PTEs.
>
> So I don't quite see why the stable fix couldn't just do it right away? Do you
> have a prototype that shows that it would require significant code changes?
>
Hi David,
I tried a small prototype that keeps PTE_CONT on present-invalid PTEs.
It leaves contpte_set_ptes() unchanged and makes contpte_try_unfold()
recognize pte_present(pte) && pte_cont(pte), instead of checking only
pte_valid_cont(pte).
With this change, the guard-marker reproducer passed 100 iterations
in an arm64 QEMU/KVM guest running a KASAN-enabled kernel. The fork
and PMD-split probes passed five runs each, with no warnings or KASAN
reports. In the earlier A/B test, the unmodified kernel failed on the
first guard-marker iteration.
The prototype makes the reported reproducer pass with a small change
while retaining PTE_CONT. I therefore cannot point to evidence that
fixing this failure requires significant code changes.
Thanks,
Gongyi
next prev parent reply other threads:[~2026-10-24 16:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 9:36 [PATCH] arm64/mm: restrict transparent contpte mappings to valid PTEs Zhao Gongyi
2026-10-13 10:13 ` Dev Jain
2026-10-14 6:16 ` Zhao Gongyi
2026-10-13 15:39 ` Lance Yang
2026-10-14 6:31 ` Zhao Gongyi
2026-10-14 6:46 ` Lance Yang
2026-10-14 8:38 ` Baolin Wang
2026-10-14 9:24 ` Lance Yang
2026-10-14 9:35 ` Baolin Wang
2026-10-14 10:03 ` Dev Jain
2026-10-14 10:45 ` Lance Yang
2026-10-14 11:02 ` Dev Jain
2026-10-14 9:41 ` David Hildenbrand (Arm)
2026-10-19 7:06 ` Zhao Gongyi
2026-10-23 20:55 ` David Hildenbrand (Arm)
2026-10-24 16:00 ` Zhao Gongyi [this message]
2026-10-25 12:34 ` David Hildenbrand (Arm)
2026-10-26 13:30 ` Zhao Gongyi
2026-10-26 12:30 ` Catalin Marinas
2026-10-26 22:33 ` David Hildenbrand (Arm)
2026-10-27 16:49 ` Catalin Marinas
2026-10-23 12:12 ` [PATCH v2] " Zhao Gongyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b57c214-6a43-4fc7-a531-fb5eac196465@bytedance.com \
--to=zhaogongyi@bytedance.com \
--cc=Ryan.Roberts@arm.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=catalin.marinas@arm.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox