From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C476C79F8B for ; Sat, 5 Sep 2026 19:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I29P3lyigJMFnu99k3G+NxV5W8FFUhlm/5S9hJLKxPc=; b=Jb6R2pD+8AvmAieUhzVFZCwU2q LoF3AseUju3DITmQTCv0BYtk34eEVGPFi+4kQ+uR/jpszffHSALbZJESQYzNA3dNHJQ0bmZ0UbBC8 1FHH1FzNRbQBwMrHVafCFjeYrRPYWbS3K6fipdi5cv0Uglq0JaAxuHmqKVrRwBgSXpfw+KSFD29a9 s+uswW9YCrrVxLbdWvi/gGM37jONn9ZttI81CBjpKIRyduEzkA+eUilDeLKUuZ6hJPGAJDokRgxdE QUjApvYCehQE8RrgXe8No+OMxIq4UTzB/+UohUcgYr9c/vWQ2UreBtqovlPDTPE4tEfE+ypQzzg0J 5lN/bTmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2w1M-00000004MgH-3NZs; Sat, 05 Sep 2026 19:25:48 +0000 Received: from out16-185.antispamcloud.com ([185.201.18.185]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2w1K-00000004Mfw-1PVF for linux-arm-kernel@lists.infradead.org; Sat, 05 Sep 2026 19:25:47 +0000 Received: from s1041.use1.mysecurecloudhost.com ([192.250.231.249]) by mx322.antispamcloud.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1x2w15-009Yb0-JP; Sat, 05 Sep 2026 21:25:34 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=reactivated.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I29P3lyigJMFnu99k3G+NxV5W8FFUhlm/5S9hJLKxPc=; b=MBK+0tZFAa/Gn/q6Wbfi1QYf2m +SMUMMRhQ+QQRJQMWzBMgk2nJYC66M0gzBYG6o9W3evx36FHo5lHLUAxeHKY9ocu1QGe9f2W7Qfgf raetyrvpYvrCs+6Py7sWOjWWxfT0yVemhIjfYuesw2jVNy2U5r+l+UyINrIJwxawCUjGtrLAyWwfN dnsVBcbb1X9FfPOF8EX7866M0yOh3yVxb65Z/vxLN3du24NGNU8TxYoWUD78YQmmMFHEu0pEMo+3y /g77FpBBbYB2RaJXHcbPSPC7s8mrWeIQBdff8KrYnyUKe+bqVHG3DvSgv1i6Id5Waq8IsM3DjLkqf ATUGo8MA==; Received: from [188.251.249.2] (port=51350 helo=[192.168.1.123]) by s1041.use1.mysecurecloudhost.com with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.99.5) (envelope-from ) id 1x2w0y-00000007arG-289l; Sat, 05 Sep 2026 19:25:24 +0000 Message-ID: <3b5830a2-31f8-48bc-a56e-ed70377bbb1b@reactivated.net> Date: Sat, 5 Sep 2026 20:25:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] Add support for Broadcom BCM2712 IOMMU driver (Raspberry Pi 5) To: Jim Quinlan Cc: "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, nick.hollinghurst@raspberrypi.com, Jason Gunthorpe , Krzysztof Kozlowski References: <20260902-bcm2712-iommu-submit-v4-0-9dbb657578c1@reactivated.net> Content-Language: en-US From: Daniel Drake In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Get-Message-Sender-Via: s1041.use1.mysecurecloudhost.com: authenticated_id: dan@reactivated.net X-Authenticated-Sender: s1041.use1.mysecurecloudhost.com: dan@reactivated.net X-Originating-IP: 192.250.231.249 X-Spampanel-Domain: s1041.use1.mysecurecloudhost.com X-Spampanel-Username: 192.250.231.249 Authentication-Results: antispamcloud.com; auth=pass smtp.auth=192.250.231.249@s1041.use1.mysecurecloudhost.com X-Spampanel-Outgoing-Class: ham X-Spampanel-Outgoing-Evidence: Combined (0.07) X-Recommended-Action: accept X-Filter-ID: 9kzQTOBWQUFZTohSKvQbgI7ZDo5ubYELi59AwcWUnuUnZbjr8C3tcPbSEFoPsgmLeziwPHUKuLxe 4qBq1a+FYCu2SmbhJN1U9FKs8X3+Nt06bFpPrNOlRAlE9AVLwR4uGVjKNnzF3nQoDoQtBifM84JL M0i5ZAms0EHrvcCaVINi54ngXV2h9XXLXGvseU+LGnT3EFAinyrilm9zau/FuzkQt9Nb4Ml7QXdk EetczWBpY9ovdkP9RmEvieRDWoEFGZ7f+7oeClYYrL6OxfWC1jM0MOKiGRkxO3FaI58br05WBb39 uS1TjWG2Inx+Ts2QrtVmombMJ4e2pn5C0yBMHZ0fE47nEjvubMSTLAkKCKclZzoe+TZdeH39wA4E grA4pE2PuLHIFQdBY9qb1rRWgyz0f29FZkQs6Ir87R/YNAszN6aoC8HwQTObwM1qLvCNTb6qMngR zAI55MutK7Hm2WVdqUWFH/m7thLakJHUNLOhsIXfQJBdziWVxbPM+eqcfxRAkuNPA/wWXImf2l3i esXQ7SopzlRh1zifXgrC4UG2Pt4fUgp+DZoShaPoyYliAoajAWweUFMTbU8ebAWhOjONRA9OfeQx MUNSsA9S/7adOer54gFeYIyf/VI1wUg/KaAJeWYTMyqvWPctqnwRLXABYtQiKS6L1oPObXHG4XuB tw8JhfTSZBah6TYySBe/EJBsfXIzfzvfdU6fGHDZThLSXiI9Gw+7tmoMdcYgrgLaoR1Y7hdEFeOM IzpuIYvQDyMYLxvGW3IbtaX54tMKOB2mlP2W9u+agdcanH6cUDOvoGd0qTR9MAtZbKbqHklG6k7o 5kYCtjHeNVHQXMZukoUpztNsa0DUHNL9jMWEuCzM24OD2qGt6TVUNM5e7f/lvCzv9KG+9VPIbHp+ ++0+2ndXPd2mu86jxvGTfZNouT6f3He7jw4SoVhmTJ/3eP9ONMaEXCDUS2PfGmfkjBlSS66CbGpy vykVsbKD1nW2UNFDcZMNsyd9sNan/JeWgUakIgJkZA66p7JimgfMa++iLXrAJbyB+/fbKGEqMODx 8DkuTvTndFR/A9egQIH068lsbT7SCD6kQJ3tI0MR7rn/4WYZnjq45i1nYESwVKwzZiFUI1t4mPoi rRq4PJLWMw/6KojFOrGz33upi7EPNu9rNFYFvf25LVONYbYifH5OzZCiewdqCBE/0+/4pwUv7rIU PjeR1T1JQdoCddsmjeKIhdiBBNhBSGY5vxrKJClYskFrCVDof/XkQioXeG4M8YMPbkgXenfBtLq6 AZRXEgMVECJ/QUl/m3QUU16YM5JjcEIdidSTnS8IQ6usOik9AEZrgOZSaRnsNZVApQzHT4cVx0KY do0DOHLiFskKAucWHRMw/Kfe29CB0IyEr6OHBrCQYuMBA7a+Mv5xKXYo4UIrAadw9dTKdIb1I20+ dwSq6lZSDrVoSWcG6DQ3YMS+IGJeO4HbHw0XswOVNt4vqF35kGyDFhtwEYMSACKY0kCaWypm4zuN RcgRKiGg7nXFaZTxaded/ujSY2/ltFtdZhvFO590VAkmxqByO8Gsjp12nsFfQXgXgQLLTOYxoIZ9 JstU8UMsiAJ6CG7rwwRyQmbntPkbCX79rLXRvB1uJYgnM9NZK591ReVrrqRv1hvAuCIEifnL+9wg oTj4ygNPw1XfNyJNE/BHENwcVg2HSapJFbos6C1ONGDORvH/2vBiQAW/8UMsiAJ6CG7rwwRyQmbn tHLAjYtUbr3Dqh+N9NAloToxL7hrJSk60SF3F6RYOYr2 X-Report-Abuse-To: spam@quarantine16.antispamcloud.com X-Complaints-To: abuse@master.antispamcloud.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260905_122546_382891_2789B70F X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/09/2026 19:14, Jim Quinlan wrote: > I wish you had kept the dma-iova offset hack but I understand why you > did not. Well, having an initial iommu driver upstream will provide a good base on top of which we can work on that specific problem. It'll need some consideration/discussion to be done in a way that is not regarded as a hack. I might come back to this later, time permitting. > I've built and successfully tested your driver on the> Broadcom sister chip of the RpI 5. I am mostly interested in the > iommu attached to the PCIe controller. I tested this by running > multiple tests where 10MiB is sent by a Wifi chip. Data integrity was > validated of course. > > I did not use the driver code as is. I tried merely decrementing the > MMMU_PT_PA_BASE value for the 4GB iova-offset required for our > configuration, but that did not work for some reason. So I just > hacked in some iova conversions and got it working. Thanks for the review and testing! I'll send an updated version that removes the blocking domain, hopefully that will be ready for inclusion. Daniel