linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP4: hwmod: Disable hardware-controlled idle for GPT1
Date: Thu, 10 Mar 2011 20:07:24 +0530	[thread overview]
Message-ID: <3b8b985f13158fbcd110cf45ed7035ad@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1103100143230.15132@utopia.booyaka.com>

Paul, Benoit,

> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> owner at vger.kernel.org] On Behalf Of Paul Walmsley
> Sent: Thursday, March 10, 2011 2:15 PM
> To: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Cc: Rajendra Nayak; Beno?t Cousson
> Subject: Re: [PATCH] OMAP4: hwmod: Disable hardware-controlled idle
> for GPT1
>
> On Wed, 9 Mar 2011, Paul Walmsley wrote:
>
> > From: Rajendra Nayak <rnayak@ti.com>
> >
> > Some issues seen (which cause lockups in suspend) with GPT1
> > after the MPU<->L4_WKUP static dependency was cleared can be
> > Worked-around for now by forcing GPT1 in software
> > controlled idle.
> >
> > Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> > Signed-off-by: Beno?t Cousson <b-cousson@ti.com>
> > Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> Just a quick note, I missed Beno?t's update of the commit message:
>
>     http://www.spinics.net/linux/lists/linux-omap/msg48008.html
>
> and he's the maintainer of this so we should use his instead.  The
> revised
> message is below.
>

We continued further debug on the static dependency issues with
OMAP4 PM series.
So far from the findings what I have, this timer patch is actually not
needed and can be dropped. Infact the patch is not really effective
because current timer driver(not hwmod adapted yet) puts timer1
in smart idle again.

There is another static dep. just like MPUSS<-->EMIF seems to create
an issue. The lock-up is not very consistently reproducible so it's
very easy to get miss-leading results. Timer patch was one of those
observations. With or without timer patch I can reproduce the hang
with long duration test.

Will keep narrowing down the next offending static dependency but
in mean time I suggest you to drop this patch.

Regards,
Santosh

  reply	other threads:[~2011-03-10 14:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10  1:48 [PATCH] OMAP4: hwmod: Disable hardware-controlled idle for GPT1 Paul Walmsley
2011-03-10  8:45 ` Paul Walmsley
2011-03-10 14:37   ` Santosh Shilimkar [this message]
2011-03-10 14:45     ` Paul Walmsley
2011-03-10 16:27       ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b8b985f13158fbcd110cf45ed7035ad@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).