From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E819CDB46E for ; Thu, 12 Oct 2023 10:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eM0oeOsneIBwwNxGe3jSVssjRkRSzGEAzLLQv4PdL18=; b=asFgJ78EiTz1SN F8CBENRSrMMTiYLvv8FltEEIaQVHxoC0g3fta5714s9BFX2HHtXvnbdODw1gmnd7n4519VFSsCbKv 0KfKJ1x8cmeMP+VLxiXnDlB9Q8bPqDU5xFpXjnp7mQjpSlggWDoXubp+JkuLDlBss2/yDmOsGTiZr 5YLgBm2R1S4I2TygKq5aPQAvpns5hR4j/nLvqajPIJMo2znvZOpnqem5IKcUsxjvpxaQ6nPdXAh9a 65so+LlGbskH38R1nfTQJakhexocyrs1VqhC8YAguznhTFfmG5s2uQoOdG4oF+olezJ+4XtQt5hud VhTtJyChlqN37EzUGmuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqsUL-000Uvf-0i; Thu, 12 Oct 2023 10:00:17 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqsUH-000UuK-3A; Thu, 12 Oct 2023 10:00:15 +0000 X-UUID: 20f5a4a668e611ee9b7791016c24628a-20231012 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=zemzA5azsgkDRhdp0ShrGAbLsYiH90MErarvBxPWywY=; b=joGFOSjXHTe/DVqiDlmXP1KqyqQngF1nsdBITibPgyR2prXsGiKMqLIcExKFW0sHTQW1hCBQ3Ochu+PR5mIFboQTA2Ih10hC1tYC0KYmE5zPBgSZnewmHtWmF6GqDrEFAFPWxOMtNgQVCxrCmP9CPbO4xR5ZHzK9BSRAhHc5Qzo=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:7bfe62b3-e5e7-4bc6-bd0c-de11e3165a75,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:5f78ec9,CLOUDID:81ccd9bf-14cc-44ca-b657-2d2783296e72,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 20f5a4a668e611ee9b7791016c24628a-20231012 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2102417022; Thu, 12 Oct 2023 03:00:09 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS14N2.mediatek.inc (172.21.101.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 12 Oct 2023 18:00:06 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 12 Oct 2023 18:00:06 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZQ2ToxnyCCUMRUfAAAENQFTMsNqvaLKQtfQHSGSHPYzgPsXTpQ48TFEk4ST1FddAK4iA1BYzeU28Z+FxHbUB4/1gDDH0mwQJe78h6oxAeiGbtS8sjoMInSAWW4ws+zUZvu0KRizlrgijoibN+W2RMXuN/glzYlHa4HAs4BiR+rZQYrVO1k+4l5a2G5SZOv69Ky7eOu1Zkz6pRoz9di3SYtdak3tAccnpVSjdJfgwAvnkDnb2HY82Iycrm+MjnTmpXHUOMcAhsoIKgYhn0C7YA3dERgBR0doMoGGgBcxw70U3TnDxRWGJkzIipzrf5Zu2DMcer8anEO0gL3h+rv33Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zemzA5azsgkDRhdp0ShrGAbLsYiH90MErarvBxPWywY=; b=FFAWRvlNycf/Jg8HOUBjAURc0bdNS2xNmPjaivCny6SfQMudt0yUpLGJeOdSSEYArsXwjObWdbV7A2ezF5vi3o7zRjWNKXvD0u//VOv3ZLKYl/NcNpKu6a+RQ6uh8pPA65RVpNu//GdWhSgIKSrZfC1gqk4DO732ce/pdIzZEmqR7ClffsVOHprEljf+6uXngbpK/DliaadDnCMSjZI7SfErfNK84JcWl1Dmv/Eq+ASvIzKwdJef0WmQ+71e/Sd7rpuCMv75wJN95lFYBiToN7ThFRUZjN+e5TCxQpEdHek794f6iRXHaefnE1uJLQnfuylCTiHDUgz+FTBv2d6pXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zemzA5azsgkDRhdp0ShrGAbLsYiH90MErarvBxPWywY=; b=SRQ/2d3Gu46bgdTCsYqJ/KAKJ/KqJUwTl7GVms95CcTDc59O5drDl+D1PkAXfmwfqVw/6ES26LK8xIY9QQdt9NAFU2tAJs+2KCPcsrb3AFvoRuVusIapMyYrkB3SxMhINDk/TizRuRq6g5V0cY2K59UpeoTHI3tJxg4vp3uYyQc= Received: from SL2PR03MB4153.apcprd03.prod.outlook.com (2603:1096:100:4e::10) by KL1PR03MB6141.apcprd03.prod.outlook.com (2603:1096:820:90::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 10:00:04 +0000 Received: from SL2PR03MB4153.apcprd03.prod.outlook.com ([fe80::d451:c5cd:4a93:2a62]) by SL2PR03MB4153.apcprd03.prod.outlook.com ([fe80::d451:c5cd:4a93:2a62%4]) with mapi id 15.20.6813.017; Thu, 12 Oct 2023 10:00:04 +0000 From: =?utf-8?B?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= To: "angelogioacchino.delregno@collabora.com" , "hverkuil-cisco@xs4all.nl" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "frkoenig@chromium.org" , "stevecho@chromium.org" , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "daniel@ffwll.ch" , Project_Global_Chrome_Upstream_Group , "hsinyi@chromium.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2] media: mediatek: vcodec: using encoder device to alloc/free encoder memory Thread-Topic: [PATCH v2] media: mediatek: vcodec: using encoder device to alloc/free encoder memory Thread-Index: AQHZ+3QvchoRVljVA0CgvSOPwLHgh7BF7tSA Date: Thu, 12 Oct 2023 10:00:04 +0000 Message-ID: <3b8c1e14c49724e03a6d3e70eee28fd354a3a1a0.camel@mediatek.com> References: <20231010122010.25937-1-yunfei.dong@mediatek.com> In-Reply-To: <20231010122010.25937-1-yunfei.dong@mediatek.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SL2PR03MB4153:EE_|KL1PR03MB6141:EE_ x-ms-office365-filtering-correlation-id: 6faeaec5-9149-436e-b162-08dbcb0a01b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wSHKCnQx2df5p1vZpUL7Deh4CIVriquBzQ3OMgX+++FxGS6Uj6+4Whce8dV+1/p1VRoN62Isppqxlu9/URP/FHUU8sHvjn2tM/r7s9jLIgTuS+0z3Ph6fOqR3B+q4SYcXgTQH8MYvW/uigFQH7OVc9alhUiHshre0jeJH6VbvTZMrSkhnOtdz9QrIE06P5D4pu+C/bRBDSUwHxK45OL9n/AHzZXvTpfSSf0ZqxOH1n97rkFSDmNB9moHYG3vKVQ1Gu//QCUWRo8EoQPE/aykCmB+CB/blK7jx+Hq25C6eZUu/cAA4e/IBT5SbjNM/U8/O/CL92vJ27GNrGVm26FT9syl+IJMzmPF+Q1AxjHKd/JKdjVKrd8faE4H3EJtS7wRYzByLCSxQmNIrwazKxXRqxL4JlTUA0NIBlT+3zCfMx5PgExAOS0GicB11b/NhfZ0V6Y+Ai8FwAqyx85tdef/ZesMOEkxLCMAszcGyWfTVyv1wb0cohSVZd14c5QOSfEFM34AgqKK7k2oO74Q0Sb3PGZl9wyZNkoyIzzTXKqdbD5BwENPT9KHN4Q61O/5Unyr98+IaG2GKSpanf4oOjidVHacCNH9rULvQ6eaMXYBg62ysrFV3FMNl7WfN5J4DUyEmy3ONKbjm1j7CEP7Kd2WvG/oPXCgiTjmEglBmZ5wbAWplGor6jpE0R1EVxflVkP6 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR03MB4153.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(396003)(136003)(376002)(366004)(230922051799003)(1800799009)(64100799003)(186009)(451199024)(6486002)(478600001)(91956017)(110136005)(66446008)(83380400001)(64756008)(316002)(54906003)(41300700001)(66556008)(5660300002)(66476007)(66946007)(8936002)(71200400001)(8676002)(76116006)(4326008)(7416002)(6506007)(4001150100001)(2906002)(2616005)(85182001)(36756003)(26005)(38100700002)(6512007)(38070700005)(122000001)(86362001)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a1JDOWF1YnhGTkpHM21YTGNSSFpzQVFWV1JHZVcxY0ZHakN6dGNQZ3dVVUNt?= =?utf-8?B?eWQ5bEM5UTFJaG00cW1DbVdHMGE4QmQxQmlYdHJ3VEZzL29RYWpRYWQyME5O?= =?utf-8?B?WVVlWDJGajJQNnZBQ0FKRGQ1eU81VkNJcjJUSzNHZzc3Mk5YT1hML3lxMkFJ?= =?utf-8?B?dHk4Uk4rdmNiQm1leXFxRXJTZmxLMERHYlk5UlNPR3VWRm1Na0FtOWdYTzVF?= =?utf-8?B?U05TVFZZQUNQUG42aGhKd21laVRlNFNTNWRNbnYxSGNGUkx4YSswQU13UG5C?= =?utf-8?B?YStXQUZyYldGRmx5cDUwVlRKOVZMcU9ZYTQ1bTJBbi9ucnpleENtS1puR3Rx?= =?utf-8?B?dE9uUnYvODJZVlg0djVRZHRaUWhyWWd0NEtlaHA1WWZmS3g4dVBtbUR6VVM2?= =?utf-8?B?RURqYlNyTzZucm82bWNKUHVGZkhnTFFxaTBSSUQ4QysySTlRcnJDM2YreHRq?= =?utf-8?B?eG9JejRQeFljWGRVR1p0T1VIN3MxdlFVVWN5MmtIcFhnNlNuTkxKbEJKL3JY?= =?utf-8?B?dmtMYS81dDJDNVkzdFVVS2pPMS9DSVRwUVhNRmxRcXpZMzZWMnFvamoxUXVl?= =?utf-8?B?ckU2WUkwbDcyTFZGMkJLT3FJMS9BdU94bFp6U0drRkdCY2hDYU9PQnNyY1BN?= =?utf-8?B?Tk5mQ1k1VEl5Wi9sdjRBOGx5RWt5MWJLL2w0a0xrTDU0a3k3NE13OVYwZnpk?= =?utf-8?B?Tm9yVGIyODdGblhpckVvR3Exb0VIaGJXNnpBOHZFTHZMYUJXMlZyY2hmZDcy?= =?utf-8?B?TWRGTmJUUVkvTDl4QVNXa21jcGVpbXlrbGo5b3U2WTNIQW5GVFZqcE1QRjMz?= =?utf-8?B?SXZjd0NRT1hrZUFDWk5KekhBNlRPb2FiY2xMVzk2bnFpVzBBT0NuUlZWKy83?= =?utf-8?B?N2d6bGZMVDNZWW05eHRTay9vcElEV3UzU0YwTlU2WXR6cFowOGZuZTRTK0E3?= =?utf-8?B?aU13SlppS1ZhcXZhUWlzNlBGZkRoQXF0dCt3NmloUzNQZ0Y0K1F2emNFS2xm?= =?utf-8?B?c1I2c0JNaDVRbGs5aWM0WHVnZURpTDNucDRScWlhRWZMNkpaOXZVZ1kza01Y?= =?utf-8?B?UFNRSWhTaFJxbXZjMmxSKzAvZzZpTGRZanVYcFNOaTUvdzM2YjkxU1prY3JF?= =?utf-8?B?bGFxUTM3TGFyd1k3WCsrTERkZExFN0FmdnRqM2JYVi9HbVdja0VxdGZNYlNR?= =?utf-8?B?RjdneEwvanIxRG9hcytDc2RtTld6NytiYU5TVUk3QlRlU1FlMThCZktzT09p?= =?utf-8?B?akdKTHRVTXpkNTF6WnVRUmd5OWxyeEE3R0d5TFl5alFZaFM4Nkd6T3E2SUN0?= =?utf-8?B?M29WeEU2eFM1YnpUUnVJREJEVWJKVmhsUDBUaWMxQjlnRGMwQzA0OUxnSjlB?= =?utf-8?B?Z0xXRHFtSi82V1E1Uk1mVUpvWEROdUVKWWlJQ2puQURKbzZwYUVaQ3F0TFZI?= =?utf-8?B?SURCRGZpdWR6VVBzOTh0OW5aekt6RksvTm9UeGNGdWtOdUZ2c09UUXEvUDVl?= =?utf-8?B?UWZ6b0FCOEZoMjlTTmZPMEJHTkdLUlZtSjkzRmRLbG05aVZZRE4vbEFvbGlj?= =?utf-8?B?TlRzcG1XemxmMGQ5b25vZy80RDRVeGtqRjVnT2ZlSW1QY1FvcnFQNTZTVEpS?= =?utf-8?B?dDdBdEtmZW4wOUFlblUrc1dTcmxweHhFdEVGUkpJdFR6ZHAxVml1bDVxNlVL?= =?utf-8?B?U01hUGQwcVpFUlNnSTU4eGJraVNUa3hJUmtSTThDZCtseFlISGpramdkaDMr?= =?utf-8?B?UUFlbnAxL3pVRUI4SnVDcUNETmQ1SWRyZnp0ekFrWXZ5VEJrWUxQN3ZpbHF6?= =?utf-8?B?dzc3RnZoMDEyVHo3WDBhQi9iT0gxb0RJVnRJdGNkdm43bzR5cCtVQ3F2bUdJ?= =?utf-8?B?TGs2M3lQWWkyMEJNMzYxZVdQY0ZWWHVnaE0rblJRY2ViZ1c0UmRZR0l0a0ZX?= =?utf-8?B?NXk1TmNXUWlRamdDMnNEWjZheWgzSGRUa1pURFNmckVDNHJJUzIyd0s2bkhR?= =?utf-8?B?V013M0JudjJyc1NNc1FSL1l4QkhoRTVXOG1YYVBaZzBHYm1HQlBjUkVDRk50?= =?utf-8?B?anBERk52SFNUelliWFZ4SElkZUJIMnMwWFNLN0RUL0VTL1NxSVpXVFVwd0tj?= =?utf-8?B?aUs5anJ2V3lhMGxCYjRhcEJCeEJVTmdxR2pLZGRFbDhqOXBnYnAwRm1wNUJj?= =?utf-8?B?RkE9PQ==?= Content-ID: <4A2DB6910FA3514F94170FFC3E8779EB@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SL2PR03MB4153.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6faeaec5-9149-436e-b162-08dbcb0a01b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2023 10:00:04.1593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rUjChW9bdBYYHqwLBIeN+TPVYNKldIvjVG+nddXku21HEyn8EAYS69vz7tQyW+8KtGETG03lGknAuuFcVIRCu5y/keLHIMa4mgW9O0ljcGM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB6141 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--12.319700-8.000000 X-TMASE-MatchedRID: oTBA/+sdKaZjDV//SvkH3ia1MaKuob8PC/ExpXrHizz4JyR+b5tvoIw4 FkpVp0jX9IqAdUPEkbteUgGM1TqOIzsjH2rWHzbWUIhTTahb7dWe4TzN1NEjXyS30GKAkBxWn1k iBCfjYF3VIgPUVpPw2IOEytVBBZaHYlldA0POS1JSGsgQwHevX5dhffisWXfHRQ0dAChl/lz8/L 2o6LnOl44ktSmkU0+e9fNhUVsK8nFccQ8eam5EfdIFVVzYGjNKWQy9YC5qGvzKU1cWyI3gWkkpb iYOUmwxIAcCikR3vq/kOF5q0wVjb+p7/ronY78V/q0NQM9d4F4VpSjRQSGMq6mk467c73Dx X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--12.319700-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: A1D2A4017577E1CEBF2517086A783073A311AB11465C83F15A1D610DE6B7A6242000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231012_030014_077417_91B145B1 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi AngeloGioacchino, Could you please help to review this patch again. Best Regards, Yunfei Dong On Tue, 2023-10-10 at 20:20 +0800, Yunfei Dong wrote: > Need to use encoder device to allocate/free encoder memory when > calling > mtk_vcodec_mem_alloc/mtk_vcodec_mem_free, or leading to below crash > log > when test encoder with decoder device. > > pc : dma_alloc_attrs+0x44/0xf4 > lr : mtk_vcodec_mem_alloc+0x50/0xa4 [mtk_vcodec_common] > sp : ffffffc0209f3990 > x29: ffffffc0209f39a0 x28: ffffff8024102a18 x27: 0000000000000000 > x26: 0000000000000000 x25: ffffffc00c06e2d8 x24: 0000000000000001 > x23: 0000000000000cc0 x22: 0000000000000010 x21: 0000000000000800 > x20: ffffff8024102a18 x19: 0000000000000000 x18: 0000000000000000 > x17: 0000000000000009 x16: ffffffe389736a98 x15: 0000000000000078 > x14: ffffffe389704434 x13: 0000000000000007 x12: ffffffe38a2b2560 > x11: 0000000000000800 x10: 0000000000000004 x9 : ffffffe331f07484 > x8 : 5400e9aef2395000 x7 : 0000000000000000 x6 : 000000000000003f > x5 : 0000000000000001 x4 : 0000000000000000 x3 : 0000000000000cc0 > x2 : ffffff8024102a18 x1 : 0000000000000800 x0 : 0000000000000010 > Call trace: > dma_alloc_attrs+0x44/0xf4 > mtk_vcodec_mem_alloc+0x50/0xa4 [mtk_vcodec_common > 2819d3d601f3cd06c1f2213ac1b9995134441421] > h264_enc_set_param+0x27c/0x378 [mtk_vcodec_enc > 772cc3d26c254e8cf54079451ef8d930d2eb4404] > venc_if_set_param+0x4c/0x7c [mtk_vcodec_enc > 772cc3d26c254e8cf54079451ef8d930d2eb4404] > vb2ops_venc_start_streaming+0x1bc/0x328 [mtk_vcodec_enc > 772cc3d26c254e8cf54079451ef8d930d2eb4404] > vb2_start_streaming+0x64/0x12c > vb2_core_streamon+0x114/0x158 > vb2_streamon+0x38/0x60 > v4l2_m2m_streamon+0x48/0x88 > v4l2_m2m_ioctl_streamon+0x20/0x2c > v4l_streamon+0x2c/0x38 > __video_do_ioctl+0x2c4/0x3dc > video_usercopy+0x404/0x934 > video_ioctl2+0x20/0x2c > v4l2_ioctl+0x54/0x64 > v4l2_compat_ioctl32+0x90/0xa34 > __arm64_compat_sys_ioctl+0x128/0x13c > invoke_syscall+0x4c/0x108 > el0_svc_common+0x98/0x104 > do_el0_svc_compat+0x28/0x34 > el0_svc_compat+0x2c/0x74 > el0t_32_sync_handler+0xa8/0xcc > el0t_32_sync+0x194/0x198 > Code: aa0003f6 aa0203f4 aa0103f5 f900 > > 'Fixes: 01abf5fbb081c ("media: mediatek: vcodec: separate struct > 'mtk_vcodec_ctx'")' > Signed-off-by: Yunfei Dong > --- > changed with v1: > - rewrite allocate and free memory interface for encoder and decoder. > --- > .../mediatek/vcodec/common/mtk_vcodec_util.c | 56 +++++++++++++-- > ---- > 1 file changed, 40 insertions(+), 16 deletions(-) > > diff --git > a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_util.c > b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_util.c > index 908602031fd0..9ce34a3b5ee6 100644 > --- a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_util.c > +++ b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_util.c > @@ -47,20 +47,32 @@ EXPORT_SYMBOL(mtk_vcodec_write_vdecsys); > > int mtk_vcodec_mem_alloc(void *priv, struct mtk_vcodec_mem *mem) > { > + enum mtk_instance_type inst_type = *((unsigned int *)priv); > + struct platform_device *plat_dev; > unsigned long size = mem->size; > - struct mtk_vcodec_dec_ctx *ctx = priv; > - struct device *dev = &ctx->dev->plat_dev->dev; > + int id; > > - mem->va = dma_alloc_coherent(dev, size, &mem->dma_addr, > GFP_KERNEL); > + if (inst_type == MTK_INST_ENCODER) { > + struct mtk_vcodec_enc_ctx *enc_ctx = priv; > + > + plat_dev = enc_ctx->dev->plat_dev; > + id = enc_ctx->id; > + } else { > + struct mtk_vcodec_dec_ctx *dec_ctx = priv; > + > + plat_dev = dec_ctx->dev->plat_dev; > + id = dec_ctx->id; > + } > + > + mem->va = dma_alloc_coherent(&plat_dev->dev, size, &mem- > >dma_addr, GFP_KERNEL); > if (!mem->va) { > - mtk_v4l2_vdec_err(ctx, "%s dma_alloc size=%ld failed!", > dev_name(dev), size); > + mtk_v4l2_err(plat_dev, "%s dma_alloc size=%ld failed!", > + dev_name(&plat_dev->dev), size); > return -ENOMEM; > } > > - mtk_v4l2_vdec_dbg(3, ctx, "[%d] - va = %p", ctx->id, mem- > >va); > - mtk_v4l2_vdec_dbg(3, ctx, "[%d] - dma = 0x%lx", ctx->id, > - (unsigned long)mem->dma_addr); > - mtk_v4l2_vdec_dbg(3, ctx, "[%d] size = 0x%lx", ctx->id, > size); > + mtk_v4l2_debug(plat_dev, 3, "[%d] - va = %p dma = 0x%lx size = > 0x%lx", id, mem->va, > + (unsigned long)mem->dma_addr, size); > > return 0; > } > @@ -68,21 +80,33 @@ EXPORT_SYMBOL(mtk_vcodec_mem_alloc); > > void mtk_vcodec_mem_free(void *priv, struct mtk_vcodec_mem *mem) > { > + enum mtk_instance_type inst_type = *((unsigned int *)priv); > + struct platform_device *plat_dev; > unsigned long size = mem->size; > - struct mtk_vcodec_dec_ctx *ctx = priv; > - struct device *dev = &ctx->dev->plat_dev->dev; > + int id; > + > + if (inst_type == MTK_INST_ENCODER) { > + struct mtk_vcodec_enc_ctx *enc_ctx = priv; > + > + plat_dev = enc_ctx->dev->plat_dev; > + id = enc_ctx->id; > + } else { > + struct mtk_vcodec_dec_ctx *dec_ctx = priv; > + > + plat_dev = dec_ctx->dev->plat_dev; > + id = dec_ctx->id; > + } > > if (!mem->va) { > - mtk_v4l2_vdec_err(ctx, "%s dma_free size=%ld failed!", > dev_name(dev), size); > + mtk_v4l2_err(plat_dev, "%s dma_free size=%ld failed!", > + dev_name(&plat_dev->dev), size); > return; > } > > - mtk_v4l2_vdec_dbg(3, ctx, "[%d] - va = %p", ctx->id, mem- > >va); > - mtk_v4l2_vdec_dbg(3, ctx, "[%d] - dma = 0x%lx", ctx->id, > - (unsigned long)mem->dma_addr); > - mtk_v4l2_vdec_dbg(3, ctx, "[%d] size = 0x%lx", ctx->id, > size); > + mtk_v4l2_debug(plat_dev, 3, "[%d] - va = %p dma = 0x%lx size = > 0x%lx", id, mem->va, > + (unsigned long)mem->dma_addr, size); > > - dma_free_coherent(dev, size, mem->va, mem->dma_addr); > + dma_free_coherent(&plat_dev->dev, size, mem->va, mem- > >dma_addr); > mem->va = NULL; > mem->dma_addr = 0; > mem->size = 0; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel