From: Stefan Wahren <stefan.wahren@i2se.com>
To: Umang Jain <umang.jain@ideasonboard.com>,
linux-media@vger.kernel.org, kernel-list@raspberrypi.com,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"Ricardo B . Marliere" <ricardo@marliere.net>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2 05/15] staging: mmal-vchiq: Use vc-sm-cma to support zero copy
Date: Wed, 15 Nov 2023 20:03:47 +0100 [thread overview]
Message-ID: <3b9ec650-8a99-4bac-9ac9-d2cd87efced5@i2se.com> (raw)
In-Reply-To: <20231109210309.638594-6-umang.jain@ideasonboard.com>
Hi Umang,
Am 09.11.23 um 22:02 schrieb Umang Jain:
> From: Dave Stevenson <dave.stevenson@raspberrypi.com>
>
> With the vc-sm-cma driver we can support zero copy of buffers between
> the kernel and VPU. Add this support to mmal-vchiq.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> .../staging/vc04_services/vchiq-mmal/Kconfig | 1 +
> .../vc04_services/vchiq-mmal/mmal-common.h | 4 +
> .../vc04_services/vchiq-mmal/mmal-vchiq.c | 84 +++++++++++++++++--
> .../vc04_services/vchiq-mmal/mmal-vchiq.h | 1 +
> 4 files changed, 83 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/Kconfig b/drivers/staging/vc04_services/vchiq-mmal/Kconfig
> index c99525a0bb45..a7c1a7bf516e 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/Kconfig
> +++ b/drivers/staging/vc04_services/vchiq-mmal/Kconfig
> @@ -1,6 +1,7 @@
> config BCM2835_VCHIQ_MMAL
> tristate "BCM2835 MMAL VCHIQ service"
> depends on BCM2835_VCHIQ
> + select BCM_VC_SM_CMA
i think we need more explanation in the commit message of the relation
between these both modules.
On the one side BCM_VC_SM_CMA should be a driver, but it's not a driver
for a specific hardware. It looks like more an extension of VCHIQ MMAL
or does other (maybe not yet imported) vc04 driver make also use of this.
My question is: is BCM_VC_SM_CMA a real member on the VCHIQ bus and why?
Best regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-15 19:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 21:02 [PATCH v2 00/15] staging: vc04_services: bcm2835-isp support Umang Jain
2023-11-09 21:02 ` [PATCH v2 01/15] staging: vc04_services: Add new vc-sm-cma driver Umang Jain
2023-11-13 17:56 ` Stefan Wahren
2023-11-15 19:56 ` Laurent Pinchart
2023-11-15 20:48 ` Stefan Wahren
2023-11-20 9:52 ` Dan Carpenter
2023-11-09 21:02 ` [PATCH v2 02/15] staging: vc04_services: vchiq_arm: Register vcsm-cma driver Umang Jain
2023-11-14 19:32 ` Stefan Wahren
2023-11-09 21:02 ` [PATCH v2 03/15] media: videobuf2: Allow exporting of a struct dmabuf Umang Jain
2023-11-14 19:41 ` Stefan Wahren
2023-11-15 19:31 ` Laurent Pinchart
2023-11-15 21:00 ` Stefan Wahren
2023-11-09 21:02 ` [PATCH v2 04/15] staging: mmal-vchiq: Add support for event callbacks Umang Jain
2023-11-20 10:00 ` Dan Carpenter
2023-11-09 21:02 ` [PATCH v2 05/15] staging: mmal-vchiq: Use vc-sm-cma to support zero copy Umang Jain
2023-11-15 19:03 ` Stefan Wahren [this message]
2023-11-15 19:27 ` Laurent Pinchart
2023-11-09 21:02 ` [PATCH v2 06/15] staging: mmal_vchiq: Add image formats to be used by bcm2835-isp Umang Jain
2023-11-09 21:02 ` [PATCH v2 07/15] media: uapi: v4l2-core: Add ISP statistics output V4L2 fourcc type Umang Jain
2023-11-18 13:11 ` Stefan Wahren
2023-11-09 21:03 ` [PATCH v2 08/15] uapi: bcm2835-isp: Add bcm2835-isp uapi header file Umang Jain
2023-11-09 21:03 ` [PATCH v2 09/15] staging: vc04_services: Add helpers for vchiq driver data Umang Jain
2023-11-18 14:43 ` Stefan Wahren
2023-11-09 21:03 ` [PATCH v2 10/15] staging: vc04_services: bcm2835-isp: Add a more complex ISP processing component Umang Jain
2023-11-13 14:07 ` [PATCH] fixup! " Umang Jain
2023-11-13 15:25 ` Stefan Wahren
2023-11-23 12:56 ` Greg KH
2023-11-23 13:53 ` Laurent Pinchart
2023-11-18 14:53 ` [PATCH v2 10/15] " Stefan Wahren
2023-11-18 18:56 ` Laurent Pinchart
2023-11-19 12:02 ` Stefan Wahren
2023-11-20 10:33 ` Dan Carpenter
2023-11-09 21:03 ` [PATCH v2 11/15] vc04_services: bcm2835-isp: Allow formats with different colour spaces Umang Jain
2023-11-09 21:03 ` [PATCH v2 12/15] vc04_services: bcm2835-isp: Permit all sRGB colour spaces on ISP outputs Umang Jain
2023-11-09 21:03 ` [PATCH v2 13/15] staging: vc04_services: bcm2835_isp: Allow multiple users Umang Jain
2023-11-09 21:03 ` [PATCH v2 14/15] docs: admin-guide: media: bcm2835-isp: Add documentation for bcm2835-isp Umang Jain
2023-11-09 21:03 ` [PATCH v2 15/15] staging: vc04_services: vchiq: Register bcm2835-isp Umang Jain
2023-11-10 10:32 ` [PATCH v2 00/15] staging: vc04_services: bcm2835-isp support Stefan Wahren
2023-11-13 13:38 ` Umang Jain
2023-11-13 15:09 ` Stefan Wahren
2023-11-15 19:59 ` Laurent Pinchart
2023-11-15 20:57 ` Stefan Wahren
2023-11-16 0:50 ` Laurent Pinchart
2023-11-16 10:54 ` Ivan T. Ivanov
2023-11-16 10:57 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b9ec650-8a99-4bac-9ac9-d2cd87efced5@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=kernel-list@raspberrypi.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=ricardo@marliere.net \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox