From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A1BEC072A2 for ; Wed, 15 Nov 2023 19:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R4dYn5DQavTuDLuRWbcMmPCnPidh60v/xNFNqfa71ew=; b=16hLJbxkRbuzWT wzBQ7m2Fc5fpW9Ii0Qq9xgd28+GdN3n5ogM6hnT2HauDRaiAUsu5h/Mpjs57z2302WX1O+NCg6CFE EFM24S3L5eAVqQnanJajb6v6EidDucuReVpyqJUIHZwvLzinaoZWkYZeZVbORZtmLnyOLaZCsRl2v YVF6lWI9NUrSekswXop6QTcaSPx24Gva5/owiP7HCVLv6793zcQ1eQZLu5adHk5SoKc7ZUJVmk0Qt drH0oyFNY4zCiEkhdThkwxG5dJz14ZvGNzZA6CDwOYT8vZrQWqHOFBtbvlS2hokvQYT6+ppeX2YQm QUsFR7bZSZCFFek45w+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3LBJ-001Ym1-2s; Wed, 15 Nov 2023 19:04:09 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3LBG-001Yla-0O; Wed, 15 Nov 2023 19:04:07 +0000 Received: from [192.168.1.129] ([37.4.248.43]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MMWcT-1qkyqR1Jzz-00JbZM; Wed, 15 Nov 2023 20:03:48 +0100 Message-ID: <3b9ec650-8a99-4bac-9ac9-d2cd87efced5@i2se.com> Date: Wed, 15 Nov 2023 20:03:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/15] staging: mmal-vchiq: Use vc-sm-cma to support zero copy Content-Language: en-US To: Umang Jain , linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev Cc: Dave Stevenson , Kieran Bingham , Laurent Pinchart , "Ricardo B . Marliere" , Dan Carpenter References: <20231109210309.638594-1-umang.jain@ideasonboard.com> <20231109210309.638594-6-umang.jain@ideasonboard.com> From: Stefan Wahren In-Reply-To: <20231109210309.638594-6-umang.jain@ideasonboard.com> X-Provags-ID: V03:K1:hRUgUPLJ7rFTcdE7NnVcI/4HzsqA4QYhQf3aFo9afPhySVvhACg ///NpGH8Kc41l0Xucn7dDL/L68PirBZ42PrNbUYgYG7D3G2W3tYshi8mtRw3lfS+XnAmCM0 rQo082W3D2O9M9Nl8qzao9eoEA9zyeQKotc0xhQmXhA4zIyxpFBCw0WAreIMUPosdf23Y9l 9ZXAY34760qzi05XY8MZQ== UI-OutboundReport: notjunk:1;M01:P0:xlxB7dXYVbM=;ZzonCn7mXukF7za8R8WhfIBem8b 7Y+9VSl8Tcrq8BKgZ/qdjJa092opnS/WGchGNB4vD6z/z0co4MooUwc6hKWDTSOFqmKyF6RmH tHMDIcfftwNr7OGnPsGp9dF/m7GK2N1xoZHjbyJOMcIqHSFuBScs5lW7YkzhX7HqSj11teeJD madIE93cDzmtvv8NW/eQqmkUfvWgIe5D+wRsXSMqSpQsdAzCvMea1B1i3gtYFsbC9YTYXKGYR LcW2sue9WGkd9aUG5GtuDsqZP+LQYf0D7uAMYD5TOHnAmvj4ALnQPdBAGcJcj+0P4II4Tlgt9 Z7cAh2JSGQNIJ4LaiYh9nZ2MjCv5NoN0a1Y1/5ZYlT9e1BvTEnh7iGFWrOGOMD23P5GbNvaSP F4K1wxOB+S8cjrPXJZfsORyCzBeg8Ct+yfUUKBS7LKfkM2cTJao6bU+htyqSeBpbkTrcPHPqi G/BwZTn2UR1CIWitUnIXf4yBDsKDcM98tl8BC/NXTlLxESoxPzhMhwZRpOcvKSkqmCmefxLhK 6+lFEmy+r1TpBcOhmz+QgZ5oxxZTIdHLX3zTU5rEo4PrDc5tOIdER3ays+WMPTFPDti1XHN69 zv2C0GFnpjuMmN0w7Goi31uUPkY/WkOYiunN1SVGOPhf7PebD24l/7RRzw6eQklTWliwzODF8 QcMgFKp+r9NMw7Ooti/bzBDg7o835td7ZpadUSkka0A8eJfkm+ulZjsR6L982lccHvqy0YpOp 9vFguXT7+uTdMVllqp8sJdXvkl0i2duPtjG2EUjn7TgW+AR0tuxiJTMwh3X7Y/I5PALa2JO1x 3boMM0fPaeZvXhWGFLHGkvGZPUkodRg0Yn5SgGvVNb28EE+G4VMgqceHUb5iq71/72EMIz7dG JMx4H6eWoWYghCg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231115_110406_467592_4E9E1E9D X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, Am 09.11.23 um 22:02 schrieb Umang Jain: > From: Dave Stevenson > > With the vc-sm-cma driver we can support zero copy of buffers between > the kernel and VPU. Add this support to mmal-vchiq. > > Signed-off-by: Dave Stevenson > Signed-off-by: Umang Jain > --- > .../staging/vc04_services/vchiq-mmal/Kconfig | 1 + > .../vc04_services/vchiq-mmal/mmal-common.h | 4 + > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 84 +++++++++++++++++-- > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 1 + > 4 files changed, 83 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/Kconfig b/drivers/staging/vc04_services/vchiq-mmal/Kconfig > index c99525a0bb45..a7c1a7bf516e 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/Kconfig > +++ b/drivers/staging/vc04_services/vchiq-mmal/Kconfig > @@ -1,6 +1,7 @@ > config BCM2835_VCHIQ_MMAL > tristate "BCM2835 MMAL VCHIQ service" > depends on BCM2835_VCHIQ > + select BCM_VC_SM_CMA i think we need more explanation in the commit message of the relation between these both modules. On the one side BCM_VC_SM_CMA should be a driver, but it's not a driver for a specific hardware. It looks like more an extension of VCHIQ MMAL or does other (maybe not yet imported) vc04 driver make also use of this. My question is: is BCM_VC_SM_CMA a real member on the VCHIQ bus and why? Best regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel