From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 576BEC4828F for ; Fri, 9 Feb 2024 10:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y7RM0NAvo39JtQ4Ahjt+ESSKQkSqkFPWK9jMQPspov4=; b=vIGbAo9qQLOjwq fw9W2F6xGUOqJcVkhd/cA6EUFwaE2MFFdFiO2rjxr96ent/S4tVdpG7k7+Dy1ws9jj2qDCHYKB0m3 +vkEauw8F/vm6l0mmR6Q2hItiLZwv5NBiRGCxgdoHY3n7vH0Rs2L/feNc7yexwCu2v3Jv38gZefYe N7Ntz/wLjZ9WSd4mLNEmS8+okY02ucfT9UiBkQSJZa/0lSqqQy+Qq/eGKqrbL+oosgtjVqj0cmpuq Exivr/XDMlQBlaAqzZp/GJGpWUfl0k1DbxR3ZBBtaLVbt4JOmmPA900ZhGLefTPN2v2dcEK32bWx+ a0DTq6R6T9CuvDkc6Hhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rYNhh-0000000Gf2A-0wtE; Fri, 09 Feb 2024 10:01:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rYMel-0000000GVf5-0BX4 for linux-arm-kernel@lists.infradead.org; Fri, 09 Feb 2024 08:54:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D4E6DA7; Fri, 9 Feb 2024 00:55:22 -0800 (PST) Received: from [10.57.65.115] (unknown [10.57.65.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6688A3F762; Fri, 9 Feb 2024 00:54:36 -0800 (PST) Message-ID: <3ba54c94-8e44-4dd6-9a25-2cf81b07336f@arm.com> Date: Fri, 9 Feb 2024 08:54:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/25] Transparent Contiguous PTEs for User Mappings To: Mark Rutland Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240202080756.1453939-1-ryan.roberts@arm.com> Content-Language: en-GB From: Ryan Roberts In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240209_005447_224426_0001C28F X-CRM114-Status: GOOD ( 23.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/02/2024 17:34, Mark Rutland wrote: > On Fri, Feb 02, 2024 at 08:07:31AM +0000, Ryan Roberts wrote: >> Hi All, > > Hi Ryan, > > I assume this is the same as your 'features/granule_perf/contpte-lkml_v' branch > on https://gitlab.arm.com/linux-arm/linux-rr/ Yep - great detective work! features/granule_perf/contpte-lkml_v5 corresponds exactly to what I posted with all the dependencies in place. > > I've taken a quick look, and I have a few initial/superficial comments before > digging into the detail on the important changes. Thanks for doing this! > >> Patch Layout >> ============ >> >> In this version, I've split the patches to better show each optimization: >> >> - 1-2: mm prep: misc code and docs cleanups > > I'm not confident enough to comment on patch 2, but these look reasonable to > me. Thanks. David has acked patch 2 already so I think we are good there. > >> - 3-8: mm,arm,arm64,powerpc,x86 prep: Replace pte_next_pfn() with more >> general pte_advance_pfn() > > These look fine to me. Thanks! > >> - 9-18: arm64 prep: Refactor ptep helpers into new layer > > The result of patches 9-17 looks good to me, but the intermediate stages where > some functions are converted is a bit odd, and it's a bit painful for review > since you need to skip ahead a few patches to see the end result to tell that > the conversions are consistent and complete. > > IMO it'd be easier for review if that were three patches: > > 1) Convert READ_ONCE() -> ptep_get() > 2) Convert set_pte_at() -> set_ptes() > 3) All the "New layer" renames and addition of the trivial wrappers Yep that makes sense. I'll start prepping that today. I'll hold off reposting until I have your comments on 19-25. I'm also hoping that David will repost the zap series today so that it can get into mm-unstable by mid-next week. Then I'll repost on top of that, hopefully by end of next week, folding in all your comments. This should give planty of time to soak in linux-next. Thanks, Ryan > > Patch 18 looks fine to me. > >> - 19: functional contpte implementation >> - 20-25: various optimizations on top of the contpte implementation > > I'll try to dig into these over the next few days. > > Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel